Which version do you use?dsugums » Mon Jun 23, 2014 9:13 am wrote:2nd entry for GY on the 2nd hour of London netted 10pips @6%.
EU short entry not going anywhere for the moment. Technically no more trades after this hour.
Total banked in 18% for the day
The one in the 1st post. I changed the tp to 10pips.pete14 » Mon Jun 23, 2014 9:26 am wrote:Which version do you use?dsugums » Mon Jun 23, 2014 9:13 am wrote:2nd entry for GY on the 2nd hour of London netted 10pips @6%.
EU short entry not going anywhere for the moment. Technically no more trades after this hour.
Total banked in 18% for the day
Yours or Steve's?
Did you use BE and TS on your trades? If yes, what did you use?dsugums » Mon Jun 23, 2014 4:48 pm wrote:The one in the 1st post. I changed the tp to 10pips.pete14 » Mon Jun 23, 2014 9:26 am wrote:Which version do you use?dsugums » Mon Jun 23, 2014 9:13 am wrote:2nd entry for GY on the 2nd hour of London netted 10pips @6%.
EU short entry not going anywhere for the moment. Technically no more trades after this hour.
Total banked in 18% for the day
Yours or Steve's?
Closed EU for 10pips.
That conclude the trades for this session.
Okay, got it. No wonder my trades got stopped out at BE and later only to see it going to TP !dsugums » Mon Jun 23, 2014 5:31 pm wrote:I am not using BE or TS. Its either TP or SL trade.
Did you actually start at the beginning of Frankfurt rather than London? That tends to make more sense based on the trades you're describing.dsugums » Mon Jun 23, 2014 4:48 pm wrote:The one in the 1st post. I changed the tp to 10pips.pete14 » Mon Jun 23, 2014 9:26 am wrote:Which version do you use?dsugums » Mon Jun 23, 2014 9:13 am wrote:2nd entry for GY on the 2nd hour of London netted 10pips @6%.
EU short entry not going anywhere for the moment. Technically no more trades after this hour.
Total banked in 18% for the day
Yours or Steve's?
Closed EU for 10pips.
That conclude the trades for this session.
Don't push your luck
This EA can make magnificent profits within a short period of time. Do not push your luck by over-trading. The input DailyPercentOfBalanceTarget tells the bot to stop trading for the day when your account profit reaches this percentage of your start balance - defaults to 12%.
Code: Select all
if (TimeDayOfWeek(OrderCloseTime()) != TimeDayOfWeek(TimeCurrent()) )
continue;Code: Select all
datetime DayOpenTime = iTime(Symbol(),PERIOD_D1,0);
if(OrderOpenTime() >= DayOpenTime)
OverallProfit+= (OrderProfit() + OrderSwap() + OrderCommission() );
Not going to do anything with this. The scalper is in and out so quickly that it hardly matters if the equity is taking a beating - this is only temporary. My GP demo deletes outstanding pending trades if filling one takes the margin down to where there would be insufficient margin to allow the trade, so I assume every one else's platform does this as well.SpiderX » Mon Jun 23, 2014 12:47 pm wrote:Hi Steve,
With regards to the code below, line 3450...
After the EA have traded for a week a so, shouldnt there be past trades that have the same TimeDayOfWeek as today's trade ?Code: Select all
if (TimeDayOfWeek(OrderCloseTime()) != TimeDayOfWeek(TimeCurrent()) ) continue;
i.e We closed 3 trades last Monday, and today is Monday again....how does this distinguish between this Monday's trade and last Monday ?
Hopefully, i didnt miss anything here.
Suggested:
I did not bother to consider this because I tend only to have today's trades in my history tab. It is a good point and I will adopt your idea.Code: Select all
datetime DayOpenTime = iTime(Symbol(),PERIOD_D1,0); if(OrderOpenTime() >= DayOpenTime) OverallProfit+= (OrderProfit() + OrderSwap() + OrderCommission() );
In addition, another useful feature perhaps is an equity close that works in tandem with DailyPercentOfBalanceTarget....
Once AccountEquity hits DailyPercentOfBalanceTarget + BufferPercent ....close all open trades. (BufferPercent covers for trading cost and possible slippage)
imo, this makes sense in the light of reducing risk and not staying in the market for too long.
Of course, MTBM could be used for this too, but this should be nice as a add-on feature to the EA.
Cheers
Code: Select all
void CanWeStopTrading()
{
AllAccountProfitToday = 0;
if (OrdersHistoryTotal() == 0)
{
DailyTargetHit = false;
return;
}//if (OrdersHistoryTotal() == 0)
datetime DayOpenTime = iTime(Symbol(),PERIOD_D1,0);
for (int cc = OrdersHistoryTotal() - 1; cc >= 0; cc--)
{
if (!OrderSelect(cc, SELECT_BY_POS, MODE_HISTORY) )
continue;
if(OrderOpenTime() >= DayOpenTime)
AllAccountProfitToday+= (OrderProfit() + OrderSwap() + OrderCommission());
}//for (int cc = OrdersHistoryTotal() - 1; cc>= 0; cc++)
//AllAccountProfitToday = 0 means no trades today
if(CloseEnough(AllAccountProfitToday, 0) )
{
DailyTargetHit = false;
ProfitPercentToday = 0;
StartBalance = AccountBalance();
return;
}//if(CloseEnough(AllAccountProfitToday, 0) )
StartBalance = AccountBalance() - AllAccountProfitToday;
ProfitPercentToday = (AllAccountProfitToday / StartBalance) * 100;
if (ProfitPercentToday >= DailyPercentOfBalanceTarget)
DailyTargetHit = true;
}//void CanWeStopTrading()