Pamsy

User avatar
SteveHopwood
Owner
Posts: 9754
Joined: Tue Nov 15, 2011 8:43 am
Location: Misterton - an insignificant village in England. Very pleasant to live in.

Pamsy

Post by SteveHopwood »

DigitalCrypto » Tue Feb 02, 2016 11:51 pm wrote: @Steve
Do you have a function that can stop trading for the day once a goal has been reached?
Will have tomorrow.

:xm:
Read the effing manual, ok?

Afterprime is the official SHF broker. Read about them at https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?p=175790#p175790.

I still suffer from OCCD. Good thing, really.

Anyone here feeling generous? My paypal account is always in the market for a tiny donation. [email protected] is the account.

To see The Weekly Roundup of stuff you guys might have missed Click here

My special thanks to Thomas (tomele) for all the incredible work he does here.
sudhindragk
Trader
Posts: 45
Joined: Sat Nov 23, 2013 5:31 pm

Pamsy

Post by sudhindragk »

DigitalCrypto » Mon Feb 01, 2016 8:28 pm wrote:@Steve,

Still seeing PAM entry line being drawn wrong.

If there is a lower low it shouldn't put a line at all. I couldn't decipher the advanced coding to make heads or tails of it.

Hi David,

was this an issue? or is it resolved?

Regards
Sudhi
DigitalCrypto
Trader
Posts: 237
Joined: Tue Feb 24, 2015 4:38 am

Pamsy

Post by DigitalCrypto »

I think the solution was a simple check to see if the PAM iCandle was the lowest low or highest high. Steve will need to advise on this. I tend to be a cold hearted code breaker when I mess around under the hood....ergo I don't
nixxx
Trader
Posts: 32
Joined: Sun Dec 21, 2014 11:17 am

Pamsy

Post by nixxx »

Wrong signals + too late?
You do not have the required permissions to view the files attached to this post.
User avatar
SteveHopwood
Owner
Posts: 9754
Joined: Tue Nov 15, 2011 8:43 am
Location: Misterton - an insignificant village in England. Very pleasant to live in.

Pamsy

Post by SteveHopwood »

V 1b is in post 1.

I have added a new input. DailyProfitTargetPips (in General Inputs) is your daily target per pair in pips. Pamsy will stop trading for the day when this target is hit. It is a blunt instrument in that it uses your broker's D1 candle. This may or may not be related to the trading day.

The buy/sell lines remain on the chart until the next PAM so that the ea knows that the PAM has already been traded. I can have it change colour if it bothers people.

:xm:
Read the effing manual, ok?

Afterprime is the official SHF broker. Read about them at https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?p=175790#p175790.

I still suffer from OCCD. Good thing, really.

Anyone here feeling generous? My paypal account is always in the market for a tiny donation. [email protected] is the account.

To see The Weekly Roundup of stuff you guys might have missed Click here

My special thanks to Thomas (tomele) for all the incredible work he does here.
User avatar
SteveHopwood
Owner
Posts: 9754
Joined: Tue Nov 15, 2011 8:43 am
Location: Misterton - an insignificant village in England. Very pleasant to live in.

Pamsy

Post by SteveHopwood »

I forgot to add a call to the chart feedback display function to 1b, so it looks as though the bot has frozen. Fixed in 1c in post 1.

Make your own change by going to line 3525 and replace this code:

Code: Select all

//Have we reached our daily profit target
      ShopShut = HaveWeHitDailyTarget();
      if (ShopShut)
         return;
with

Code: Select all

//Have we reached our daily profit target
      ShopShut = HaveWeHitDailyTarget();
      if (ShopShut)
      {
         DisplayUserFeedback();
         return;
      }//if (ShopShut)
:xm:
Read the effing manual, ok?

Afterprime is the official SHF broker. Read about them at https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?p=175790#p175790.

I still suffer from OCCD. Good thing, really.

Anyone here feeling generous? My paypal account is always in the market for a tiny donation. [email protected] is the account.

To see The Weekly Roundup of stuff you guys might have missed Click here

My special thanks to Thomas (tomele) for all the incredible work he does here.
User avatar
SteveHopwood
Owner
Posts: 9754
Joined: Tue Nov 15, 2011 8:43 am
Location: Misterton - an insignificant village in England. Very pleasant to live in.

Pamsy

Post by SteveHopwood »

For the minuscule number of people taking a blind bit of notice of their charts, here is the fix for the bloop you have noticed.

Go to line 1728, which should be a blank line and insert:

Code: Select all

if (OrderCloseTime() < iTime(Symbol(), PERIOD_D1, 0) )
         continue;
Can't be arsed to put an update in post 1.
Read the effing manual, ok?

Afterprime is the official SHF broker. Read about them at https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?p=175790#p175790.

I still suffer from OCCD. Good thing, really.

Anyone here feeling generous? My paypal account is always in the market for a tiny donation. [email protected] is the account.

To see The Weekly Roundup of stuff you guys might have missed Click here

My special thanks to Thomas (tomele) for all the incredible work he does here.
DigitalCrypto
Trader
Posts: 237
Joined: Tue Feb 24, 2015 4:38 am

Pamsy

Post by DigitalCrypto »

Thanks for the updates Steve. I just loaded up the new version and applied the patch.
User avatar
SteveHopwood
Owner
Posts: 9754
Joined: Tue Nov 15, 2011 8:43 am
Location: Misterton - an insignificant village in England. Very pleasant to live in.

Pamsy

Post by SteveHopwood »

V 1d is in post 1. I noticed the chart daily profit display was wrong - a couple of lines of code needed moving outside of a calculation loop.

To make your own change, go to line 3457 and copy this over the top of the existing function:

Code: Select all

bool HaveWeHitDailyTarget()
{

   //Calculate the daily profit so far. Return true if daily target hit, else false
   
   if (OrdersHistoryTotal() == 0)
      return(false);
   
   PipsProfitToday = 0;
      
   for (int cc = OrdersHistoryTotal() - 1; cc >= 0; cc--)
   {
      if (!OrderSelect(cc, SELECT_BY_POS, MODE_HISTORY) ) continue;
      if (OrderMagicNumber() != MagicNumber) continue;
      if (OrderSymbol() != Symbol() ) continue;
      if (OrderCloseTime() < iTime(Symbol(), PERIOD_D1, 0) )
         continue;
      
      double pips = CalculateTradeProfitInPips(OrderType() );
      PipsProfitToday+= pips;
     
         
   }//for (int cc = OrdersHistoryTotal() - 1; cc >= 0; cc--)
   
   if (PipsProfitToday >= DailyProfitTargetPips)
      return(true);
   
   //Got this far, so target not hit yet
   return(false);


}//End bool HaveWeHitDailyTarget()
If you are more confident with making tiny changes you will see in your current version these two lines inside the calculation loop:

Code: Select all

if (PipsProfitToday >= DailyProfitTargetPips)
      return(true);
They need to be the first code block outside of the loop.


:xm:
Read the effing manual, ok?

Afterprime is the official SHF broker. Read about them at https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?p=175790#p175790.

I still suffer from OCCD. Good thing, really.

Anyone here feeling generous? My paypal account is always in the market for a tiny donation. [email protected] is the account.

To see The Weekly Roundup of stuff you guys might have missed Click here

My special thanks to Thomas (tomele) for all the incredible work he does here.
User avatar
DNTme
Trader
Posts: 36
Joined: Wed Sep 19, 2012 10:37 pm

Pamsy

Post by DNTme »

I just love this EA ......ok, maybe im too excited and its my first day with it..but i love its logic and also trading with SL and TP... :hi:

So far...today: 7 trades on EA ECAD GCAD GA

will update from time to time! thanks Steve :good:
You do not have the required permissions to view the files attached to this post.
Last edited by DNTme on Tue Mar 22, 2016 11:48 am, edited 1 time in total.
Locked

Return to “Automated trading systems”