TradeChart

Thingies such as TradeReport and TradeChart

TradeChart

Postby renexxxx » Wed Nov 18, 2020 8:06 am

tomele » Sat Nov 07, 2020 9:29 pm wrote:As this puts unnecessary load on the trade servers, Nicholas from GP asked me to inform the coder of TradeChart that his program is doing something he might not be aware of. Which I have done hereby.

Noted.

Over the years I have had many complaints about TradeChart (and also TradeReport), but never something like this. I have never experienced this "bug" myself and I have not been able to reproduce it. So, it is a bit hard to diagnose, let alone fix it.

So, apparently, TradeChart is overloading the trade server with "messages". Looking at the code, the only thing I can see that TradeChart is bothering the trade server with is with the message that says "Enable all Trade History". Some people only want to see just the last day or the last week of trade activity in their "Account History"-tab, but for TradeChart to work well, it needs to have access to the entire history since the beginning of the account. In TradeChart3 and TradeChart4 this message was sent to the trade server every 30 seconds. It is still beyond me that the poor trade server can not handle this but alas.

Anyway, in the new version, this message is only sent once, in OnInit(). So, if someone goes crazy with flipping through timeframes or changing parameters, it could still upset the trade server. However, it should not if you leave the indicator alone.

Also, the new version is making good on my earlier promise to merge TradeReport and TradeChart.

I attach a test version of the new code here ... it is called TestTradeReport, to be renamed to TradeReport when testing is complete. If someone can think of a better name (given that it also contains the TradeChart functionality), please shout.

For now, I will only attach the .ex4 file. But once I've cleaned up the code and the new version has proven to be working well, I will also attach the source code, so that someone can change two lines and sell it on eBay for $99. You're welcome.

PS: In order to see the TradeChart-like metrics (what used to be under the "Info" button), set the ShowExtendedStats parameter to true
You do not have the required permissions to view the files attached to this post.
User avatar
renexxxx
 
Posts: 855
Joined: Sat Dec 31, 2011 3:48 am

TradeChart

Postby barry » Wed Nov 18, 2020 11:32 am

Thanks for doing that Rene.
A new name - maybe something like TradeMetrics?
barry
 
Posts: 80
Joined: Thu Mar 01, 2012 5:12 am

TradeChart

Postby heart1010 » Wed Nov 25, 2020 9:43 pm

Thanks Rene - first tests with the new/combined indicator doing ok so far here
heart1010
 
Posts: 46
Joined: Wed Mar 30, 2016 8:33 pm

TradeChart

Postby c1borg » Thu Nov 26, 2020 2:52 pm

Absolutely love it :yahoo:
User avatar
c1borg
 
Posts: 423
Joined: Sun Aug 14, 2016 5:09 pm

TradeChart

Postby Tebis » Thu Nov 26, 2020 3:36 pm

Hi Rene, thanks a lot for the update. :good:
User avatar
Tebis
 
Posts: 113
Joined: Wed Nov 16, 2011 9:50 am
Location: Switzerland

TradeChart

Postby biobier » Tue Jan 05, 2021 11:12 am

I like the new version, good job. :good:
On one of my accounts I get an error (default settings):
2021.01.05 07:02:52.366 TradeReport XAUUSD-ECN,H1: zero divide in 'TestTradeReport.mq4' (2250,176)
biobier
 
Posts: 46
Joined: Mon Mar 18, 2019 7:24 am

TradeChart

Postby renexxxx » Tue Jan 05, 2021 7:29 pm

biobier » Tue Jan 05, 2021 9:12 pm wrote:On one of my accounts I get an error (default settings):
2021.01.05 07:02:52.366 TradeReport XAUUSD-ECN,H1: zero divide in 'TestTradeReport.mq4' (2250,176)

Thanks for the feedback. Can you check if the attached version (below) solves the mentioned zero divide?
You do not have the required permissions to view the files attached to this post.
User avatar
renexxxx
 
Posts: 855
Joined: Sat Dec 31, 2011 3:48 am

TradeChart

Postby biobier » Wed Jan 06, 2021 7:21 am

renexxxx » Tue Jan 05, 2021 8:29 pm wrote:Thanks for the feedback. Can you check if the attached version (below) solves the mentioned zero divide?

Yes, it does! Thanks.
biobier
 
Posts: 46
Joined: Mon Mar 18, 2019 7:24 am

TradeChart

Postby jptwardy » Thu Jan 07, 2021 9:55 pm

Hi Rene - just tried the new testradereport indi - just great! Just one comment,question. I noticed when changing the graph line colors the color key on the screen does not change - is it supposed to? Since I can't see blue or green the color key is unreadable. I changed the graph lines so I can see them fine. Thanks
jptwardy
 
Posts: 15
Joined: Thu Nov 12, 2020 2:16 pm

TradeChart

Postby renexxxx » Fri Jan 08, 2021 3:45 am

jptwardy » Fri Jan 08, 2021 7:55 am wrote:I noticed when changing the graph line colors the color key on the screen does not change - is it supposed to?

Hi jpt,

I've made a little change to the code such that the colors of the Equity/Balance labels are the same as those of the Equity/Balance lines. However, you now have to configure those colors using the input parameters, eg:
2021-01-08_133256.png

and no longer with the color selection from the color-tab:
2021-01-08_133712.png

Let me know if this floats your boat.
You do not have the required permissions to view the files attached to this post.
User avatar
renexxxx
 
Posts: 855
Joined: Sat Dec 31, 2011 3:48 am

PreviousNext

Return to Data analysis tools

Who is online

Users browsing this forum: No registered users and 1 guest

cron