Fratelli EA by Dragos and magft

Post Reply
User avatar
gaheitman
Trader
Posts: 655
Joined: Tue Nov 15, 2011 10:55 pm
Location: Richmond, VA, US

Re: Fratelli EA by Dragos and magft

Post by gaheitman »

garyfritz wrote:New error: "Setting of SL EURUSD ticket no XXXXXXX failed with error (1): no error"

Also happens with breakeven SLs.

I believe those were all fixed in ver 2.5 of the bot. Can you confirm your version?
garyfritz

Re: Fratelli EA by Dragos and magft

Post by garyfritz »

Comment at the top of the file sez: "Fratelli Ea v2.5.mq4"
xlitang
Trader
Posts: 42
Joined: Mon Nov 21, 2011 8:33 pm

Re: Fratelli EA by Dragos and magft

Post by xlitang »

tried to EA with FXDD and got error as "invalid stops". Please advise.
Panamamike
Trader
Posts: 104
Joined: Tue Nov 15, 2011 11:45 pm

Re: Fratelli EA by Dragos and magft

Post by Panamamike »

xlitang wrote:tried to EA with FXDD and got error as "invalid stops". Please advise.
Do you have ECN = true?
User avatar
gaheitman
Trader
Posts: 655
Joined: Tue Nov 15, 2011 10:55 pm
Location: Richmond, VA, US

Re: Fratelli EA by Dragos and magft

Post by gaheitman »

garyfritz wrote:Comment at the top of the file sez: "Fratelli Ea v2.5.mq4"
Mike updated the file without a version change number. Search your copy for the string "err!=1" and if you find it you have the old version. Or, search for "err>1" and if you find it you have the new version.
garyfritz

Re: Fratelli EA by Dragos and magft

Post by garyfritz »

Aha. Yes, I saw mention of that, but I didn't realize there were two versions of 2.5. And sure enough, I have the old one. Early-adopter problems. :)

Looks like there are many cases in the file, so to be safe I just re-downloaded it. Thanks George!
garyfritz

Re: Fratelli EA by Dragos and magft

Post by garyfritz »

OK, I'm getting some trades now, but I'm confused on several points. I'm running the fixed 2.5 EA now, but these trades were entered with the if(err!=0 ... code -- could that have caused this??

* I have an arrow on the 19:30 GMT bar. Candles and histo are red so it should go short 4 pips below the low, or 103.871 - .04 = 103.831. Next bar goes 6.5 pips lower but no entry.

* It goes short in the 20:00 GMT bar -- but why? The short price is above the close of the bar the crossed the EMA. It shorted at the open of that bar so I suspect an order got placed at a higher price and just activated on this bar.

* Notice the SL for the 22:00 trade (20:00 GMT): it's 34.5 pips above the entry. The TP is 10.5 pips below entry. Looks to me like the code thought it entered at 103.894, not 103.749.

* It exited in the 22:20 bar -- why? The High of that bar was 103.788, nowhere near the SL. It shouldn't have moved the SL at that point.

* The second trade again entered at the Open at a price that makes no sense. SL was 40 away, TP was 21 away!?
You do not have the required permissions to view the files attached to this post.
User avatar
gaheitman
Trader
Posts: 655
Joined: Tue Nov 15, 2011 10:55 pm
Location: Richmond, VA, US

Re: Fratelli EA by Dragos and magft

Post by gaheitman »

I suggested another change earlier in the thread that should resolve the odd entry points. Just waiting for one of the two authors to review the suggestion and implement if it makes sense to them. They know it much better than I do, I just happened to have an abundance of time today. :D

As for closing the trades, I believe the strategy calls for closing trades when the signals reverse. Is that what happened?
garyfritz wrote:OK, I'm getting some trades now, but I'm confused on several points. I'm running the fixed 2.5 EA now, but these trades were entered with the if(err!=0 ... code -- could that have caused this??

* I have an arrow on the 19:30 GMT bar. Candles and histo are red so it should go short 4 pips below the low, or 103.871 - .04 = 103.831. Next bar goes 6.5 pips lower but no entry.

* It goes short in the 20:00 GMT bar -- but why? The short price is above the close of the bar the crossed the EMA. It shorted at the open of that bar so I suspect an order got placed at a higher price and just activated on this bar.

* Notice the SL for the 22:00 trade (20:00 GMT): it's 34.5 pips above the entry. The TP is 10.5 pips below entry. Looks to me like the code thought it entered at 103.894, not 103.749.

* It exited in the 22:20 bar -- why? The High of that bar was 103.788, nowhere near the SL. It shouldn't have moved the SL at that point.

* The second trade again entered at the Open at a price that makes no sense. SL was 40 away, TP was 21 away!?
xlitang
Trader
Posts: 42
Joined: Mon Nov 21, 2011 8:33 pm

Re: Fratelli EA by Dragos and magft

Post by xlitang »

Panamamike wrote:
xlitang wrote:tried to EA with FXDD and got error as "invalid stops". Please advise.
Do you have ECN = true?
Yes.
magft
Trader
Posts: 195
Joined: Tue Nov 15, 2011 9:59 pm
Location: East Midlands, UK

Re: Fratelli EA by Dragos and magft

Post by magft »

George thanks for all your help, i have been busy today and just finishing work so no time to really bug fix and i think if i try now i'll break more than i can fix :roll:

I'll look into the mods you suggested about entry, makes sense.

I noticed that after a trade context busy error, usually happens when all pairs move the same which once again implies that we are over exposed in $ and €, the ecn code sends the trade but then doesnt update SL/TP and i then see a invalid stops! Hopefully i'll have time in the morning to investigate.

I had made 16% but by the end of day was down to 9.9% which to be honest if we can do this a few days a month i'd be happy! :mrgreen:

I have used Basket_Stat_Time_Sub and the london session made the most money, so interesting to see how it pans out.

Here is myfxbook account.

Mike
Post Reply

Return to “Automated trading systems”