Multi 10:4 Trader EA

[MrLong]

Andy,

Just wanted to congratulate you an excellent piece of work and point out a little bug in the EA.

The PairIndex variable gets set to the value of the current index (i) in "start"

However, in the places it is used in the grid create and update code, you actually should be using ArraySize[Pairs]. I don't know if you've noticed, the grid tends to misbehave a bit when you load the EA.

try changing

Code: Select all

PairIndex = i;

to

Code: Select all

PairIndex = ArraySize(Pairs);

I'm finding the grid loads more reliably with this change

Thanks DC, it does play up, I'll change it right now.

Thanks

Andy

[simplex]

I am seeing these errors though in Experts. Andy, are these errors insignificant?

2013.04.18 08:00:04 Multi_10_4_EAv2.01a GBPJPY,H4: object name passed to ObjectFind function cannot be an uninitialized or empty string

2013.04.18 08:00:04 Multi_10_4_EAv2.01a GBPJPY,H4: symbol name for MarketInfo function must be a string

2013.04.18 16:16:11 '2137049': Signal - failed parse signals

aagarcia,

do those errors occur (ObjectFind portion) after applying my above mentioned alteration to the source code?

hoping for an answer,

Jürgen

[simplex]

I am seeing these errors though in Experts. Andy, are these errors insignificant?

2013.04.18 08:00:04 Multi_10_4_EAv2.01a GBPJPY,H4: object name passed to ObjectFind function cannot be an uninitialized or empty string

2013.04.18 08:00:04 Multi_10_4_EAv2.01a GBPJPY,H4: symbol name for MarketInfo function must be a string

2013.04.18 16:16:11 '2137049': Signal - failed parse signals

aagarcia,

do those errors occur (ObjectFind portion) after applying my above mentioned alteration to the source code?

hoping for an answer,

Jürgen

Sorry, haven't tried yet. Trades are still open so not sure when I'll download updated version. Thanks

I'm not sure Andy will have the changes I mentioned in his next release. I personally do not face the problems you described. So I was hoping you could try to fix part of it by modifying the version you're currently running without waiting for the next release and report back about the results.

On my demo account I would just modify and recompile even when trades are open. Works within seconds. But - as I mentioned - I do not have those problems so your test and report would be highly appreciated.

Thanks, Jürgen

[MrLong]

I am seeing these errors though in Experts. Andy, are these errors insignificant?

2013.04.18 08:00:04 Multi_10_4_EAv2.01a GBPJPY,H4: object name passed to ObjectFind function cannot be an uninitialized or empty string

2013.04.18 08:00:04 Multi_10_4_EAv2.01a GBPJPY,H4: symbol name for MarketInfo function must be a string

2013.04.18 16:16:11 '2137049': Signal - failed parse signals

aagarcia,

do those errors occur (ObjectFind portion) after applying my above mentioned alteration to the source code?

hoping for an answer,

Jürgen

Sorry, haven't tried yet. Trades are still open so not sure when I'll download updated version. Thanks

I'm not sure Andy will have the changes I mentioned in his next release. I personally do not face the problems you described. So I was hoping you could try to fix part of it by modifying the version you're currently running without waiting for the next release and report back about the results.

On my demo account I would just modify and recompile even when trades are open. Works within seconds. But - as I mentioned - I do not have those problems so your test and report would be highly appreciated.

Thanks, Jürgen

Hi Jürgen,

Yes, I've uploaded the update, did you see the bug DietCoke pointed out?
Thats something I've missed for Months.

Andy

[Sojourner]

Love this thread and this EA!

I'm running version 2.1b with the PairIndex= ArraySize(pairs) modification as suggested above and the only other things I have change is autosymbols to true and tweaked some of the timeframes. I am getting this:
2013.04.18 17:28:50 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:28:50 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:28:23 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:28:23 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:28:12 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:28:12 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:28:02 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:28:02 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:27:22 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:27:22 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:27:08 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:27:08 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:25:32 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:25:32 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:25:16 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:25:16 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:25:01 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:25:01 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:24:52 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:24:52 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:24:40 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:24:40 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:24:19 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:24:19 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:23:26 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:23:26 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:23:16 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string
2013.04.18 17:23:16 Multi_10_4_EAv2.01b EURUSD.,M1: symbol name for MarketInfo function must be a string

The EA DID make pending orders though. Don't know if it will otherwise work.

[theforexedge]

Andy

Would it be difficult to add in a News Module to 10.4?

With the current global situation I find both High Impact News & Central Bank Speaks are causing wild gyrations that can take the currency pairs out of trend for a few days, causing drawdown and hitting stop losses, so having the ability to avoid trading at these times might be another option worth trying....

Whilst i'm not a coder Slipshod has been helping me in my endeavours and I can post the code if you think its worth adding..

My preferred way of using the News (FFCal) is:

1. Only use High Impact & Speaks
2. Avoid trades xxx hours before and xxx hours after (if news goes against the trend this allows you to get back in at lower prices)
3. Option to take profit xx hours before the news for currency pairs.

Additional ideas:

1. Close all profit before weekend
2. Don't trade NFP

I'm sure this subject will prompt some debate, but i think of using the news to get into / back into a trade at lower prices...as a rule I never 'Trade The News' as its a great way of emptying your trading account, although it can be done profitably using Volume Spread Analysis, to look for UpThrusts etc.

BTW - 10.4 2.01b is running with no problems, and up 8% already!!

Jason

[simplex]

I am seeing these errors though in Experts. Andy, are these errors insignificant?

2013.04.18 08:00:04 Multi_10_4_EAv2.01a GBPJPY,H4: object name passed to ObjectFind function cannot be an uninitialized or empty string

2013.04.18 08:00:04 Multi_10_4_EAv2.01a GBPJPY,H4: symbol name for MarketInfo function must be a string

2013.04.18 16:16:11 '2137049': Signal - failed parse signals

aagarcia,

do those errors occur (ObjectFind portion) after applying my above mentioned alteration to the source code?

hoping for an answer,

Jürgen

Sorry, haven't tried yet. Trades are still open so not sure when I'll download updated version. Thanks

I'm not sure Andy will have the changes I mentioned in his next release. I personally do not face the problems you described. So I was hoping you could try to fix part of it by modifying the version you're currently running without waiting for the next release and report back about the results.

On my demo account I would just modify and recompile even when trades are open. Works within seconds. But - as I mentioned - I do not have those problems so your test and report would be highly appreciated.

Thanks, Jürgen

Hi Jürgen,

Yes, I've uploaded the update, did you see the bug DietCoke pointed out?
Thats something I've missed for Months.

Andy

Aaaah - great! Thanks.

@aagarcia: so could you just download the latest version and check, whether the ObjectName error still occurs? No need for manual modifications in this version before you check. Thanks in advance for your contribution.

@Andy: will have a look at the dietcoke stuff in a few minutes.

Jürgen

[MrLong]

I am seeing these errors though in Experts. Andy, are these errors insignificant?

2013.04.18 08:00:04 Multi_10_4_EAv2.01a GBPJPY,H4: object name passed to ObjectFind function cannot be an uninitialized or empty string

2013.04.18 08:00:04 Multi_10_4_EAv2.01a GBPJPY,H4: symbol name for MarketInfo function must be a string

2013.04.18 16:16:11 '2137049': Signal - failed parse signals

aagarcia,

do those errors occur (ObjectFind portion) after applying my above mentioned alteration to the source code?

hoping for an answer,

Jürgen

Sorry, haven't tried yet. Trades are still open so not sure when I'll download updated version. Thanks

I'm not sure Andy will have the changes I mentioned in his next release. I personally do not face the problems you described. So I was hoping you could try to fix part of it by modifying the version you're currently running without waiting for the next release and report back about the results.

On my demo account I would just modify and recompile even when trades are open. Works within seconds. But - as I mentioned - I do not have those problems so your test and report would be highly appreciated.

Thanks, Jürgen

Hi Jürgen,

Yes, I've uploaded the update, did you see the bug DietCoke pointed out?
Thats something I've missed for Months.

Andy

Aaaah - great! Thanks.

@aagarcia: so could you just download the latest version and check, whether the ObjectName error still occurs? No need for manual modifications in this version before you check. Thanks in advance for your contribution.

@Andy: will have a look at the dietcoke stuff in a few minutes.

Jürgen

Haha,

I've got two terminals communicating now, one reads the others drawdown, when its - 5.00, it lets the trades roll, two part EA.

[glabbeek]

I agree that all those filters seem to be needed when you look at the short term action in the currency market. The downside is that you will limit your profitability.

The last few days, due to the action in the JPY, a lot of people thought there was a need to limit the maximum number of pairs containing the same currency. Yesterday and today the winnings are coming out of the JPY. If you would have limited the amount of pairs trading JPY at the same time, you would have missed a lot of profits.

Not trading on high impact news works the same. Most of the time these news comments are in line with the trend and you make a nice profit. Two weeks ago the news was countertrend and we lost some.

Filters can work, but you will cut your winnings.

I think the EA that Andy and co. produced doesn't need any more filters at the moment. Look for the long run.

[rosst]

All positions closed - amazing work! PS - Default - except I changed risk from 2 to 1 & used Auto pairs with FXDD...