global wrote:

SteveHopwood wrote:If, say, StopLoss is declared as an integer as in int StopLoss = 20:
double NewStop = NewStop = OrderOpenPrice() - (StopLoss * Point); is allowed and (StopLoss * Point) creates a 0.xxxxxxxx result.

The command using factor is OrderOpenPrice() - (StopLoss / factor); But, if StopLoss is an integer then the code (StopLoss / factor) returns a zero value.

All the pip values in mptm were declared as integers, so when interacting with factor resulted in 0 being added to whatever the bot was supposed to be doing, and so trades were closing prematurely. All that was needed was to convert them to doubles - something Paul forgot to do and that I did not notice.

So, fix is in post 1; sing out if I am barking at the wrong moon and the fix does not work.

Thanks for the update Steve. I checked your updated code and I'm wondering if the int iPipsAboveVisual variable in line 901 needs to be converted to double iPipsAboveVisual from this line of code...

Code: Select all

bool CheckForHiddenStopLossHit(int type, int iPipsAboveVisual, double stop )

...because a little further down you divide iPipsAboveVisual by Pipfactor as below:

Code: Select all

double sl = NormalizeDouble(stop + (iPipsAboveVisual /Pipfactor), digits);

Mike wrote:Thanks ... clear explanation. What I did: save and compile a version each for D1, H4, H1 by opening the meta editor using Find 1440 Replace all by 240 for H4/ Replace all by 60 for H1. I hope I did not mess up anything.
What I also would like to do is to eliminate all options in the Custom Indicator window, which I do not intend to use for this kind of trade management, but I do not know how (Example):
extern bool ManageByMagicNumber=false;
change to
bool ManageByMagicNumber=false;
but I actuall have no idea what I am really doing.
Thanks again for your modifications and explanations
Mike

global wrote:

Mike wrote:Thanks ... clear explanation. What I did: save and compile a version each for D1, H4, H1 by opening the meta editor using Find 1440 Replace all by 240 for H4/ Replace all by 60 for H1. I hope I did not mess up anything.
What I also would like to do is to eliminate all options in the Custom Indicator window, which I do not intend to use for this kind of trade management, but I do not know how (Example):
extern bool ManageByMagicNumber=false;
change to
bool ManageByMagicNumber=false;
but I actuall have no idea what I am really doing.
Thanks again for your modifications and explanations
Mike

The replace all you did seems fine and yes you can just replace extern bool with bool to remove the options you do not use but make sure that you save a copy of the original EA so that you can remember for which options you removed the extern. Or you can add a comment at the end of every option line you changed like this:

bool ManageByMagicNumber=false; //removed extern variable from input

global wrote:UPDATE Jan 22nd, 2013 of Multi purpose trade managerADMod_D1: For all pips values in the code that were declared as integers, I re-declared them as decimal "double" data types because Steve discovered an Empty4 program anomaly with how it calculates a mixture of int and double data type variables in certain circumstances. I tested it and everything seems fine so I replaced the attached file in the original post with the updated one here: http://www.stevehopwoodforex.com/phpBB3 ... 816#p34816

SteveHopwood wrote:Thanks for all this, global. I have linked your version in post 1. It will help me a lot if you issue further updates in the linked post so I do not have to keep updating. If there is ever a problem doing so, let me know and I will sort it out - being Admin allows me to play God like this.