Need advise on this code

[fxcba]

Hello
It's me again
I found this indi on FF

Color_RSI_v1.01_maxsig.mq4

and changed into this

WPR_MA_SIGNAL-V2.mq4

My problem now is the conditions for signaling up/down are a little bit different. I thinK I'm really close and may be with someone help we can finish it

[SteveHopwood]

Got it
that shows I know nothing

Just stopping by briefly to offer words of encouragement and support. Keep going and learn this stuff - you will not be sorry you made the effort.

All of us knew nothing when we started.

[fxcba]

Thank you for your kind words Steve
cheers

[fxcba]

Well
One more step, it's getting closer, but still I'm missing something, can someone check the "DrawArrow" sintax?

[milanese]

Well
One more step, it's getting closer, but still I'm missing something, can someone check the "DrawArrow" sintax?

looks good.
line 316 I do not understand why you use Point/2 I would use Point...

Cheers

Tommaso

[fxcba]

Well
One more step, it's getting closer, but still I'm missing something, can someone check the "DrawArrow" sintax?

looks good.
line 316 I do not understand why you use Point/2 I would use Point...

Cheers

Tommaso

Hi Tomaso thank you for your time
That is part of original writing I didn't mess there.
My problem is arrows are not following the logic

Edit
Ok, I left only Point and something changed, looks better now ,

[milanese]

Hi Tomaso thank you for your time
That is part of original writing I didn't mess there.
My problem is arrows are not following the logic

Edit
Ok, I left only Point and something changed, looks better now ,

ok I thought so too..

Cheers

Tommaso

[fxcba]

Thank you my friend.
I'll forward test it on my live account and see how it does

Cheers

[fxcba]

Hello ppl

To learn how to do, I'm using a MA cross EA wich doesn't compile on 6xx version, I solved almost all errors but I'm stuck on this part:

Code: Select all

 int subGenerateMagicNumber int MagicNumber, string symbol, int timeFrame
{
   int isymbol =
   if (symbol == "EURUSD")       isymbol = 1;
   else if (symbol == "GBPUSD")  isymbol = 2;
   else if (symbol == "USDJPY")  isymbol = 3;
   else if (symbol == "USDCHF")  isymbol = 4;
   else if (symbol == "AUDUSD")  isymbol = 5;
   else if (symbol == "USDCAD")  isymbol = 6;
   else if (symbol == "EURGBP")  isymbol = 7;
   else if (symbol == "EURJPY")  isymbol = 8;
   else if (symbol == "EURCHF")  isymbol = 9;
   else if (symbol == "EURAUD")  isymbol = 10;
   else if (symbol == "EURCAD")  isymbol = 11;
   else if (symbol == "GBPUSD")  isymbol = 12;
   else if (symbol == "GBPJPY")  isymbol = 13;
   else if (symbol == "GBPCHF")  isymbol = 14;
   else if (symbol == "GBPAUD")  isymbol = 15;
   else if (symbol == "GBPCAD")  isymbol = 16;
   else                          isymbol = 17;
   if(isymbol<10) MagicNumber = MagicNumber * 10;
   return (StrToInteger(StringConcatenate(MagicNumber, isymbol, timeFrame)));
}

I commented all and Ea compiles without errors, but how's magic number sintax?.

[milanese]

Hello ppl

To learn how to do, I'm using a MA cross EA wich doesn't compile on 6xx version, I solved almost all errors but I'm stuck on this part:

Code: Select all

 int subGenerateMagicNumber int MagicNumber, string symbol, int timeFrame
{
   int isymbol =
   if (symbol == "EURUSD")       isymbol = 1;
   else if (symbol == "GBPUSD")  isymbol = 2;
   else if (symbol == "USDJPY")  isymbol = 3;
   else if (symbol == "USDCHF")  isymbol = 4;
   else if (symbol == "AUDUSD")  isymbol = 5;
   else if (symbol == "USDCAD")  isymbol = 6;
   else if (symbol == "EURGBP")  isymbol = 7;
   else if (symbol == "EURJPY")  isymbol = 8;
   else if (symbol == "EURCHF")  isymbol = 9;
   else if (symbol == "EURAUD")  isymbol = 10;
   else if (symbol == "EURCAD")  isymbol = 11;
   else if (symbol == "GBPUSD")  isymbol = 12;
   else if (symbol == "GBPJPY")  isymbol = 13;
   else if (symbol == "GBPCHF")  isymbol = 14;
   else if (symbol == "GBPAUD")  isymbol = 15;
   else if (symbol == "GBPCAD")  isymbol = 16;
   else                          isymbol = 17;
   if(isymbol<10) MagicNumber = MagicNumber * 10;
   return (StrToInteger(StringConcatenate(MagicNumber, isymbol, timeFrame)));
}

I commented all and Ea compiles without errors, but how's magic number sintax?.

maybe you can attach the EA, than I can take a look ..

Cheers

Tommaso