SteveHopwood wrote:It looks to me as though you are making some progress here, Peter. I will include a link when I next do one of my member-wide pm's to see if others are interested.

fx8000 wrote:

fx8000 wrote:

fx8000 wrote:The Dibs ea MOD with Rsi made a steady start this trading week with a gain of 1.6% of account balance. It had been 2.9% up early Tuesday before falling back.

The candletrailingstop after breakeven had a positive impact on its performance. Previously the trades get stopped out prematurely before they have a chance to develop.

Results attached below.

After a lackluster day yesterday, the ea is still showing a gain of $167 or 1.6% of equity balance.

Account balance currently up 2%.

Also started another demo trading DIBS EA MOD with RSI on H1 TF on multiple pairs, starting balance $10k, lot = 1, TP = 100, part close = 0, BE@30+1, JS30, Candletrailstop after BE.

BTW, I have further modified the DIBS EA to trade irrespective of the day's opening price as follows :
//Define trading direction
DayOpenPrice = ObjectGetValueByShift(todayopenprice, 0);
direction = none;
RefreshRates();
if (TradeLong) direction = up;
if (TradeShort) direction = down;

I am currently testing to use the modified ea to buy from support zones and sell from resistance zones. At support/resistance zones, you often find consolidation, and inside bar is a powerful reversal signal at these areas. This modified ea can be used to trade reversals in these zones.

Will any kind souls (coders) out there please check my modified code to see if it is correct. So far, it appears to be working but has missed some trade set ups.

Thanks in advance.

Peter

SteveHopwood wrote:You defined two constants with the same name as the functions i.e.

Code: Select all

//#define  CheckSupply "Check Suppy"
//#define  CheckDemand "Check Demand"

You do not appear to use these two constants, so I have commented them out.

These two constants had spaces in them:

Code: Select all

#define  inside supply "inside.supply"
#define  inside demand "inside.demand"

In my mod, I have removed the spaces because you cannot have them in a constant.

You copied the two function definitions inside start(). I have moved them just above start().

Look at void ReadIndicatorValues() where you have this strange line:
iCustom ( NULL, 0, "II_SupDem", 0, 0, 0 );

This appears to do no harm, but also does nothing. You need

Code: Select all

double Something = iCustom ( NULL, 0, "II_SupDem", 0, 0, 0 );

and if Something is used throughout the program, then you need to declare it in the General Declarations section.

Keep at this stuff; you will soon be good at it.

fx8000 wrote:

SteveHopwood wrote:You defined two constants with the same name as the functions i.e.

Code: Select all

//#define  CheckSupply "Check Suppy"
//#define  CheckDemand "Check Demand"

You do not appear to use these two constants, so I have commented them out.

These two constants had spaces in them:

Code: Select all

#define  inside supply "inside.supply"
#define  inside demand "inside.demand"

In my mod, I have removed the spaces because you cannot have them in a constant.

You copied the two function definitions inside start(). I have moved them just above start().

Look at void ReadIndicatorValues() where you have this strange line:
iCustom ( NULL, 0, "II_SupDem", 0, 0, 0 );

This appears to do no harm, but also does nothing. You need

Code: Select all

double Something = iCustom ( NULL, 0, "II_SupDem", 0, 0, 0 );

and if Something is used throughout the program, then you need to declare it in the General Declarations section.

Keep at this stuff; you will soon be good at it.

Hi Steve,

I am sorry to have troubled you again. There are so many brilliant coders in your forum, I was hoping someone other than your good self would lend a helping hand.

I would study your comments the rest of today to see if I understand what you are trying to teach me. All the obstacles I am encountering right now makes me even more determined to learn a bit about coding.

MANY THANKS AGAIN !

Best regards,
Peter.

P.S. Steve, there were 15 error messages, I thought the patient was terminal, and yet you managed to revive him/her, fantastic ! Will be starting a demo tomorrow and report back later.