stevehopwoodforex.com
https://www.stevehopwoodforex.com/phpBB3/
Print view

HGBnD shell
https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=5077		 Page 2 of 5
Author:  SteveHopwood [ Tue Feb 21, 2017 2:38 pm ]
Post subject:  HGBnD shell
There was more wrong than I imagined. :arrrg: I think the shell is working properly now.

:xm:
Author:  SteveHopwood [ Tue Feb 21, 2017 3:54 pm ]
Post subject:  HGBnD shell
You need the same fixes I just described in the HGBnD thread if you downloaded the shell before I typed this post.

:xm:
Author:  SteveHopwood [ Wed Feb 22, 2017 11:08 am ]
Post subject:  HGBnD shell
I have updated the shell again.

I wanted to use it last night, to import the Super Slope trade trigger from the existing HGBnDnSS. I found this code using variables such as MediumTimeFrame, already declared in the buy low sell high stuff.

I have placed 'Hgi' in front of all the HGI inputs and variables, and Blsh somewhere in all the BLSH inputs and variables.

:xm:
Author:  szfxtrader [ Wed Feb 22, 2017 3:01 pm ]
Post subject:  HGBnD shell
Hi Steve,

I would like to make a suggestion for the shell.

Code: Select all

void OnTick()
{

From: ReadIndicatorValues();//This might want moving to the trading section at the end of this function if EveryTickMode = false

To: if (EveryTickMode) ReadIndicatorValues();

//From:
//Trading
      if (EveryTickMode) OldBarsTime = 0;
      if (OldBarsTime != iTime(NULL, TradingTimeFrame, 0)) {
         OldBarsTime = iTime(NULL, TradingTimeFrame, 0);
         //ReadIndicatorValues(); Remember to delete the call higher up in this function if EveryTickMode = false

//To:
.
.
.
if (!EveryTickMode) ReadIndicatorValues(); //Remember to delete the call higher up in this function if EveryTickMode = false
I am not writing the lines numbers because the shell that I am using is not the same as yours.
Author:  SteveHopwood [ Thu Feb 23, 2017 11:09 am ]
Post subject:  HGBnD shell
I have updated both files in post 1. I have added the missing code to deal with the HgiCloseOnYellowRangeWave input. I have placed the relevant code within void ShouldTradesBeClosed().

:xm:
Author:  SteveHopwood [ Wed Mar 08, 2017 3:14 pm ]
Post subject:  HGBnD shell
Latest update to the shell and library are in post 1.

I realised that we need bool LookForTradeClosure(int ticket) in the shell rather than the library as coders will want closures based on the indi they are adding. bool LookForTradeClosure(int ticket) in the library has morphed into bool LookForUsualTradeClosure(int ticket).

:xm:
Author:  SteveHopwood [ Fri Mar 10, 2017 11:07 am ]
Post subject:  HGBnD shell
A little thingy I just noticed is that comments in the core library code replace the external input in the ea's inputs window. The six inputs that had "//Server time" after the variable only show "Server time" in the inputs window.

Either delete the six comments or use this feature to describe the variable's use more descriptively - along the lines of "//Enter your Friday stop trading hour in server time". I have updated the library in post 1 for newcomers.

:xm:
Author:  SteveHopwood [ Sun Mar 12, 2017 11:18 am ]
Post subject:  HGBnD shell
I have started to convert existing versions of the HGBnD family and the first thing I found was that DisplayUserFeedback() needs to be in the .mq4 file, not the .mqh

I have made these changes to the files in post 1, for newcomers.

:xm:
Author:  szfxtrader [ Wed Mar 22, 2017 9:31 am ]
Post subject:  HGBnD shell
SteveHopwood » Sun Mar 12, 2017 11:18 am wrote:I have started to convert existing versions of the HGBnD family and the first thing I found was that DisplayUserFeedback() needs to be in the .mq4 file, not the .mqh

I have made these changes to the files in post 1, for newcomers.

:xm:
Thank you very much! I would like to make a suggestion about the SendMail messages.

1749 from: SendMail("Trade sent ", Symbol() + stype + "trade at " + TimeToStr(TimeCurrent(), TIME_DATE|TIME_MINUTES));

to: SendMail("Trade sent", Symbol() + " @ " + DoubleToStr(Ask, Digits) + " - " + stype + " trade at " + TimeToStr(TimeCurrent(), TIME_DATE|TIME_MINUTES));


1791 from: SendMail("Trade alert. ", Symbol() + " " + stype + " trade has triggered. " + TimeToStr(TimeLocal(), TIME_DATE|TIME_MINUTES|TIME_SECONDS ));

to: SendMail("Trade Alert", Symbol() + " @ " + DoubleToStr(Ask, Digits) + " - " + stype + " trade has triggered. " + TimeToStr(TimeLocal(), TIME_DATE|TIME_MINUTES|TIME_SECONDS ));

It will be much easier for the person has an idea where the EA has opened the trades.
Author:  SteveHopwood [ Wed Mar 22, 2017 9:59 am ]
Post subject:  HGBnD shell
szfxtrader » Wed Mar 22, 2017 9:31 am wrote:
Thank you very much! I would like to make a suggestion about the SendMail messages.

1749 from: SendMail("Trade sent ", Symbol() + stype + "trade at " + TimeToStr(TimeCurrent(), TIME_DATE|TIME_MINUTES));

to: SendMail("Trade sent", Symbol() + " @ " + DoubleToStr(Ask, Digits) + " - " + stype + " trade at " + TimeToStr(TimeCurrent(), TIME_DATE|TIME_MINUTES));

1791 from: SendMail("Trade alert. ", Symbol() + " " + stype + " trade has triggered. " + TimeToStr(TimeLocal(), TIME_DATE|TIME_MINUTES|TIME_SECONDS ));

to: SendMail("Trade Alert", Symbol() + " @ " + DoubleToStr(Ask, Digits) + " - " + stype + " trade has triggered. " + TimeToStr(TimeLocal(), TIME_DATE|TIME_MINUTES|TIME_SECONDS ));

It will be much easier for the person has an idea where the EA has opened the trades.
Suggestion adopted. :clap: :clap:

:xm:
All times are UTC Page 2 of 5

Powered by phpBB® Forum Software © phpBB Limited