HiArt99 wrote:Hi Steve,

being a hack coder, I tracked down the issue for commodities and Indices on MPTM.

The PFactor factor subroutine did not cater for them, and my criminal doesn't use the same code for Gold for example.

To address this I have added 3 external strings:

Code: Select all

extern string  BetPer1Pairs                  ="UK100,WS30,DAX30,NAS100,CAC40";
extern string  BetPer10thsPairs              ="GOLD,SP500";
extern string  BetPer100thsPairs             ="WTI,BRENT,SILVER,JPY";

Now I have been through my pairs and pressed F9 to open a trade. If it said "bet per 1" the pair stub went in my "BetPer1Pairs", and so on. I have done this so folks whose criminals use different names (WTI is crude for me, but it could by CL or Nymex, etc) can adapt MPTM to their platform.

I then adapted PairsQty() to return the Pairs in the 3 strings:

Code: Select all

int BetPerQty(string betper)
{
   int i = 0;
   int j;
   int qty=0;
   
   while(i > -1)
      {
         i = StringFind(betper, ",",j);
         if (i > -1)
         {
            qty ++;
            j = i+1;            
         }
      }
      return(qty);
}

Finally adapted PFactor to cycle through these pairs, and set and return the correct factor

Code: Select all

double PFactor(string pair)
{
   double Pipfactor=10000;         // correct factor for most pairs

   string betper;
   int i = 0;int j = 0; int betperqty; int k; int pf = 0;

   for(int cycle = 0; cycle <3; cycle ++){
      switch(cycle){
         case 0: betper = BetPer1Pairs; pf = 1; break;
         case 1: betper = BetPer10thsPairs; pf = 10; break;
         case 2: betper = BetPer100thsPairs; pf = 100; break;
         default: break;
      }

      if (StringSubstr(betper, StringLen(betper)-1) != ",") betper = StringConcatenate(betper,",");

      betperqty = BetPerQty(betper);
      string pairs[]; 
      ArrayResize(pairs, betperqty - 1);
      
      i=0; j=0;

      for (k = 0; k < betperqty; k ++)
      {
         i = StringFind(betper, ",",j);
         if (i > -1)
         {
            pairs[k] = StringSubstr(betper, j,i-j);
            pairs[k] = StringTrimLeft(pairs[k]);
            pairs[k] = StringTrimRight(pairs[k]);
            j = i+1;         
         }
      }


      for (k = 0; k <= ArraySize(pairs); k ++)
      {
	     if (StringFind(pair,pairs[k],0) > -1){ 
		         Pipfactor = pf ;
               Print(Pipfactor);
               return (Pipfactor);
        }
      }
   }

   return (Pipfactor);
}

No doubt you'll be able to tidy up my diseased coding, but I need something like this to get MPTM to work correctly.

Art