magft wrote:

SteveHopwood wrote:youcrazykids, no way am I going to ridicule this. Thanks. I shall look at it and perhaps adopt it.

Mike, sorry but I only saw your latest when looking at yck's post; I missed it when you posted it. Does the code work for our cousins in upside-down land?

Cheers guys

George has posted a much cleaner version that seems to work on my Fratelli EA thread so i'm posting the script here for your thoughts.

garyfritz wrote:Steve, the recent question about CloseEnough() caused me to look at the code, and there is a glaring problem. I don't know how this slipped through before, but it needs to be fixed.

Code: Select all

if (num1 == 0 && num2 == 0) return(true); //0==0
if (MathAbs(num1 - num2) / (num1 + num2) < 0.00000001) return(true);

The test should be
if (MathAbs(num1 - num2) / (MathAbs(num1) + MathAbs(num2)) < 0.00000001) ...

With the current code, if num1 = -num2, you'll get a divide-by-zero error!

Sorry for the goof!
Gary

garyfritz wrote:Steve, the recent question about CloseEnough() caused me to look at the code, and there is a glaring problem. I don't know how this slipped through before, but it needs to be fixed.

Code: Select all

if (num1 == 0 && num2 == 0) return(true); //0==0
if (MathAbs(num1 - num2) / (num1 + num2) < 0.00000001) return(true);

The test should be
if (MathAbs(num1 - num2) / (MathAbs(num1) + MathAbs(num2)) < 0.00000001) ...

With the current code, if num1 = -num2, you'll get a divide-by-zero error!

Sorry for the goof!
Gary

fxdaytrader wrote:I tried to change the ea shell (bare bones), added some functions (like psar trailing) and made it modular so building new eas should be less complicated for ones who are not familiar with mql.
See sourcecode for details

Bare Bones Slope EA.shell ea code.ex4

Bare Bones Slope EA.shell ea code.mq4
main module, belongs to /experts/ folder. It includes all the mainfunctions (like trademanagement).
"TradeLong" and "TradeShort" are set to false, so if you want the ea to open trades, set it to true!

If the mainmodule is bugfree, you do not have to change anything there.
Just edit the include-file, specifie its name in line 26 in the main module (current: #include <include.ea-shell.bare-bones_slope_EA.mqh>), save it under a new name and that is it.

include.ea-shell.bare-bones_slope_EA.mqh
belongs to experts/include/ folder. Includes all the functions of the ea you want to build. Please see instructions in the sourcecode.

include.ea-blank.mqh
blank include file, just the necessary functions, so its easy to understand how it works.

I added some standard-indicator functions, may be they are useful for somebody.
But I do not know if these are correct:
double getVROC(string symbol,int timeframe,int period,int shift)
double getPVT(string symbol,int timeframe,int applied_price,int shift)
double getASI(string symbol,int timeframe,double T,int shift)

~Mt4iSendMail_setup.zip
setup for the Mt4i SendMail library, may be also downloaded at http://www.mt4i.com/appstore/app.aspx?id=17

~twt_twitter_setup.zip
the twitter client, may be also downloaded at http://code.google.com/p/twt/
The twt.exe and the config (will be created after successful initialization) belong to the experts/fildes/-folder.

CmdExe.mqh
belongs to experts/include/-folder. Is needed if you want to use the twitter function.


Please report bugs

Bare Bones Slope EA.shell ea code.mq4

include.ea-shell.bare-bones_slope_EA.mqh

Bare Bones Slope EA.shell ea code.ex4

~Mt4iSendMail_setup.zip

~twt_twitter_setup.zip

CmdExe.mqh

include.ea-blank.mqh

fxdaytrader wrote:I tried to change the ea shell (bare bones), added some functions (like psar trailing) and made it modular so building new eas should be less complicated for ones who are not familiar with mql.
See sourcecode for details

fxdaytrader wrote:Attached one modul for the use of icustom-indicators.
specify the buffers and values to look for (see sourcecode) ...

include.icustomIndicatorSignals_EA.mqh

The main module (here named bare bones) can be found here