fxdaytrader wrote:I wonder about the following condition for re-entry trades:

if (OpenTrades > 0) SendLong = false;//5
and
if (OpenTrades > 0) SendShort = false;//5

Assuming we got the mainentry already we had an open trade - so opentrades would be at least 1 ...
Or do I overlook something?

Hm, I think the MaxTradesAllowed variable could be useful to limit the opentrades count also in general (or more sophisticated, e.g. maxopenmaintrades=xyz, maxreentrytrades=abc, maxstacktrades=ghi)?

For the re-entry-trades (+ stacktrades) it imho could make sense to check if the previous trades are in profit (may be to be choosen by user if to activate, AddToProfitTradesOnly=true ..).

SteveHopwood wrote:V 1g is in post 1.

• added a filter that will stop BASA taking a second trade during the candle in which an earlier trade closed.
• added Andy's moving average stacking function - details in 'Moving Average stacking' in post 1.
• added trade stacking - details in 'Trade stacking.' in post 1

Trade stacking has huge potential - we all had a trade or two that moved a few hundred pips last week, so imagine we had taken extra trades as the market moved for us. How to initiate stack trades is going to be the big discussion point.

OldTrader wrote:

fxozgirl wrote:
Ok, fair call
I thought I had specified that for re-entry trades, but looking back I hadn't...
So, can we have it so it only trades once per candle?
and there has to be a close above/below 60 lwma to validate the set up.

Main entry's all look to be good

So now there does need to be close above/below lwma for reentry?

SteveHopwood wrote:

MrLong wrote:The Ma's I actually use for the stack are the 21 EMA and 55 EMA:

Code: Select all

 if (useMaStack && (!detectMaStack(CurrentPair, PERIOD_H4, 21, 55, 0, MODE_EMA, PRICE_CLOSE, OP_BUY, 0)))

I can add stacking moving average inputs as user choices. Why these particular ones?

I also use the CSS H1 to try confirm the pullback is over and CSS H1 strength starts heading in my direction with:

Code: Select all

 extern double breakDifferenceThreshold    = 3.5;   // for the break slope .

  if (useCSSH1 && (!cssLongH1 > cssShortH1))
            continue;

 if (useCSSH1 && (!MathAbs(myDiff) > breakDifferenceThreshold))             // got to have broke out  and into my direction
        continue;

Hope this also helps

Andy

The second bit does not unless I am right in this: you use Lib.CSS to find the values of cssLongH1 and cssShortH1? And that the two variables are those that you have defined elsewhere in your code?

Actually, now I read it after posting, the makes no sense. Nope, not a clue what you mean.

fxozgirl wrote: So wondered is it possible to turn on/off re-entry trades in case someone would prefer to only trade main entry's?

SteveHopwood wrote:That damn modification did not work - I closed down my re-entry trades and the blasted bot took them again straight away. I have removed it from post 1 and will sort it out in the morning. It is late here in the UK and I am far too irritated to try to deal with it right now.

extern bool useOneTrade        = true;

extern int  barTimeframe = PERIOD_H4;

//+------------------------------------------------------------------+
//|  Checks number order for the  timeframe                                    |
//+------------------------------------------------------------------+
int checkBarOrders(){
int barOrders = 0;
for(int i = OrdersTotal()-1; i >=0; i--){
OrderSelect(i, SELECT_BY_POS,MODE_TRADES);
if(OrderSymbol()==Symbol() && (OrderOpenTime() >= iTime(Symbol(), barTimeframe, 0))) {
barOrders += 1;
}}

for(i = OrdersHistoryTotal()-1; i >=0; i--){
OrderSelect(i, SELECT_BY_POS,MODE_HISTORY);
if( OrderSymbol()==Symbol() && (OrderCloseTime() >= iTime(Symbol(),barTimeframe, 0))) {
barOrders += 1;
}}
return(barOrders);
}

        if( useOneTrade && checkBarOrders () >= 1)
         continue;

MrLong wrote:

SteveHopwood wrote:That damn modification did not work - I closed down my re-entry trades and the blasted bot took them again straight away. I have removed it from post 1 and will sort it out in the morning. It is late here in the UK and I am far too irritated to try to deal with it right now.

Hi Steve,

One trade per bar:

Code: Select all

extern bool useOneTrade        = true;

extern int  barTimeframe = PERIOD_H4;

//+------------------------------------------------------------------+
//|  Checks number order for the  timeframe                                    |
//+------------------------------------------------------------------+
int checkBarOrders(){
int barOrders = 0;
for(int i = OrdersTotal()-1; i >=0; i--){
OrderSelect(i, SELECT_BY_POS,MODE_TRADES);
if(OrderSymbol()==Symbol() && (OrderOpenTime() >= iTime(Symbol(), barTimeframe, 0))) {
barOrders += 1;
}}

for(i = OrdersHistoryTotal()-1; i >=0; i--){
OrderSelect(i, SELECT_BY_POS,MODE_HISTORY);
if( OrderSymbol()==Symbol() && (OrderCloseTime() >= iTime(Symbol(),barTimeframe, 0))) {
barOrders += 1;
}}
return(barOrders);
}

And call like:

Code: Select all

        if( useOneTrade && checkBarOrders () >= 1)
         continue;

Assuming this is what you are looking to do.

Best Regards

Andy