stevehopwoodforex.com
https://www.stevehopwoodforex.com/phpBB3/
Print view

Awesome - original version
https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=5232
Page 12 of 46
Author:  Javajames [ Fri Aug 04, 2017 6:41 am ]
Post subject:  Awesome

Hi TJF,
At first a big thank you for your valuable contribution to Awesome....would you please post your 2nd indy on your last post the one which shows a good summary of your account
Thanks a lot I have already TradeReport but not the other one
Author:  TraderJoeForex [ Fri Aug 04, 2017 6:50 am ]
Post subject:  Awesome

Javajames » Fri Aug 04, 2017 6:41 am wrote:Hi TJF,
At first a big thank you for your valuable contribution to Awesome....would you please post your 2nd indy on your last post the one which shows a good summary of your account
Thanks a lot I have already TradeReport but not the other one
You will find it here, thanks to Rene :smile:

http://www.stevehopwoodforex.com/phpBB3 ... =95&t=4389
Author:  Johann [ Fri Aug 04, 2017 6:51 am ]
Post subject:  Awesome

EDIT :
Thanks for the latest release Steve (v1a), for those who are using the TJF setfile M1 basket, I suggest you turn off the positive swap filter if you want to keep the same behavior otherwise you will have a slight decrease in trade taken compared to before.

hi all,

Somehow, the recovery for buys trade is still broken.
I have set it to 10 pips and the pair didn't close although I have 6 trades open with a total pips exceeding 10 pips. I am suspecting the following code but struggle to understand it correctly. Do someone have the same issues ?

Code: Select all

bool HaveWeHitRecoveryTarget(string symbol, int type, int index)
{
   //Calculate the Recovery target and close the trades if the target price is reached.
   
   int cc = 0;
   RecoveryTargetPrice = 0;
   
   if (type == OP_BUY)
   {
      //Add together the price of all the market trades
      for (cc = 0; cc < ArraySize(BuyTickets); cc++)
      {
         if (!BetterOrderSelect(BuyTickets[cc], SELECT_BY_TICKET, MODE_TRADES) )
            continue;//Just in case
         
         RecoveryTargetPrice+= OrderOpenPrice();
      }//for (cc = 0; cc < ArraySize(BuyTickets); cc++)
      
      //Divide this figure by the ticket array size to arrivc at the breakeven price
      RecoveryTargetPrice/= ArraySize(BuyTickets);
      RecoveryTargetPrice+= (RecoveryProfitPips[index] / factor);
      
      //Has the market reached this target?
      if (bid >= RecoveryTargetPrice)
         return(true);
   
   }//if (type == OP_BUY)
Author:  zaguy [ Fri Aug 04, 2017 8:07 am ]
Post subject:  Awesome

Hi All,

Firstly a great thank you to Steve and the other contributors to a great piece of coding art.

Just a thought in respect of the Recovery function where the market rapidly drops (or gains) 100 pips or more (such as the GBPUSD pair yesterday): why not also have an option to trade the stoporders in the same direction as the market drop or gain, i.e. place sell stoporders at specified Market Distance if the market drops and vice versa - of course if there is a quick recovery to previous higher or lower levels, then DD will once again be adversely affected.

It is just a thought - though I am sure Steve (and the other coders) already considered this - and it might just be a waste of time?
Author:  1Direction [ Fri Aug 04, 2017 8:17 am ]
Post subject:  Awesome

Johann » Fri Aug 04, 2017 7:51 am wrote:EDIT :
Thanks for the latest release Steve (v1a), for those who are using the TJF setfile M1 basket, I suggest you turn off the positive swap filter if you want to keep the same behavior otherwise you will have a slight decrease in trade taken compared to before.

hi all,

Somehow, the recovery for buys trade is still broken.
I have set it to 10 pips and the pair didn't close although I have 6 trades open with a total pips exceeding 10 pips. I am suspecting the following code but struggle to understand it correctly. Do someone have the same issues ?

Code: Select all

bool HaveWeHitRecoveryTarget(string symbol, int type, int index)
{
   //Calculate the Recovery target and close the trades if the target price is reached.
   
   int cc = 0;
   RecoveryTargetPrice = 0;
   
   if (type == OP_BUY)
   {
      //Add together the price of all the market trades
      for (cc = 0; cc < ArraySize(BuyTickets); cc++)
      {
         if (!BetterOrderSelect(BuyTickets[cc], SELECT_BY_TICKET, MODE_TRADES) )
            continue;//Just in case
         
         RecoveryTargetPrice+= OrderOpenPrice();
      }//for (cc = 0; cc < ArraySize(BuyTickets); cc++)
      
      //Divide this figure by the ticket array size to arrivc at the breakeven price
      RecoveryTargetPrice/= ArraySize(BuyTickets);
      RecoveryTargetPrice+= (RecoveryProfitPips[index] / factor);
      
      //Has the market reached this target?
      if (bid >= RecoveryTargetPrice)
         return(true);
   
   }//if (type == OP_BUY)
I just had a recovery buy trades closed in euraud containing 3 positions on version 1a seems to be working for me.

EDIT: Checking other open pairs in recovery with >10 pips but that did not close yet I noticed that I ended up with different lot size for the positions maybe the reason they are not closing. I'll now close them manually.
Author:  SteveHopwood [ Fri Aug 04, 2017 8:36 am ]
Post subject:  Awesome

Gary's FIFO version for you US guys is up and running http://www.stevehopwoodforex.com/phpBB3 ... 102&t=5237

:xm:
Author:  FxFoil [ Fri Aug 04, 2017 9:31 am ]
Post subject:  Awesome

Some clarification please.
The duplicate trades in picture have different M# and Comment. However I was not expecting SS pendings to occurr when 'Trade Short" = False. (Likewise BS pendings even though 'Trade Long' = False.) Is that right?

Thanks for checking
Author:  SteveHopwood [ Fri Aug 04, 2017 10:04 am ]
Post subject:  Awesome

FxFoil » Fri Aug 04, 2017 9:31 am wrote:Some clarification please.
The duplicate trades in picture have different M# and Comment. However I was not expecting SS pendings to occurr when 'Trade Short" = False. (Likewise BS pendings even though 'Trade Long' = False.) Is that right?

Thanks for checking
That is a timely bloop spot. The inputs are there but I forgot to code the appropriate filter. I am about to release 1b and have added a fix for this bloop.

:xm:
Author:  SteveHopwood [ Fri Aug 04, 2017 10:13 am ]
Post subject:  Awesome

V 1b is in post 1. This is a contribution by odrisb (Brenden), that allows us to group all the trades open on individual pairs into a basket, across all the time frames we are trading. The inputs are pretty obvious but details are in the updated user guide. You will find the inputs just above the rollover time inputs.

Brilliant contribution Brenden. :clap: :clap: :clap: :clap: :clap: :clap: :clap: :clap: :clap:

:xm:
Author:  SteveHopwood [ Fri Aug 04, 2017 10:41 am ]
Post subject:  Awesome

Sorry folks. You need to redownload 1b if you downloaded it before reading this. Paul has just emailed to point out that his Flying Buddha went missing. No idea how that happened. I have added it back in. Thanks Paul.

:xm:
All times are UTC Page 12 of 46