stevehopwoodforex.com
https://www.stevehopwoodforex.com/phpBB3/
Print view

Desky. TDesk's trading drone.
https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=5545		 Page 12 of 50
Author:  echoman01 [ Mon Nov 12, 2018 8:03 pm ]
Post subject:  Desky. TDesk's trading drone.
Dear Steve, I said a silent prayer to the gods of FX trading for this very feature added to Desky not long ago.

To paraphrase: I am as an amoeba compared to you coding geniuses.

Thankyou, :yahoo:
Author:  SteveHopwood [ Mon Nov 12, 2018 8:21 pm ]
Post subject:  Desky. TDesk's trading drone.
echoman01 » Mon Nov 12, 2018 8:03 pm wrote:Dear Steve, I said a silent prayer to the gods of FX trading for this very feature added to Desky not long ago.

To paraphrase: I am as an amoeba compared to you coding geniuses.

Thankyou, :yahoo:
Someone asked publically for it. It may have been you - don't know. It seemed like a good idea at the time and I never forgot it. It just took a while to get around to it.

:xm: :rocket:
Author:  BarraCoda [ Tue Nov 13, 2018 4:58 pm ]
Post subject:  Desky. TDesk's trading drone.
Hi Steve,

desky shows me the doubled amount of trades open. For example: i have 8 trades open, but desky shows 16.

I´ve decided to look in the code before beeing an idiot and get banned :shock:
I don´t know how to live on without SHF :smile:

I hope i found the feature that tells desky to take every trade in double:

This goes from line 992 in the newest release:

Code: Select all

      ArrayResize(GlobalTickets, GlobalTradesTotal + 1);
      GlobalTickets[GlobalTradesTotal] = OrderTicket();
      GlobalTradesTotal++;
      

      //We are only concerned with market trades here
      if (OrderType() < 2)
      {
         TotalCashUpl+= OrderProfit() + OrderSwap() + OrderCommission();
         pips = (int) CalculateTradeProfitInPips(OrderType());
         TotalPipsUpl+= pips;
         GlobalTradesTotal+= 1;
      }//if (OrderType() < 2)
I just don´t understand why we add twice to the GlobalTradesTotal variable. Once if we get a ticket which is owned by the EA, and twice when this ticket is a market trade. So we do have the same ticket twice in the GlobalTickets-array.

Am i right or am i just too stupid to understand your work?

btw TDesk and Desky are really a exciting new way to trade and plug'n'play EAs! Really nice! :clap:
Author:  SteveHopwood [ Tue Nov 13, 2018 5:06 pm ]
Post subject:  Desky. TDesk's trading drone.
BarraCoda » Tue Nov 13, 2018 4:58 pm wrote:Hi Steve,

desky shows me the doubled amount of trades open. For example: i have 8 trades open, but desky shows 16.

I´ve decided to look in the code before beeing an idiot and get banned :shock:
I don´t know how to live on without SHF :smile:

I hope i found the feature that tells desky to take every trade in double:

This goes from line 992 in the newest release:

Code: Select all

      ArrayResize(GlobalTickets, GlobalTradesTotal + 1);
      GlobalTickets[GlobalTradesTotal] = OrderTicket();
      GlobalTradesTotal++;
      

      //We are only concerned with market trades here
      if (OrderType() < 2)
      {
         TotalCashUpl+= OrderProfit() + OrderSwap() + OrderCommission();
         pips = (int) CalculateTradeProfitInPips(OrderType());
         TotalPipsUpl+= pips;
         GlobalTradesTotal+= 1;
      }//if (OrderType() < 2)
I just don´t understand why we add twice to the GlobalTradesTotal variable. Once if we get a ticket which is owned by the EA, and twice when this ticket is a market trade. So we do have the same ticket twice in the GlobalTickets-array.

Am i right or am i just too stupid to understand your work?

btw TDesk and Desky are really a exciting new way to trade and plug'n'play EAs! Really nice! :clap:
Thanks for this. :clap: :clap: :clap: GlobalTradesTotal+= 1; was probably meant to be something different and I did not notice that I selected the wrong auto-complete.

I will upload a fix later.

:xm: :rocket:
Author:  4xtn [ Tue Nov 13, 2018 6:06 pm ]
Post subject:  Desky. TDesk's trading drone.
Has anyone tried hedging? It appears there is a bug somewhere as trades are closed within seconds :/
Author:  SteveHopwood [ Tue Nov 13, 2018 6:46 pm ]
Post subject:  Desky. TDesk's trading drone.
V 2c is in post 1, with the fix for the bloop that BarraCoda spotted.

DIYers, do a search for, "GlobalTradesTotal+= 1;" and delete that line of code.

Turn off hedging for now. It will have to wait until I have a trade that needs it and have the time to sort it out - unlikely this week.

:xm: :rocket:
Author:  pacinvest [ Thu Nov 15, 2018 6:28 pm ]
Post subject:  Desky. TDesk's trading drone.
Hopefully this is helpful Steve.

Desky v2b: in trade management section. I am finding Break even set by itself works, jumping stop set causes EA to stop working, trailing stop is trying to set stops but returns error message 'invalid stops'. This was observed across two platforms one on my laptop and one on VPS and seems to be consistent, i.e. not isolated error.

cheers
vince
Author:  SteveHopwood [ Thu Nov 15, 2018 6:34 pm ]
Post subject:  Desky. TDesk's trading drone.
pacinvest » Thu Nov 15, 2018 6:28 pm wrote:Hopefully this is helpful Steve.

Desky v2b: in trade management section. I am finding Break even set by itself works, jumping stop set causes EA to stop working, trailing stop is trying to set stops but returns error message 'invalid stops'. This was observed across two platforms one on my laptop and one on VPS and seems to be consistent, i.e. not isolated error.

cheers
vince
Thanks Vince. I will look into it.

:xm: :rocket:
Author:  SteveHopwood [ Sun Nov 18, 2018 3:40 pm ]
Post subject:  Desky. TDesk's trading drone.
pacinvest » Thu Nov 15, 2018 6:28 pm wrote:Hopefully this is helpful Steve.

Desky v2b: in trade management section. I am finding Break even set by itself works, jumping stop set causes EA to stop working, trailing stop is trying to set stops but returns error message 'invalid stops'. This was observed across two platforms one on my laptop and one on VPS and seems to be consistent, i.e. not isolated error.

cheers
vince
2d is in post 1, with what I think are fixes.

Or: go to OnInit() and add these two lines of variables initialisations:
JumpingStopPips = JumpingStopTargetPips;
TrailingStopPips = TrailingStopTargetPips;

I have also added a few more calls to the function that populates variables such as ask, bid, factor etc. Do a search for: "//Security check" and add this just underneath the code snippet that makes sure the trade is still open:
GetBasics(OrderSymbol() );

There are 4 instances of "//Security check"

Leave hedging turned off for now folks. I doubt I will be able to sort it out this week.

:xm: :rocket:
Author:  Vokin [ Tue Nov 20, 2018 8:31 am ]
Post subject:  Desky. TDesk's trading drone.
Hi Steve,
there is mismatch in basket sum in EA and account. See pict.
Maybe that's why EA closed the basket on a different TP than it was set up (It has happened to me twice).
All times are UTC Page 12 of 50

Powered by phpBB® Forum Software © phpBB Limited