stevehopwoodforex.com
https://www.stevehopwoodforex.com/phpBB3/
Print view

Fratelli EA by Dragos and magft
https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=77		 Page 12 of 23
Author:  magft [ Tue Nov 29, 2011 12:16 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
dynel14 wrote:hi magft,

EA opened a buy just right now on EJ. But Arrow is down!?
Interesting! What time did you drop EA on chart? As the Arrow signal shows down and all others are up a trade shouldn't have opened! I had a buystop open that was deleted when PA went below 89EMA so that bit is working :roll:

Keep an eye on other trades and let me know if it does it again, dropping EA on chart during trading times can cause adverse effects if all parameters are not initialised correctly :oops:

Mike
Author:  magft [ Tue Nov 29, 2011 12:21 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
DragosDanescu wrote:
magft wrote:Yes the code is getting too complex, i have tried to streamline a bit but still difficult to edit unless familiar with Steve's code :lol:

Ok question for you guys, should the LastOrderTime, the check i use to make sure the Arrow has appeared after this, should it be the time the trade opens or the time the trade closes?

I am just modifying the code as i recompiled with the new time code and it opened a new trade as the LastOrderTime was 0! So now i have a function that checks for last trade and if the time (open/close) is greater than arrow time it updates LastOrderTime. I've added the function as a filter to stop trading if no arrow has appeared since open/close of last trade.

From Fratelli thread i think it should be close of trade but i'm not sure.
I think close it also ok, as it's more safe compared to open(I mean the difference between close and arrow time is certain). Hmm...as a second thought, what if the order close happens after a new arrow? No, I would still use open. Even if you set arrow time one minute back, just to be sure it's different than order open time.
Open is probably safer.

Ok now if the last trade found was a buystop/sellstop as PA didn't trigger a trade this should be skipped until a buy/sell is found, what do you think?
Author:  DragosDanescu [ Tue Nov 29, 2011 12:24 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
magft wrote:
DragosDanescu wrote:
magft wrote:Yes the code is getting too complex, i have tried to streamline a bit but still difficult to edit unless familiar with Steve's code :lol:

Ok question for you guys, should the LastOrderTime, the check i use to make sure the Arrow has appeared after this, should it be the time the trade opens or the time the trade closes?

I am just modifying the code as i recompiled with the new time code and it opened a new trade as the LastOrderTime was 0! So now i have a function that checks for last trade and if the time (open/close) is greater than arrow time it updates LastOrderTime. I've added the function as a filter to stop trading if no arrow has appeared since open/close of last trade.

From Fratelli thread i think it should be close of trade but i'm not sure.
I think close it also ok, as it's more safe compared to open(I mean the difference between close and arrow time is certain). Hmm...as a second thought, what if the order close happens after a new arrow? No, I would still use open. Even if you set arrow time one minute back, just to be sure it's different than order open time.
Open is probably safer.

Ok now if the last trade found was a buystop/sellstop as PA didn't trigger a trade this should be skipped until a buy/sell is found, what do you think?
Yes, sure, we count only market orders. Btw, that piece of code I mentioned before takes care of the old ticks?
Author:  dynel14 [ Tue Nov 29, 2011 12:30 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
magft wrote:
dynel14 wrote:hi magft,

EA opened a buy just right now on EJ. But Arrow is down!?
Interesting! What time did you drop EA on chart? As the Arrow signal shows down and all others are up a trade shouldn't have opened! I had a buystop open that was deleted when PA went below 89EMA so that bit is working :roll:

Keep an eye on other trades and let me know if it does it again, dropping EA on chart during trading times can cause adverse effects if all parameters are not initialised correctly :oops:

Mike
Yes after your last update. Also happened with the other pairs :(
Author:  Panamamike [ Tue Nov 29, 2011 5:19 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
I have the first version of 2 running well. The latest version is not doing well at all. In order to compare, can someone add the code for %risk position sizing to the first version 2? As with many other programs, the more things are added the less well they seem to do.
Author:  Panamamike [ Tue Nov 29, 2011 5:54 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
For some reason the choose file button does not activate when I try to upload he file.
Author:  Trin83ity [ Tue Nov 29, 2011 9:01 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
Guys, firstly great work! I have been testing on demo for last week. It seems that EA would open the position in the wrong direction. When it should open short it would open long and vice versa. Is it only my experience? Can you change the order to the opposite?
Author:  blahn [ Wed Nov 30, 2011 2:51 am ]
Post subject:  Re: Fratelli EA by Dragos and magft
Now that they've added lines to the indi where the po should be placed it's easy to see if the ea is putting them in the right spots. the first au po was in the right spot, but most weren't even close.
au.gif
eu.gif
ej.gif
Author:  magft [ Wed Nov 30, 2011 9:03 am ]
Post subject:  Re: Fratelli EA by Dragos and magft
Khalaad wrote:
Khalaad wrote:
Trin83ity wrote:Guys, firstly great work! I have been testing on demo for last week. It seems that EA would open the position in the wrong direction. When it should open short it would open long and vice versa. Is it only my experience? Can you change the order to the opposite?
Won't help, Trin83ity.

However, this will:
This is not a set-and-forget ea; there is no such thing and anyone who tries to claim there is, is either stupid or lying. This ea requires frequent manual intervention.
The above is why I respect Steve Hopwood. He posts the warning before he posts an EA.

Mike did the same in Post 1.

Khalid
It takes a great deal of time, and an enormous amount of hard work, from the idea to a consistently profitable trading system.

Please allow Mike and Dragos the time to make this work.

Khalid
Khalid, thanks for the input and i am working on the next version to addresses the current issues.

Blahn, i am testing today with the new indicators to see how the EA compares. George has provided some input to help with logic bloops and ways to improve accuracy of entries.

I probably wont be able to release anything til tonight as i have a busy day today, any thoughts or observations please post and i'll address them when i can.

Mike
Author:  DragosDanescu [ Wed Nov 30, 2011 10:30 am ]
Post subject:  Re: Fratelli EA by Dragos and magft
Have already made some corrections(I hope) and I'm running it in ST atm, will post as soon as it works ok.
Cheers
All times are UTC Page 12 of 23

Powered by phpBB® Forum Software © phpBB Limited