stevehopwoodforex.com
https://www.stevehopwoodforex.com/phpBB3/
Print view

Fratelli EA by Dragos and magft
https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=77		 Page 13 of 23
Author:  MickyMouse [ Wed Nov 30, 2011 12:22 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
hi guys... and girls :oops:


if (MACD1 > (0+2*Point) || MACD0 >= (0+2*Point)) MACD = up;
if (MACD1 < (0-2*Point) || MACD0 <= (0-2*Point)) MACD = down;

please modify the ea . dont use any more buffer for macd . up is up and down is down :D
as in above 0 is up, bellow 0 is down D:
Author:  magft [ Wed Nov 30, 2011 12:28 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
MickyMouse wrote:hi guys...


if (MACD1 > (0+2*Point) || MACD0 >= (0+2*Point)) MACD = up;
if (MACD1 < (0-2*Point) || MACD0 <= (0-2*Point)) MACD = down;

please modify the ea . dont use any more buffer for macd . up is up and down is down :D
as in above 0 is up, bellow 0 is down D:
Thanks for the update, currently fixing a few issues.

There is an obvious copy and paste error in LookingForTradingOportunities()

Code: Select all

//Short
   //if ((((Open[1] > MAVal && Close[1] <= MAVal) || (Close[2] > MAVal && Open[1] <= MAVal && Close[1] < MAVal)) && trend == down) 
   //|| (Close[1] <= MAVal && direction == down) && ArrowBar>LastOrderTime)// && Open[1] > MAVal)
   if(Close[1] < MAVal && MACD == down && Signal == down && direction == down && (ArrowBar>LastOrderTime||SARSignal==down))
   //if(Close[1] < MAVal && MACD == down && Signal == down && direction == down && SARSignal==down)
   {
      if (!TradeShort) return;
      //if (Close[1]>Open[1]) return;
            
      type = OP_SELLSTOP;
      //Check if use HighLow or just Close
      if (UseHigh_Low) price = NormalizeDouble(High[2] - (SellBufferPips*Point),Digits);
      else price = NormalizeDouble(Close[2] - (SellBufferPips*Point),Digits);
Should have the High[2] replace with Low[2]

Code: Select all

//Short
   //if ((((Open[1] > MAVal && Close[1] <= MAVal) || (Close[2] > MAVal && Open[1] <= MAVal && Close[1] < MAVal)) && trend == down) 
   //|| (Close[1] <= MAVal && direction == down) && ArrowBar>LastOrderTime)// && Open[1] > MAVal)
   if(Close[1] < MAVal && MACD == down && Signal == down && direction == down && (ArrowBar>LastOrderTime||SARSignal==down))
   //if(Close[1] < MAVal && MACD == down && Signal == down && direction == down && SARSignal==down)
   {
      if (!TradeShort) return;
      //if (Close[1]>Open[1]) return;
            
      type = OP_SELLSTOP;
      //Check if use HighLow or just Close
      if (UseHigh_Low) price = NormalizeDouble(Low[2] - (SellBufferPips*Point),Digits);
      else price = NormalizeDouble(Close[2] - (SellBufferPips*Point),Digits);
I have done a few other fixes for the next version but that is quite an important one!! The EA is steadily making profit everyday so cant complain :mrgreen:

Mike
Author:  MickyMouse [ Wed Nov 30, 2011 12:37 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
you guys are doing a great job keeping it updated and not discontinued..
congrats on that ...
Author:  DING [ Wed Nov 30, 2011 2:42 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
my testing upgrade to Fratelli V2.6 yesterday, But so quiet today , not open any order till now,
what wrong for me? :?:
Author:  magft [ Wed Nov 30, 2011 8:46 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
DING wrote:my testing upgrade to Fratelli V2.6 yesterday, But so quiet today , not open any order till now,
what wrong for me? :?:
Not sure, i have had loads of trades today including catching the ride up on the EU. Do you have the smiley face in the corner?
Author:  magft [ Wed Nov 30, 2011 9:06 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
Update in post #1
Author:  Xfinity [ Wed Nov 30, 2011 10:07 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
Cheers, will test it asap. Is there any other file besides the ones in the first post I need? I am going to set-up a new computer to test more bots. Thanks!
Author:  magft [ Wed Nov 30, 2011 10:21 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
Xfinity wrote:Cheers, will test it asap. Is there any other file besides the ones in the first post I need? I am going to set-up a new computer to test more bots. Thanks!
Nope, unless you want to visually test the EA as well then you need all the indicators from the Fratelli thread.
Author:  Xfinity [ Wed Nov 30, 2011 10:38 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
Thanks for the quick reply, it looks a little nicer now - I was in the process to add all indis I had on my main computer.
Author:  blahn [ Wed Nov 30, 2011 11:03 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
Here's the last 5 or 6 hours of 2.7s POs compared to the main indi. about 50 percent of the Pos match the main indi.
au27.gif
eu27.gif
ej27.gif
All times are UTC Page 13 of 23

Powered by phpBB® Forum Software © phpBB Limited