ChangeTheColor EA

Post Reply
ROBST3R
Trader
Posts: 86
Joined: Fri Dec 16, 2011 7:33 pm

Re: ChangeTheColor EA

Post by ROBST3R »

this trade never closed on color change
You do not have the required permissions to view the files attached to this post.
User avatar
spyderman
Trader
Posts: 338
Joined: Sun Dec 11, 2011 1:39 pm

Re: ChangeTheColor EA

Post by spyderman »

ROBST3R wrote:this trade never closed on color change

Yeah, I've had a couple like that too.

Mike...Is there any problem with having both of these selected as true?
You do not have the required permissions to view the files attached to this post.
Snaggin' some pips
magft
Trader
Posts: 195
Joined: Tue Nov 15, 2011 9:59 pm
Location: East Midlands, UK

Re: ChangeTheColor EA

Post by magft »

spyderman wrote:
ROBST3R wrote:this trade never closed on color change

Yeah, I've had a couple like that too.

Mike...Is there any problem with having both of these selected as true?
Nope they work separately and that is how i have them set. I am just wondering if the left over trade is due to a trade that should have closed but got left open, what do you think?

I'll do some testing over the weekend to check what is going on. It might be due to multiple EAs running. What is the cpu overhead with lots of charts open? I am thinking of trying to code the synergy bars internally to reduce the overheads.

I'll keep you posted.

Mike
User avatar
spyderman
Trader
Posts: 338
Joined: Sun Dec 11, 2011 1:39 pm

Re: ChangeTheColor EA

Post by spyderman »

magft wrote: Nope they work separately and that is how i have them set. I am just wondering if the left over trade is due to a trade that should have closed but got left open, what do you think?
I'm not thinking so in my case. It was on a Chf/Jpy trade and I've only had one on that pair this week.

It looks like I should have a few more trades open at the close of my H4 bar here in about 10 minutes. I'll keep everyone posted and we'll see how that goes. :)
Snaggin' some pips
User avatar
spyderman
Trader
Posts: 338
Joined: Sun Dec 11, 2011 1:39 pm

Re: ChangeTheColor EA

Post by spyderman »

Okay...I've got 5 trades that opened up
Gbp/Usd
Aud/Usd
Aud/Jpy
Gbp/Jpy
Eur/Chf

Only glitch is comment isn't working. I have "auto trade comment" set to false and "CTC EA" in "TradeComment". All trades are showing "fxTrade Practice #blah,blah,blah"

I don't know where it's getting that comment. I couldn't find it in the code. It must be something on the broker side. :x
Snaggin' some pips
User avatar
spyderman
Trader
Posts: 338
Joined: Sun Dec 11, 2011 1:39 pm

Re: ChangeTheColor EA

Post by spyderman »

spyderman wrote:
Only glitch is comment isn't working. I have "auto trade comment" set to false and "CTC EA" in "TradeComment". All trades are showing "fxTrade Practice #blah,blah,blah"

I don't know where it's getting that comment. I couldn't find it in the code. It must be something on the criminal side. :x

Yeah I researched Oanda and they use the comment field themselves...what a bunch of morons. What's the point of having it if they just put some stupid ticket numbers in there. This was there answer on FAQ's...

"OANDA Empty4 writes the ticket id on the comment field. If your EA or third party site uses this field, please contact them about an alternative method you can use." :evil: :evil: :evil:
Snaggin' some pips
User avatar
gaheitman
Trader
Posts: 655
Joined: Tue Nov 15, 2011 10:55 pm
Location: Richmond, VA, US

Re: ChangeTheColor EA

Post by gaheitman »

magft wrote:
spyderman wrote:
ROBST3R wrote:this trade never closed on color change

Yeah, I've had a couple like that too.

Mike...Is there any problem with having both of these selected as true?
Nope they work separately and that is how i have them set. I am just wondering if the left over trade is due to a trade that should have closed but got left open, what do you think?

I'll do some testing over the weekend to check what is going on. It might be due to multiple EAs running. What is the cpu overhead with lots of charts open? I am thinking of trying to code the synergy bars internally to reduce the overheads.

I'll keep you posted.

Mike
Mike,

Much of my non-trading time earlier today was spent adding an indicator into an EA. I mostly did it in hopes of being able to backtest at a reasonable speed. I started with this: http://articles.mql4.com/501 which was a great start. It was a fairly straightforward conversion, but if you hit any walls give me a shout. I converted an indicator that uses 7 buffers with both a current timeframe version and a higher time frame.

George
magft
Trader
Posts: 195
Joined: Tue Nov 15, 2011 9:59 pm
Location: East Midlands, UK

Re: ChangeTheColor EA

Post by magft »

spyderman wrote:Okay...I've got 5 trades that opened up
Gbp/Usd
Aud/Usd
Aud/Jpy
Gbp/Jpy
Eur/Chf

Only glitch is comment isn't working. I have "auto trade comment" set to false and "CTC EA" in "TradeComment". All trades are showing "fxTrade Practice #blah,blah,blah"

I don't know where it's getting that comment. I couldn't find it in the code. It must be something on the criminal side. :x
You only need comments if running on same timeframe and want the daily profits bit to work correct, that is the only place i use comments. So for your runs it is fine to let Oanda set their own comments.

I am still not sure on why you got an extra trade, i guess we need to keep an eye out for more and see if between all of us we can figure out why this is occurring.
magft
Trader
Posts: 195
Joined: Tue Nov 15, 2011 9:59 pm
Location: East Midlands, UK

Re: ChangeTheColor EA

Post by magft »

George, excellent stuff. I have had a go at this before and kind of got it work without any of the extras in this and the follow-up article. I will give this a try over the weekend for synergy bars and see how we get on. I like the idea of creating include files to keep separate from the main EA code to make it reuseable.

I'll drop you a copy once i have finished.

Regards

Mike
gaheitman wrote: Mike,

Much of my non-trading time earlier today was spent adding an indicator into an EA. I mostly did it in hopes of being able to backtest at a reasonable speed. I started with this: http://articles.mql4.com/501 which was a great start. It was a fairly straightforward conversion, but if you hit any walls give me a shout. I converted an indicator that uses 7 buffers with both a current timeframe version and a higher time frame.

George
User avatar
gaheitman
Trader
Posts: 655
Joined: Tue Nov 15, 2011 10:55 pm
Location: Richmond, VA, US

Re: ChangeTheColor EA

Post by gaheitman »

magft wrote:George, excellent stuff. I have had a go at this before and kind of got it work without any of the extras in this and the follow-up article. I will give this a try over the weekend for synergy bars and see how we get on. I like the idea of creating include files to keep separate from the main EA code to make it reuseable.

I'll drop you a copy once i have finished.

Regards

Mike
I hadn't realized there was a second article. :oops: Thanks for pointing that out! :D

I'm off to do a little reading and a little more coding.

George
Post Reply

Return to “Automated trading systems”