phil_trade wrote:Hi Steve

may I suggest adding the following controls codes in INIT() to automaticaly adjust LOT and PartCloseEnabled parameters to fit criminal and instrument requirement :

Philippe

   if (OnlyTradeCurrencyTwice && OpenTrades == 0)
   {
      IsThisPairTradable();      
   }//if (OnlyTradeCurrencyTwice)
   if (!CanTradeThisPair) return(false);

CanTradeThisPair = true;
   if (OnlyTradeCurrencyTwice && OpenTrades == 0)
   {
      IsThisPairTradable();      
   }//if (OnlyTradeCurrencyTwice)
   if (!CanTradeThisPair) return(false);

spotdespot wrote:Hi Steve,

I haven't had the EA trading on my account at all and although I am very capable of doing stupid things (I have many badges) I didn't think I had done anything in this case!

I checked the code (I am not familiar with MQL but code is code) and it seems I may have found the issue why some people are getting trades and some not. If you set OnlyTradeCurrencyTwice to TRUE then, as you know, in the IsTradingAllowed function it calls the IsThisPairTradable function if the conditional is met. In the IsThisPairTradable function it initializes the boolean CanTradeThisPair and checks whether to trade that pair, returning a boolean (from the IsThisPairTradable function). CanTradeThisPair is then checked:

Code: Select all

if (!CanTradeThisPair) return(false);

The issue arises (I think ) if you have OnlyTradeCurrencyTwice set to false as then IsThisPairTradable() is never called and CanTradeThisPair is never initialized. Now I have no idea how MQL deals with uninitialized variables but I have known the outcome to be pretty random using other languages - which might explain why some people are getting trades and others not (it could also just be those that have OnlyTradeCurrencyTwice = False that have the issue).

I set CanTradeThisPair to true when declared and now I am getting trades.

Hopefully this makes sense - I haven't posted this for others that have the issue just in case I am completely FOS!!

Cheers,
Dave.

[spotdespot]
Hi verb - your points are valid if this is for buying in a dip/selling rallies BUT if that was the intention then I think you should only be buying in a dip and selling rallies if D1 TMA slope is >=0.8/<=-0.8?

Bob's booklets clearly state (as I originally quoted) that BOTH H4 Weekly Open Histogram 2x1 and 1x0 should be in agreement for buying/selling with the trend as S/R or MA's are crossed - so perhaps this should be reflected in the H4 Trend Trade "Basic Trade"?

It's your document obviously but I thought it was going to reflect a codified version of Bob's rules and, although I think it is very useful, I don't think that is the case at the moment. Perhaps Bob will have a chance to read your document and tell me I am wrong

Anyway - please don't take any offense - there is certainly none intended.

• 1) The poster has not read post 1 properly.
  2) The poster is not reading my posts.

TallCoolOne wrote:Hi Steve,

Great work on this EA and thanks Verb your codex. Great contributions for this system. I work full time and I'm in the U.S. so it is hard for me to manually trade this system, so I really appreciate you creating this auto-trader.

The only thing I would ask for is an automated feature to close trades that are losers based on last swing hi/lo. I see many of the guys over in the FF thread are using that as a way of closing losers and are still doing very well. I have been using the auto-trader and closing trades manually, but would like to see how the EA performs with an automated close feature. Thanks for your consideration. Thanks for all your hard work

This EA may become my only auto-trader if it keeps performing as it has been.