stevehopwoodforex.com
https://www.stevehopwoodforex.com/phpBB3/
Print view

Pipcruiser's Pipmasher on Steroids
https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=4098		 Page 15 of 26
Author:  Louisetano [ Sat May 09, 2015 6:25 pm ]
Post subject:  Pipcruiser's Pipmasher on Steroids
AnotherBrian » Sat May 09, 2015 6:12 pm wrote:
I reduced the multi trades to 2. This decision was based on watching price action on a few of the trades. I don't want to push it to hard as the stops can give back too much. Plus it's on a live account.
I've just reduced to 3 on the demo without ATR, but it might be even better to reduce to 2 like you. ;) , but I´ll try with 3 this month and see how it goes :)
The ATR version, using the different sets, only had 1 multi to go to SL in April. So I'll keep that going as is :D
Author:  eltax100 [ Thu May 14, 2015 10:38 am ]
Post subject:  Pipcruiser's Pipmasher on Steroids
This is still holding up
over 8000 pips in the last 2.5 months , just changed the sl on the multi trades to 100 as 300 was leaving it a bit too exposed to drawdown. Winning an average of 87% of trades
:good:

Bloody simple it shouldn't work ............


http://www.myfxbook.com/members/eltax10 ... ds/1149990
Author:  rosst [ Thu May 14, 2015 2:32 pm ]
Post subject:  Pipcruiser's Pipmasher on Steroids
eltax100 » Thu May 14, 2015 4:38 am wrote:This is still holding up
over 8000 pips in the last 2.5 months , just changed the sl on the multi trades to 100 as 300 was leaving it a bit too exposed to drawdown. Winning an average of 87% of trades
:good:

Bloody simple it shouldn't work ............


http://www.myfxbook.com/members/eltax10 ... ds/1149990
WOW! you are doing great! Are you trading all the pairs? Would you mind posting your latest set file?
Thanks for sharing!
Author:  almartins [ Thu May 14, 2015 3:01 pm ]
Post subject:  Pipcruiser's Pipmasher on Steroids
Hi Steve and friends,

Last PPoS version ( I've made download just a few minutes) have a problem with brokers with a Sunday candle bar. I found that because checking conditions to open positions Tuesday and Wednesday PPoS fail to open in two charts and that because it was looking not last D1 candle closed but penultimate D1 candle. I've look at the code and find that "shift" variable (I put it blue below) it's value was "2" and must be "1" (last closed candle).

4126___//D1 candle by default
______ static datetime OldTradingBarTime = 0;
______ if (OldTradingBarTime != iTime(Symbol(), TradingTF, 0) )
______ {
______ OldTradingBarTime = iTime(Symbol(), TradingTF, 0);
______ AlreadyTradedToday = false;//New trading period
______ copen = iOpen(Symbol(), TradingTF, shift);
______ cclose = iClose(Symbol(), TradingTF, shift);
______ if (cclose > copen)
________ TradingDirection = up;
_________ else
__________ if (cclose < copen)
__________ TradingDirection = down;
______________ else
__________ if (CloseEnough(copen, cclose))
__________ TradingDirection = flat;
4142____ }//if (OldTradingBarTime != iTime(Symbol(), TradingTF, 0) )

I think the problem is caused here:

4021__//Calculate the directions of the previous relevant candles
______ double copen = 0, cclose = 0;
______ int shift = 1;
______ if (BrokerHasSundayCandle)
_________ if (TradingTF == PERIOD_D1)
4026______ shift = 2;

In my broker with a Sunday candle all days PPoS is locking two candles behind and not last one closed.
Please check.

Cheers
almartins
Author:  ffxbettor [ Thu May 14, 2015 3:31 pm ]
Post subject:  Pipcruiser's Pipmasher on Steroids
almartins » Thu May 14, 2015 5:01 pm wrote:
4021__//Calculate the directions of the previous relevant candles
______ double copen = 0, cclose = 0;
______ int shift = 1;
______ if (BrokerHasSundayCandle)
_________ if (TradingTF == PERIOD_D1)
4026______ shift = 2;

In my broker with a Sunday candle all days PPoS is locking two candles behind and not last one closed.
Please check.

Cheers
almartins

Replace this code :

Code: Select all

   int shift = 1;
   if (BrokerHasSundayCandle)
      if (TradingTF == PERIOD_D1)
        shift = 2;
with the following :

Code: Select all

   int shift = 1;
   if (BrokerHasSundayCandle)
      if (TradingTF == PERIOD_D1 && TimeDayOfWeek(TimeCurrent()) == 1)
         // we are Monday : set the shift = 2 to skip the Sunday candle
         shift = 2;
N.B. : the bug is also in the Zennor's Piproid EA.


Cheers,
Didier.
Author:  SteveHopwood [ Thu May 14, 2015 4:20 pm ]
Post subject:  Pipcruiser's Pipmasher on Steroids
That is one heck of a bloop you guys spotted. Thanks. :clap: I intended the extra check - just forgot to add it. :arrrg:

V 1i in post 1.

:xm:
Author:  almartins [ Thu May 14, 2015 4:37 pm ]
Post subject:  Pipcruiser's Pipmasher on Steroids
:good:
I'm glad to help. I'm going to make "PPoS" work flawlessly. Thank you Steve and Didier.
:clap:
Author:  SWG123 [ Thu May 14, 2015 9:31 pm ]
Post subject:  Pipcruiser's Pipmasher on Steroids
Also noticed typo in line 1791:-

if (PendingOrder)
{
stype = " Suy stop ";
price = NormalizeDouble(Ask + (PendingBuffer / factor ), Digits );
Author:  AnotherBrian [ Thu May 14, 2015 9:46 pm ]
Post subject:  Pipcruiser's Pipmasher on Steroids
I'm happy more people are reading code now and adding to the quality control process. After all, we're putting real money at risk here.
Author:  SteveHopwood [ Thu May 14, 2015 9:58 pm ]
Post subject:  Pipcruiser's Pipmasher on Steroids
SWG123 » Thu May 14, 2015 9:31 pm wrote:Also noticed typo in line 1791:-

if (PendingOrder)
{
stype = " Suy stop ";
price = NormalizeDouble(Ask + (PendingBuffer / factor ), Digits );
'tis an insignificant typo in the code that sends an email alert instead of a trade. I will correct it but it does not matter.

I will echo what Brian just wrote though. It is really helpful when you guys spot stuff like this. For the coder, spotting these thingies is like spotting a spelling mistake in an essay we wrote in school. Remember how hard that was when you did not know there was a mistake? Same mental process, I imagine. We see what is supposed to be there, rather than what is actually there.

:xm:
All times are UTC Page 15 of 26

Powered by phpBB® Forum Software © phpBB Limited