• Allow you to disable full hedging.
• Use the total of open lots to decide whether the position is 'unbalanced' instead of the number of open trades. It became clear with use that this is a better method - actually Thomas' idea originally but I did not understand what he was getting at until I had used the bot for a while.
• Close a profitable full hedge trade when there is a yellow range wave line. This is something else whose value became clear with use.

• The next six inputs are concerned with adding and monitoring a full hedge trade:
  • UseFullHedging: turns this feature on/off.
  • BuysAndSellsUnbalancedAtLots: this is the point at which a position is considered to be 'unbalanced'. For example: the default is 0.1; there are 0.03 buy lots open and 0.18 sell lots open; the difference between the two groups is >0.1, and so is 'unbalanced'. HGBnD will send full hedge buy trade of 0.15 lots following an HGI buy signal.
  • OnlyCloseFullHedgeWhenInProfit: this tells HGBnD only to close a full hedge trade if it is in profit.
  • OffsetOppositeLosersAgainstProfit: if enabled and HGBnD has just closed a profitable full hedge trade, she will use the profit to close as many of the losers as possible, on the other side of the hedge.
  • FullHedgeComment: the order comment that labels the trade as a full hedge trade. HGBnG uses this to identify a full hedge, so you must not change this input once you have a full hedge in place.
  • CloseProfitableFullHedgeOnYellowWave: tells HGBnD to close profitable full hedge trades when there is a yellow range wave signal. She will also offset opposite direction trades is OffsetOppositeLosersAgainstProfit is set to 'true'.

tomele wrote:Hello Steve

I found a little time for bug hunting today and was able to solve 3 problems. All line numbers refer to HGBnD.

1. Invalid stop errors. They happened only in times of very high spreads and only for buy stops. I have seen situations where the spread was 3 times the grid distance. This lead to situations where the bots tried to send buy stops below the current ask price. I have added code at line 1204 in SendSingleTrade() to reject such requests.

2. Strategies without hedging caused problems with CloseAllPossible...(). As an example, if there were no buy orders and the signal changed to sell, CloseAllPossibleBuys() and from there CloseAllTrades() were called repeatedly without ever coming to an end. The quick fix was adding conditions in lines 5312 and 5320.

3. While debugging the above, I noticed that FifoTicket[] always was one element to large with the last ticket number being 0. The OpenTrades++ statement in CountOpenTrades() was not at the position it normally is for your coding style. I moved it from above the FifoTicket block to line 3389.

The modifications seem to work fine. Attached are HGBnD and HGBnDnS j versions.

Cheers

SteveHopwood » Thu Jan 05, 2017 2:27 am wrote:V 2k is in post 1. Thomas has been bug squishing again.

Here is the pm he sent with explanations:

Dead obvious when they are spotted and fixed, but a bugger to find in the first place. Thanks again Thomas

SteveHopwood wrote:Hi Thomas

I have seen this happen three times today:

• GJ is in a downtrend on HTF HGI (H4).
• There was a sell signal on the LTF (M5), and the bot sent the full pending grid. From there:
  • the market rose and filled a pending buy.
  • the market continued to rise, the trade moved into profit and the bot closed it because I have CloseOnOppositeSignalOrTrendChange enabled.

The closure happens in the block starting at 5308. This would have happened before you added to the code, because your addition is intended to avoid the bot trying to close a trade that does not exist.

This happens whether the market initially fell to fill a pending sell or not, and explains the rapid opening and closing of trades at a tiny profit..

<Yes. Just watched it happen twice, so I was left with three unprotected sells. I assume this will continue to happen for as long as the market continues, so I have disabled CloseOnOppositeSignalOrTrendChange.>

I am thinking that we need to stipulate that trades only close if they are not part of a hedged position. What do you think?


Cheers