renexxxx » Thu Oct 23, 2014 6:48 am wrote:Here is an indicator that reports on the open or historical trades. There are already a few of these around, but I felt like creating another one. The columns are sortable, with a single mouse-click. Inputs:

• MagicNumber: Default -1, meaning include all trades
• StartDate: Take a guess
• EndDate: Take another guess
• RefreshMinutes: How many minutes to the next refresh
• ReportType: OPEN/CLOSED/BOTH: List either OPEN, CLOSED or BOTH open and closed orders. In case of OPEN, the StartDate and EndDate are ignored.

Code attached. Have fun!

UPDATE: I added the option to list both OPEN and CLOSED trades. These are then lumped together and the totals are aggregated.

UPDATE: You can now also filter trades by order comment. There is a new parameter called, CommentFilter (defaults to "") that can be used to only include trades that contain part of the CommentFilter text in their OrderComment(). Note: the string comparison is case sensitive, so if you want trades with comment "CT" and the CommentFilter is "ct", you won't get what you want.

UPDATE: Minor cosmetic update, as suggested by wolfeman: The grand total PIP and Dollar count figure is now better readable.

UPDATE: Added the option to total the trade results by magic number, order comment, as well as by symbol name. For that there is a new parameter, groupBy, that can be SYMBOL (default), MAGIC or COMMENT

UPDATE: Added some color schemes: Beige (Default), Solarized and Turquoise, Magenta and BlackNWhite, as some people didn't like the beige scheme. No change in the functionality.

UPDATE: Under some circumstances (by clicking on something else than a column title), it was possible to get the following error:. In that case, the indicator would 'hang' and would not delete the screen objects when unloaded. This bug has now been fixed.

UPDATE: Added the option to select "Today", "This Week" and "This Month" as special start and end date options. You can still specify your own start and end dates, by selecting "Custom Dates" for the DateChoice. This was a requirement as http://www.stevehopwoodforex.com/phpBB3 ... 7277posted by Bruster400.

UPDATE: There was a bug that prevented you from selecting other screen objects (such as horizontal lines) when TradeReport was running as the OnChartEvent() in trade report would capture the mouse-click to these other objects. This has now been fixed.

UPDATE: Thomas (tomele) has kindly made some cosmetic changes to the format of the report, particularly:
- Added x/yOffset as input
- Changed vertical text alignments
- Changed horizontal text alignment for last row
- Changed colors for last 2 rows
- Some alignments for legend
Thank you Thomas!

UPDATE: It is now possible to filter the result set of trades by either (1) a list of currency pairs or (2) a list of currencies

There is no need to include the symbol extension on your list of symbols, even if your broker uses them. Eg. Don't specify AUDCADc, AUDJPYc, NZDJPYc, but just AUDCAD, AUDJPY, NZDJPY.

UPDATE 2017.09.08: The report can now optionally display some extended statistics as suggested by RiskLessPips: If you set the new parameter ShowExtendedStats to true, it will calculate and display the "Expected earnings per trade" and the "Expected return per dollar" figures. These figures are calculated from the filtered trades as displayed in the report -- not all trades.

UPDATE: 2018.01.31: The input parameter MagicNumbers now expects a comma-separated list of magic numbers, to allow the selection of a subset of trades by magic number. If this parameter is left blank (the default), all magic numbers are selected.

UPDATE: 2018-06-30: Added a save button to allow the saving of selected trades to a CSV file.

UPDATE: 2018-07-18: Additional column 'Nett %' by Paul (Baluda). Well done Paul, you are a star!

UPDATE: 2018-08-24: Added additional groupBy options: group by 'Day of Week', 'Week', or 'Month'

UPDATE: 2018-10-14: Added ability to group by HOUR. Now it is possible to filter by a (comma-separated) list of order comments.

UPDATE: 2019-01-26: Squashed a divide-by-zero bug and updated the default report end date to the end of 2019.

DNTme » Thu Feb 21, 2019 12:53 pm wrote:The % as a total is not correctly calculated. Did anyone notice this yet?

In my example, the total should be 2.4% not 2.8%

DNTme » Thu Feb 21, 2019 1:39 pm wrote:1.1% + 0.5% + 1.0% - 0.2% = 2.4% not 2.8%

Baluda » Thu Feb 21, 2019 12:49 pm wrote:

DNTme » Thu Feb 21, 2019 1:39 pm wrote:1.1% + 0.5% + 1.0% - 0.2% = 2.4% not 2.8%

But that is not the right calculation. The percentage calculation is (and should be) based on the Nett P/L and the Account balance.

Please be clear in your error description. Why should it be 2.4%? Please must understand I do not open the code editor when someone shouts 'It does not work'.

The_Snowman » Fri Apr 19, 2019 7:56 pm wrote: Just wondering if a column for the Swaps could be included?

renexxxx » Sat Apr 20, 2019 6:55 am wrote:

The_Snowman » Fri Apr 19, 2019 7:56 pm wrote: Just wondering if a column for the Swaps could be included?

Currently, the "profit" column represents the OrderProfit + OrderSwap + OrderCommission for the group of trades contained in a row of the report. Of course, we could split this out over three columns, but on some screens the width of the report would exceed the available screen width.

If you press the little button that looks like an old fashioned diskette (on the bottom right), a file with the name TradeReport_<accountNo>.csv is created in the \Files folder. This file contains all relevant data (including the SWAP figure) for the group of trades selected in the report. It can be opened in Excel or its open source equivalent. You can then tinker with that data to your hearts content. Hopefully this fulfills your requirement.

Regards.