stevehopwoodforex.com
https://www.stevehopwoodforex.com/phpBB3/
Print view

Slopey Peaky Bob
https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=5389		 Page 16 of 84
Author:  Jemook [ Wed Jun 06, 2018 8:12 am ]
Post subject:  Slopey Peaky Bob
tomele » Wed Jun 06, 2018 10:59 am wrote:Hi @all.

The tests database view: We have stored the DAILY data of every single trade on our side. Delete whatever you want on the trade server, we will cope with it to enforce continuity for the tests database.

My personal view as a tester: I have SPB running OOTB over weeks, just without closing any trades. The maximum number of trades was around 180. The order changes per day always stayed in the two-digit range. I dont know what some people are doing, but there is no fault in the EA code if configured reasonably.

My two cents.

Cheers
Thomas
Thanks for the feedback! The issue isn't the number of trades - it's the number of trade modifications ie open, close, adjust SL or TP etc.

Some of the accounts with EAs are sending more than 10,000 modifications a day.. I've seen over a million a day in some really bad cases. Unfortunately it seems the only way to deal with this is to immediately delete any account that is deemed hyperactive (more than 10k a day) before it clogs up the trade database and causes issues to the server.

So a word of caution to everyone - please check your EAs and ensure they aren't looping like a madman and modifying 100 open orders 100 times a minute as our first priority is to all of the users of the server and your account will be deleted.

Cheers
Jeremy
Author:  tgm0 [ Wed Jun 06, 2018 9:21 am ]
Post subject:  Slopey Peaky Bob
Jemook » Wed Jun 06, 2018 9:12 am wrote:
tomele » Wed Jun 06, 2018 10:59 am wrote:Hi @all.

The tests database view: We have stored the DAILY data of every single trade on our side. Delete whatever you want on the trade server, we will cope with it to enforce continuity for the tests database.

My personal view as a tester: I have SPB running OOTB over weeks, just without closing any trades. The maximum number of trades was around 180. The order changes per day always stayed in the two-digit range. I dont know what some people are doing, but there is no fault in the EA code if configured reasonably.

My two cents.

Cheers
Thomas
Thanks for the feedback! The issue isn't the number of trades - it's the number of trade modifications ie open, close, adjust SL or TP etc.

Some of the accounts with EAs are sending more than 10,000 modifications a day.. I've seen over a million a day in some really bad cases. Unfortunately it seems the only way to deal with this is to immediately delete any account that is deemed hyperactive (more than 10k a day) before it clogs up the trade database and causes issues to the server.

So a word of caution to everyone - please check your EAs and ensure they aren't looping like a madman and modifying 100 open orders 100 times a minute as our first priority is to all of the users of the server and your account will be deleted.

Cheers
Jeremy
Jeremy, Thomas.

The issue started in version 1h with the introduction of DeletePendingTradesOnOppositeColour.
v1h code missed some logic though and after DeletePendingTradesOnOppositeColour was triggered (its value is TRUE out of the box if I remember correctly), SPB was diligently reopening the deleted pending again and this cycle went over and over creating the issue.
Logic was corrected by Steve in version 1l after Brenden spotted the issue.

I personally had issue as I was still running v1i and after updating to 1l SPB stopped going out of its way.
Logs on v1i were up to 20MB in size, after the update to 1l logs went back to a more reasonable 30KB size.

I hope this help in clearing what happened so far.

Jeremy be ready couse I will be fireing up 5 more demos soon and all running the latest version of SPB.
This time though I will monitor closely logs size in order o mitigate unwanted behaviors.

Bests to you all. :hi:
Mauro
Author:  SteveHopwood [ Wed Jun 06, 2018 10:49 am ]
Post subject:  Slopey Peaky Bob
tgm0 » Wed Jun 06, 2018 9:21 am wrote:
Jeremy, Thomas.

The issue started in version 1h with the introduction of DeletePendingTradesOnOppositeColour.
v1h code missed some logic though and after DeletePendingTradesOnOppositeColour was triggered (its value is TRUE out of the box if I remember correctly), SPB was diligently reopening the deleted pending again and this cycle went over and over creating the issue.
Logic was corrected by Steve in version 1l after Brenden spotted the issue.

I personally had issue as I was still running v1i and after updating to 1l SPB stopped going out of its way.
Logs on v1i were up to 20MB in size, after the update to 1l logs went back to a more reasonable 30KB size.

I hope this help in clearing what happened so far.

Jeremy be ready couse I will be fireing up 5 more demos soon and all running the latest version of SPB.
This time though I will monitor closely logs size in order o mitigate unwanted behaviors.

Best to you all. :hi:
Mauro
Great post Mauro.

Guys, you can expect trouble if you do not keep up with bug fixes.

:xm: :rocket:
Author:  Jemook [ Wed Jun 06, 2018 11:13 am ]
Post subject:  Slopey Peaky Bob
Thanks to all you Steve Hoppers for taking this as seriously as we are. If anyone has any questions please feel free to ask. Happy trading.

Jem
Author:  chrisdk2018 [ Thu Jun 07, 2018 7:44 am ]
Post subject:  Slopey Peaky Bob
Almost 3000 pips since May 22.

SPB rocks :clap:
Author:  alecsa72 [ Thu Jun 07, 2018 7:44 am ]
Post subject:  Slopey Peaky Bob
Since Peaky on Steroids had been inactive this week due to lack of moves, I thought I would try SPB on the same account where I had PoS.

Results are very good - while in 4 weeks I had about 21.6% equity increase with PoS (avg about 5%), so far with SPB I added another 20% equity increase in a single week, and it's not even Friday yet.

Settings mostly out of the box, but I have butchered the code quite a bit myself (Version 1L) - by adding a section to rollover period which deletes all pending orders during rollover period - I don't want to leave pending orders over that period since there can be some wild swings.

If this (live) account survives for more than 2-3 weeks I will post the "butchered" code, if anyone is interested

The SPB comment in the pic is from SPB, the other 3 were from PoS, all running since week of May 05
Capture.PNG
Author:  nicolkoekoek [ Thu Jun 07, 2018 8:41 am ]
Post subject:  Slopey Peaky Bob
alecsa72 » Thu Jun 07, 2018 7:44 am wrote:Since Peaky on Steroids had been inactive this week due to lack of moves, I thought I would try SPB on the same account where I had PoS.

Results are very good - while in 4 weeks I had about 21.6% equity increase with PoS (avg about 5%), so far with SPB I added another 20% equity increase in a single week, and it's not even Friday yet.

Settings mostly out of the box, but I have butchered the code quite a bit myself (Version 1L) - by adding a section to rollover period which deletes all pending orders during rollover period - I don't want to leave pending orders over that period since there can be some wild swings.

If this (live) account survives for more than 2-3 weeks I will post the "butchered" code, if anyone is interested

The SPB comment in the pic is from SPB, the other 3 were from PoS, all running since week of May 05
looks great! and yes interested! :smile:
Author:  traveliron [ Fri Jun 08, 2018 2:27 am ]
Post subject:  Slopey Peaky Bob
Just got home very late from work to discover SPB EA (OOTB except for lot size tinkering) in another loop. My IP's already been banned then unbanned by GP using version 1K. But the real worry is this is version 1L. Bugger!

I've just disabled it for now and will look at it when I wake up. I'm just too tired right now but wanted to report it ASAP.
Author:  Bismark [ Fri Jun 08, 2018 9:27 am ]
Post subject:  Slopey Peaky Bob
alecsa72 » Thu Jun 07, 2018 3:44 pm wrote:Since Peaky on Steroids had been inactive this week due to lack of moves, I thought I would try SPB on the same account where I had PoS.

Results are very good - while in 4 weeks I had about 21.6% equity increase with PoS (avg about 5%), so far with SPB I added another 20% equity increase in a single week, and it's not even Friday yet.

Settings mostly out of the box, but I have butchered the code quite a bit myself (Version 1L) - by adding a section to rollover period which deletes all pending orders during rollover period - I don't want to leave pending orders over that period since there can be some wild swings.

If this (live) account survives for more than 2-3 weeks I will post the "butchered" code, if anyone is interested

The SPB comment in the pic is from SPB, the other 3 were from PoS, all running since week of May 05
That is a rather small amount to run both PoS and SPB at the same time. Even one of them could flip the account with 0.01 lot trades. If this is a real acct, beware.
Author:  och [ Fri Jun 08, 2018 3:26 pm ]
Post subject:  Slopey Peaky Bob
Hi all,

@coders,

I am not a coder and this is probably because I do not understand the folowing code :

Code: Select all

void ShutDownForTheWeekend()
{

   //Close/delete all trades to be flat for the weekend.
   
   int day = TimeDayOfWeek(TimeLocal() );
   int hour = TimeHour(TimeLocal() );
   bool CloseDelete = false;
   
   //Friday
   if (day == 5)
   {
      if (hour >= FridayCloseAllHour)
         if (TotalCashUpl >= MaxAllowableCashLoss)//MaxAllowableCashLoss is a negative number
            CloseDelete = true;
   }//if (day == 5)
 
   //Saturday
   if (day == 6)
   {
      if (hour >= SaturdayCloseAllHour)
         if (TotalCashUpl >= MaxAllowableCashLoss)//MaxAllowableCashLoss is a negative number
            CloseDelete = true;
   }//if (day == 6)
   
   if (CloseDelete)
   {
      CloseAllTrades(AllSymbols, AllTrades);
      if (ForceTradeClosure)
         CloseAllTrades(AllSymbols, AllTrades);
      if (ForceTradeClosure)
         CloseAllTrades(AllSymbols, AllTrades);
   }//if (CloseDelete)
      

}//End void ShutDownForTheWeekend()
Reading the code/manual, I understood that :
1. TotalCashUpl is the sum in currency of all opened trades (all pairs included),
2. MaxAllowableCaskLoss is the maximum I accepted to loss at the end of the week, if the equity is lower than this value I expected the EA to close all trades (unless that mean if loss is greater, I accept to stay in position during the WE, hoping market will reverse next week...).

Let's say we are on friday 7 PM, just before the Forex closing bell. I have opening positions and the equity is -100, so this is 5 times lower than the MaxAllowableCaskLoss set to -20. I expected the EA to close all positions and to bank a -100 drawdown, but as -100 is not >= than -20 CloseDelete will remain false and opening positions won't be closed. Did I missed something?

On the other hand, if we are on saturday, market is closed so even if CloseDelete is set to true, CloseAllTrades can not execute OrderClose can it?

Thanks for your insigth.

Regards,
All times are UTC Page 16 of 84

Powered by phpBB® Forum Software © phpBB Limited