och » Fri Jun 08, 2018 3:26 pm wrote:Hi all,

@coders,

I am not a coder and this is probably because I do not understand the folowing code :

Code: Select all

void ShutDownForTheWeekend()
{

   //Close/delete all trades to be flat for the weekend.
   
   int day = TimeDayOfWeek(TimeLocal() );
   int hour = TimeHour(TimeLocal() );
   bool CloseDelete = false;
   
   //Friday
   if (day == 5)
   {
      if (hour >= FridayCloseAllHour)
         if (TotalCashUpl >= MaxAllowableCashLoss)//MaxAllowableCashLoss is a negative number
            CloseDelete = true;
   }//if (day == 5)
 
   //Saturday
   if (day == 6)
   {
      if (hour >= SaturdayCloseAllHour)
         if (TotalCashUpl >= MaxAllowableCashLoss)//MaxAllowableCashLoss is a negative number
            CloseDelete = true;
   }//if (day == 6)
   
   if (CloseDelete)
   {
      CloseAllTrades(AllSymbols, AllTrades);
      if (ForceTradeClosure)
         CloseAllTrades(AllSymbols, AllTrades);
      if (ForceTradeClosure)
         CloseAllTrades(AllSymbols, AllTrades);
   }//if (CloseDelete)
      

}//End void ShutDownForTheWeekend()

Reading the code/manual, I understood that :
1. TotalCashUpl is the sum in currency of all opened trades (all pairs included),
2. MaxAllowableCaskLoss is the maximum I accepted to loss at the end of the week, if the equity is lower than this value I expected the EA to close all trades (unless that mean if loss is greater, I accept to stay in position during the WE, hoping market will reverse next week...).

Let's say we are on friday 7 PM, just before the Forex closing bell. I have opening positions and the equity is -100, so this is 5 times lower than the MaxAllowableCaskLoss set to -20. I expected the EA to close all positions and to bank a -100 drawdown, but as -100 is not >= than -20 CloseDelete will remain false and opening positions won't be closed. Did I missed something?

On the other hand, if we are on saturday, market is closed so even if CloseDelete is set to true, CloseAllTrades can not execute OrderClose can it?

Thanks for your insigth.

Regards,

chrisdk2018 » Thu Jun 07, 2018 3:44 pm wrote:Almost 3000 pips since May 22.

SPB rocks

ThaiGuy » Wed Jun 13, 2018 3:22 pm wrote:

chrisdk2018 » Thu Jun 07, 2018 3:44 pm wrote:Almost 3000 pips since May 22.

SPB rocks

I'm getting good results also... but not as good as yours Chris since around the same start date!

Do you also use the OOTB settings? or use a different SET?

I'm using GlobalPrime as broker btw...

Cheers mate

rapple » Wed Jun 13, 2018 3:06 pm wrote: Hi ThaiGuy

If you start posting your results on Thomas and Rene's database you will get access to huge number of setfiles and results including those of Chrisdk2018

http://www.stevehopwoodforex.com/phpBB3 ... 105&t=5423

It is incredibly easy to use and the more subscribers the more powerful it gets :youknow:

Cheers Richard

MaxPairsAllowed: this is a filter to help avoid over trading. It tells PoS how
many individual pairs are allowed to be trading at any one time.

PeterUK » Wed Jun 13, 2018 11:04 pm wrote:Hi team,

To prevent overtrading on a small live trading account, do you think we should add a feature from POS so that it works OOTB?

MaxPairsAllowed: this is a filter to help avoid over trading. It tells PoS how
many individual pairs are allowed to be trading at any one time.

Using "OnlyTradePositiveSwap" also helps minimise overtrading with small accounts and I have enabled this in SPB trading live

These two variables has enabled my small live trading account with GP to grow with POS EA... this info may benefit others using SPB.

Remember to trade to live another day... and be patient when you enter a period of drawdown and the positive swap helps

Regards,

Peter

Remember to trade to live another day

Redboros » Thu Jun 14, 2018 5:32 am wrote:Hello Steve and Peter:

Regarding the filter OnlyTradePositiveSwap=true, I like Steve idea to convert or add a new filter defined by value, for example OnlyTradeSwap >= -7.00 (the usual comission for a round lot as a baseline).

It also could be applied to the independet (CAD/AUD/NZD)PairsPositiveOnly.

Regards,

Redboros