effluvium » Fri Apr 11, 2014 10:07 pm wrote:Hi Tommaso,
First of all. Thank you for your great work and elaborating this very helpful indicator that could announce many improvment to analyse and to be in synch with PA direction. I went in depth in your code but I could not understand the purpose of these lines when you were calculating the valur of Stochastics:

You have written here:

Code: Select all

if(d == 1 && BrokerHasSundayCandle && HigherTF_Used==1440)
      {
        HigherTF1STOCH=((iStochastic(NULL,HigherTF_Used,K_period_HT,D_period_HT,S_period_HT,STOCH_MAIN_Ma_HT,STOCH_MAIN_Price_HT,MODE_MAIN,1))
               +BrokerHour *(iStochastic(NULL,HigherTF_Used,K_period_HT,D_period_HT,S_period_HT,STOCH_MAIN_Ma_HT,STOCH_MAIN_Price_HT,MODE_MAIN,1)))/(1+BrokerHour);;
      }
        if(d == 1 && BrokerHasSundayCandle && HigherTF2_Used==1440)
      {
      HigherTF2STOCH=  ((iStochastic(NULL,HigherTF2_Used,K_period_HT,D_period_HT,S_period_HT,STOCH_MAIN_Ma_HT,STOCH_MAIN_Price_HT,MODE_MAIN,1))
            +BrokerHour*(iStochastic(NULL,HigherTF2_Used,K_period_HT,D_period_HT,S_period_HT,STOCH_MAIN_Ma_HT,STOCH_MAIN_Price_HT,MODE_MAIN,1)))/(1+BrokerHour);;
      }

So if I put this in a more simple form : (Stoch_valueTF + brokerHour * Stoch_valueTF) / (1 + brokerHour)
DO you agree ?
So the numerator could be expressed by : Stoch_valueTF * (1+ brokerHour) . Correct ?
And the whole formula will result in Stoch_valueTF by simplifying (1+ brokerHour) in numerator and denominator. You see ? if I have (X + a.X) / (1+a) the result will be just : X

SpiderX » Sat Apr 12, 2014 7:29 am wrote:hi Tommaso,

Code: Select all

   limit=Bars-counted_bars+Period()/Period();
   limit=Bars-counted_bars+HigherTF_Used/Period();
   limit=Bars-counted_bars+HigherTF2_Used/Period();
   limit=Bars-counted_bars+HigherTF3_Used/Period();

Notice this bunch of code in the 10.9 indicator....is there any purpose to this code ?
The value of the last line overwrites the value of the previous 3 lines, so we might as well delete the first 3 lines....
Also first line will always compute to Bars-counted_bars+1 ....Since Period()/Period() is always 1.

Cheers

SpiderX » Sat Apr 12, 2014 8:29 am wrote:hi Tommaso,

Code: Select all

   limit=Bars-counted_bars+Period()/Period();
   limit=Bars-counted_bars+HigherTF_Used/Period();
   limit=Bars-counted_bars+HigherTF2_Used/Period();
   limit=Bars-counted_bars+HigherTF3_Used/Period();

Notice this bunch of code in the 10.9 indicator....is there any purpose to this code ?
The value of the last line overwrites the value of the previous 3 lines, so we might as well delete the first 3 lines....
Also first line will always compute to Bars-counted_bars+1 ....Since Period()/Period() is always 1.

Cheers

effluvium » Sat Apr 12, 2014 2:09 pm wrote:

SpiderX » Sat Apr 12, 2014 8:29 am wrote:hi Tommaso,

Code: Select all

   limit=Bars-counted_bars+Period()/Period();
   limit=Bars-counted_bars+HigherTF_Used/Period();
   limit=Bars-counted_bars+HigherTF2_Used/Period();
   limit=Bars-counted_bars+HigherTF3_Used/Period();

Notice this bunch of code in the 10.9 indicator....is there any purpose to this code ?
The value of the last line overwrites the value of the previous 3 lines, so we might as well delete the first 3 lines....
Also first line will always compute to Bars-counted_bars+1 ....Since Period()/Period() is always 1.

Cheers

I agree with SpiderX. If you put a series of assigments to the same variable, (without conditional events), that means that no matter the number of assignments, the variable "limit" will store the calculation of the last assignment. So you the whole first 3 assignments is just garbage, and will consume UC time for nothing, even if it some micro-seconds. (Also in the first assignment period()/Period() equals 1)