• Swap filter: some pairs have dreadful swap in one direction. This filter allows you to avoid trading pairs in the direction that would cost a fortune in swap. How much relevance this has to a system that could follow a trend for hundreds of pips is open to debate, but once you have seen one of these adverse-swap pairs hang around going nowhere for a couple of weeks, you will see why a lot of us want nothing to do with them.
  • MaximumAcceptableNegativeSwap: this input allows you to trade the negative swap pairs but to a maximum swap cost. You need to visit your broker's swap page to view the cost per fair; find Global Prime's at https://www.globalprime.com.au/forex-trading/swaps/. Note that the default of -1,000,000 turns this filter off.

• Copy the declaration at line 346 into your version.
• Go to 5042 and copy the code block.
• Go to 4866 and copy John's fix.

The FIFO nonsense was almost solved, but not quite. Unfortunately those tiny details matter when it comes to successful trading. The issue comes when trying to close multiple trades of the same currency pair. It does not happen often, but it is possible for orders to have the exact same Open Time stamp. In can happen when the EA places multiple orders all at the same time or more specifically in a fast moving market when the price jumps more than the Minimum Gap.

Having the same Open Time Stamp then can cause an FIFO ERROR 130 when the EA attempts to close the trade out or order. With the exact same time stamp you have a 50/50 chance of the Broker's server picking the First IN trade and it will refuse to close the trade if it guesses wrong. You are left with two open trades that should be closed, and a repetitive error message that will eventually get your account frozen.

By avoiding STOP orders altogether and introducing an even more stringent Order Close function() appears to get around the issue. I no longer get any FIFO errors with this method (Note: FIFO can also be accomplished by only allowing 1 trade per currency pair but this defeats the power of Grid Trading)

I have played with Gary's Varied Lot solution as well, but it can quickly add up to more lots at risk than I was comfortable with. Hence I needed an alternative solution. I have been trading with this format in a much more customized version for several months, the results have been promising and I can use a lot size of .01 on all trade entries.

It was time to share the FIFO related code changes with your user group and get validation that the approach was sound and repeatable.

• Basket Trailing Stop: this feature was added by SHF member 1of3. Once the cash value of our basket reaches a point of our choosing, a cash trailing stop kicks in. The idea is to catch more of the moves that are in our favour than is possible with our standard basket take profit. We can use this to lock in profit whilst hoping to reach a much larger basket TP:
  • UseBasketTrailingStop: turns this feature on/off. Note that it is disabled by default.
  • BasketTrailingStopStartValue: the basket profit at which the TS kicks in. The default is based on a 0.01 lot size on a Global Prime account.
  • BasketTrailingStopGapValue: the distance between the stop loss and the basket profit. The default is based on a 0.01 lot size on a Global Prime account.

Huge contribution, John.

SteveHopwood » Tue Jun 19, 2018 12:57 am wrote:A question for The Thinkers here. Bear in mind that everything I produce here applies to Koban's US version and I shall pass it to him for easy addition. There is nothing different in the trading methodology, only in the trade closure.

So, we have a basket close and cheer mightily. Mine just did and I am indeed cheering mightily. Another $120 in the equity across two of my accounts.

The bot instantly sends a new grid of stop orders because the trading conditions are still in place. Here is the question. Should we introduce a delay before this happens?