stevehopwoodforex.com
https://www.stevehopwoodforex.com/phpBB3/
Print view

My shell EA code
https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=79		 Page 19 of 23
Author:  SteveHopwood [ Sun May 01, 2016 12:52 pm ]
Post subject:  My shell EA code
I have added another .mq4 file to post 1 - Retro-fitting Offsetting to shell generated EA's.mq4

This describes the steps you need to follow to ad offsetting to EA's you produced using earlier versions of the shells.

:xm:
Author:  SteveHopwood [ Sun May 01, 2016 6:36 pm ]
Post subject:  My shell EA code
Make sure you have read my "Really irritating bloop alert" in the RnR thread to know what this is all about. Fix in post 1.

Fixed shells and retrofitting thingy are in post 1.

:xm:
Author:  SteveHopwood [ Mon May 02, 2016 7:24 pm ]
Post subject:  My shell EA code
The bloop that dydynamic spotted and posted about in RnR is fixed in the post 1 versions.

:xm:
Author:  SteveHopwood [ Tue Jun 07, 2016 1:53 pm ]
Post subject:  My shell EA code
I have added a "Retro-fitting CSS" document to post 1, for those of you who want to know how to add it later on to EA's you created using the shells.

:xm:
Author:  Timid [ Wed Jun 29, 2016 7:26 pm ]
Post subject:  My shell EA code
Carefully trying to fit in the code from Retro-fitting CSS.mq4 to my own EA I have spotted two parts that has given me problems.

The first one is in the function libCSSinitSymbols() on line 240, where the check if trading a symbol is allowed before adding it to the array created an empty array for me when initiating my EA while the market was closed during the weekend. For my own part I decided to remove this check, but I am sure there are better solutions to this.

The second thing that gave me problems is if I start the EA and then go back in to the parameters (F7) and exit by clicking OK, which will re-initialise the EA and thus again call the libCSSinitSymbols(). By now the string libCSSsymbolsToWeigh is empty (done on line 247) and also the array libCSSsymbolNames is by now 28 in size. To care for this I set the size of libCSSsymbolNames to 0 first in the function libCSSinitSymbols() and then I created another variable (libCSSHoldSymbolsToWeigh) to hold the string of 28 symbols untouched and this I use to give the correct value to libCSSsymbolsToWeigh after the resize of the array.

So basically the list of variables now look like this:

Code: Select all

string  libCSSsymbolsToWeigh           = "";
string  libCSSHoldSymbolsToWeigh       = "GBPNZD,EURNZD,GBPAUD,GBPCAD,GBPJPY,GBPCHF,CADJPY,EURCAD,EURAUD,USDCHF,GBPUSD,EURJPY,NZDJPY,AUDCHF,AUDJPY,USDJPY,EURUSD,NZDCHF,CADCHF,AUDNZD,NZDUSD,CHFJPY,AUDCAD,USDCAD,NZDCAD,AUDUSD,EURCHF,EURGBP";
And at the beginning of libCSSinitSymbols() I put:

Code: Select all

   ArrayResize(libCSSsymbolNames, 0);   
   libCSSsymbolsToWeigh = libCSSHoldSymbolsToWeigh;

This works for me.
Timid
Author:  SteveHopwood [ Sun Jul 03, 2016 9:24 am ]
Post subject:  My shell EA code
Latest versions of the 3 shells I use are in post 1. They contain bits of tidying up I made when using them threw up minor bloops.

Here is a block of code you can add to your shells OnInit() function so you can quickly code checks that EA users have the relevant indicators in their folders, to save redownloading if you have already found and fixed the bloops.

Code: Select all

   //Missing indi check
   /*
   if (!indiExists( "IndiName" ))
   {
      Alert("The required indicator " + "IndiName" + " does not exist on your platform. I am removing myself from your chart.");
      Alert("Download the indi from the thread or from http://www.stevehopwoodforex.com/phpBB3/viewtopic.php?f=15&t=79&p=803#p803");
      RemoveExpert = true;
      ExpertRemove();
      return(0);
   }//if (! indiExists( "IndiName" ))
   */

   //Semafor
   if (CloseTradesOnRelevantSemafor || CloseImmediatelySemaforAppears)
      if (!indiExists( "3 Level" ))
      {
         Alert("The required indicator " + "3 Level" + " does not exist on your platform. I am removing myself from your chart.");
         Alert("Download the indi from the thread or from http://www.stevehopwoodforex.com/phpBB3/viewtopic.php?f=15&t=79&p=803#p803");
         RemoveExpert = true;
         ExpertRemove();
         return(0);
      }//if (! indiExists( "IndiName" ))
:xm:
Author:  SteveHopwood [ Sat Jul 09, 2016 9:59 am ]
Post subject:  My shell EA code
Here is an improved missing indi check snippet that displays the info in the way that we normally read printed information:

Code: Select all

   //Missing indi check
   /*
   if (!indiExists( "IndiName" ))
   {
      Alert("");
      Alert("Download the indi from the thread or from http://www.stevehopwoodforex.com/phpBB3/viewtopic.php?f=15&t=79&p=803#p803");
      Alert("The required indicator " + "IndiName" + " does not exist on your platform. I am removing myself from your chart.");
      RemoveExpert = true;
      ExpertRemove();
      return(0);
   }//if (! indiExists( "IndiName" ))
   */
:xm:
Author:  K-Lander [ Mon Jul 25, 2016 1:52 pm ]
Post subject:  My shell EA code
Hello all,
Doing my first attempt with the Bugger All Shell EA, testing a simple strategy to get acquainted with the code. I´ve only tinkered with the trading decision section on the corresponding routine (see line 1270 of the attached EA), deleted the SendLong & Sendshort "falses" and declared the two variables I´m using, yet the EA doesn´t trade even though the conditions are met. Couldn´t find where the problem is, so any help will be much appreciated.

The EA should trigger a trade if the current bar´s Volume reaches a user-defined threshold and if the current bar size (Open-Close) reaches a user-defined threshold, i.e. a buy if the candle is green, a sell if the candle is red.

Thanks a bunch,
Ariel
Author:  LittleCaro [ Thu Mar 09, 2017 4:04 pm ]
Post subject:  My shell EA code
Steve,

The time filter in your shell not work anymore.

I tried with the latest barebones shell.

Try to switch from outside trading hours and inside trading hours on your chart, and you will see it not responds anymore. It stays stuck.

I have already worked with it, an i enter correctly the hour and i enter my time.

Some morons at craperquotes may have changed something.

Please if you could have a look when you'll have free time.

Thanks !
Author:  LittleCaro [ Mon Mar 20, 2017 9:57 am ]
Post subject:  My shell EA code
Hello Steve,

I find my mistake, your time filter works right.

Here is what i do for broke it :) I leave open my Empty4 and i put in sleep mode my computer.

Then i programmed my computer to wake up and all my Empty4 starts right. He he but this broke the time filter.

So if you are reading me, close your Empty4 before putting in sleep mode your computer.


I 'm such a dimwit sometimes :clap:
All times are UTC Page 19 of 23

Powered by phpBB® Forum Software © phpBB Limited