stevehopwoodforex.com
https://www.stevehopwoodforex.com/phpBB3/
Print view

ChangeTheColor EA
https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=221
Page 20 of 24
Author:  MiTija [ Tue Jan 31, 2012 12:19 am ]
Post subject:  Re: ChangeTheColor EA

ROBST3R wrote:here you go, 1.35
Thank you!

Best Regards,


MiTija
Author:  skoda2008 [ Wed Feb 01, 2012 8:15 am ]
Post subject:  Re: ChangeTheColor EA

I have been running version 1.38 for the last few days. I noticed a few orders were slipping through with no stoploss applied. It turns out there is a small typo in the InsertStopLoss module, a small typo which could potentially cost you $$$!

Code: Select all

if (OrderType() == OP_BUY)
   {
      stop = CalculateStopLoss(OP_SELL);
   }//if (OrderType() == OP_BUY)
   
Should be changed to:

Code: Select all

if (OrderType() == OP_BUY)
   {
      stop = CalculateStopLoss(OP_BUY);
   }//if (OrderType() == OP_BUY)
   
Otherwise you may end up with no stoploss applied to some Buy orders, as I was experiencing.
Author:  magft [ Wed Feb 01, 2012 9:30 am ]
Post subject:  Re: ChangeTheColor EA

skoda2008 wrote:I have been running version 1.38 for the last few days. I noticed a few orders were slipping through with no stoploss applied. It turns out there is a small typo in the InsertStopLoss module, a small typo which could potentially cost you $$$!

Code: Select all

if (OrderType() == OP_BUY)
   {
      stop = CalculateStopLoss(OP_SELL);
   }//if (OrderType() == OP_BUY)
   
Should be changed to:

Code: Select all

if (OrderType() == OP_BUY)
   {
      stop = CalculateStopLoss(OP_BUY);
   }//if (OrderType() == OP_BUY)
   
Otherwise you may end up with no stoploss applied to some Buy orders, as I was experiencing.
Oops! I havent done anything with that code from the Shell so something to watch for in other EAs maybe? I'll update and send out a fix in a bit. Nice catch!

Mike
Author:  skoda2008 [ Wed Feb 01, 2012 11:04 am ]
Post subject:  Re: ChangeTheColor EA

I'm still getting a few orders with no stoploss. It looks like there is still some contention when orders try and open at the same time, even with the global variable thing going on. The orders open okay, but when they are modified to take the stop loss (2 stage crim) only one of them ends up with a SL, the other stays at zero. The log isn't showing any errors, the EA just appears not to be sending the request? I will see if I can decipher the code and figure out what is (or isn't) happening...
Author:  magft [ Wed Feb 01, 2012 12:32 pm ]
Post subject:  Re: ChangeTheColor EA

Update in Post #1
Author:  trader689 [ Wed Feb 01, 2012 7:11 pm ]
Post subject:  Re: ChangeTheColor EA

hey magft does this latest update also fix this following error, referring to v1.38? -

"Weird activity this morning. I had several trades open up that were totally backwards. Buy orders when candles were all well below MA"


thanks
magft wrote:Update in Post #1
Author:  magft [ Wed Feb 01, 2012 7:47 pm ]
Post subject:  Re: ChangeTheColor EA

trader689 wrote:hey magft does this latest update also fix this following error, referring to v1.38? -

"Weird activity this morning. I had several trades open up that were totally backwards. Buy orders when candles were all well below MA"


thanks
magft wrote:Update in Post #1
It should do :roll:
Author:  Rascacio [ Fri Feb 03, 2012 8:03 am ]
Post subject:  Re: ChangeTheColor EA

magft wrote:
trader689 wrote:hey magft does this latest update also fix this following error, referring to v1.38? -

"Weird activity this morning. I had several trades open up that were totally backwards. Buy orders when candles were all well below MA"


thanks
magft wrote:Update in Post #1
It should do :roll:
Hi magft, I have the latest version and I have had 8 trades all losers and all appear to placed back to front.

I can't figure it out. Anyone else with obviously reversed trades ?
Author:  spyderman [ Fri Feb 03, 2012 12:22 pm ]
Post subject:  Re: ChangeTheColor EA

Rascacio wrote: Hi magft, I have the latest version and I have had 8 trades all losers and all appear to placed back to front.

I can't figure it out. Anyone else with obviously reversed trades ?
I'm not getting back to fronts, just losing trades... :| Like 80% loosers. Don't know if it's the market but I haven't been doing well since version 1.35. Might try going back to that. ???
Author:  Walking Hell [ Mon Feb 13, 2012 4:52 pm ]
Post subject:  Re: ChangeTheColor EA

project still alive? :shock:
All times are UTC Page 20 of 24