garyfritz wrote:Warning, educational but geeky detail ahead:

etc

SteveHopwood wrote: So, how about my original solution of turning doubles into strings and comparing the strings?

garyfritz wrote:Well, it should work. But it seems like a pretty convoluted and high-overhead way to do something pretty simple.

The (A-B) < ReallySmall approach works fine (especially with the scaling addition) and is very simple. You could encapsulate it into your own CloseEnough() function and forget about the details. (BTW I realized I forgot something -- it should be MathAbs(A-B) < ReallySmall.) (Whoops, rob2360 beat me to it.

And the Empty4 boys are not alone in this. It's the standard way that most languages work. I've only come across 1 or 2 languages (out of many dozens) in 35 years that tried to handle it intelligently. (I don't *think* any of the common languages today do anything but simple equality tests, though it's easy to extend C++/C#/Java/etc to do so.)

garyfritz wrote:I have no idea what the EA is doing or how it's good vs. not. But the difference between those two code snippets is that the first one runs the rest of the start() code only once per completed bar, whereas the second one runs all the start() code on every tick. You'd have to figure out how that changes the EA behavior.

SteveHopwood wrote: Described briefly, the ea modifies the stop loss and take profit of pending trades to reflect those of an open trade. The ea kept on insisting that the various sl/tp's were not equal even though they are.

if (mf(A) == mf(B)) {
   code .....
}

//+------------------------------------------------------------------+
//|  Function: Better than NormalizeDouble                             |
//+------------------------------------------------------------------+
double mf(double value) {
	return(MathFix(value,Digits));
}  //------------END FUNCTION-------------//

//+------------------------------------------------------------------+
double MathFix(double n, int d=0)
//+------------------------------------------------------------------+
// Corrects a rounding/accuracy bug in MQL4's MathRound() function
//   (use MathFix(n) instead of MathRound(n)
// Rounds n to d decimal places, e.g.
// MathFix(2.54,1) returns 2.5
// MathFix(2.57,1) returns 2.6
// MathFix(2.99)   returns 3
{
	return(MathRound(n*MathPow(10,d)+0.000000000001*MathSign(n))/MathPow(10,d));
}  //------------END FUNCTION-------------//

//+------------------------------------------------------------------+
int MathSign(double n)
//+------------------------------------------------------------------+
// Returns the sign of a number (i.e. -1, 0, +1)
// Usage:   int x=MathSign(-25)   returns x=-1
{
	if (n > 0) return(1);
	else if (n < 0) return (-1);
	else return(0);
}  //------------END FUNCTION-------------//