SpiderX wrote:Hi Steve,

I am trying to modify your new file to the original logic.

Code: Select all

void GetCandleDirection()
{
   //Called at the start of each new candle.
   //Sets CandleDirection to up, down, none depending on the direction of the previous candlesitck
   
   CandleDirection = none;
   if (Close[1] > Open[1]) 
      if (Close[2] > Open[2]) 
         CandleDirection = up;
   
   if (Close[1] < Open[1]) 
      if (Close[2] < Open[2]) 
         CandleDirection = down;

}//void GetCandleDirection()

Is this the only portion that i need to edit ?

Cheers

SpiderX wrote:Hi Steve,

Not sure if i missed out something, but so far on the EA there is only selling and no buying.

Edit:

1. Looking at the code under LookingForTradingOpportunities:

Code: Select all

   //Long 
   if (!UseRsi) RsiTrend = up;
   if (CandleDirection == up && RsiTrend == up)
   {
      SendLong = true;
      //Opposite direction trades
      if (TradeOppositeOfTrigger)
      {
         SendShort = true;
      }//if (TradeOppositeOfTrigger)
      
   }//if (CandleDirection == up)
   

   //Short   
   if (!UseRsi) RsiTrend = down;
   if (CandleDirection == down && RsiTrend == down)
   {
      if (TakeProfit > 0) take = NormalizeDouble(Bid - (TakeProfit * Point), Digits);
      if (StopLoss > 0) stop = NormalizeDouble(Bid + (StopLoss * Point), Digits);
      type = OP_SELL;
      price = Bid;
      SendTrade = true;
      //Opposite direction trades
      if (TradeOppositeOfTrigger)
      {
         if (TakeProfit > 0) take = NormalizeDouble(Ask + (TakeProfit * Point), Digits);
         if (StopLoss > 0) stop = NormalizeDouble(Ask - (StopLoss * Point), Digits);
         type = OP_BUY;
         price = Ask;
      }//if (TradeOppositeOfTrigger)
   }//if (CandleDirection == down && RsiTrend == down)

Would like to check, should the code of the long and short direction be similar ?
It seems the short side code has more material than the long.
Is this correct ?

2. Even though this bug has not emerged yet, but it seems that the EA does not take into consideration TradeOppositeOfTrigger for the closure of trades.
Closure of trade looks to be correct only for the existing logic.
There seems to be a need for additional code in trade closure to take opposite of trigger into account.

Please correct me if the above is wrong as i am much less familiar with the code than you.

Cheers

SpiderX wrote:Thanks Steve,

By the way, i observed that the code could be more efficient in some places, if "if..else" is used, instead of just "if ...if...if"

Just for example:

Code: Select all

if(type == OP_BUY)
     do  x;

if(type == OP_SELL)
    do   y;

might be better as:

Code: Select all

if(type == OP_BUY)
     do  x;

else if(type == OP_SELL)
    do   y;

In this way, we are clear that only one of them can trigger at one time (great for debugging and error proofing), also code would be more efficient.
I was wondering if there was something buggy with "if..else" that leads to "if...if..if..if".

Cheers