fx8000 » Wed Oct 15, 2014 5:46 am wrote:Thanks again for the ea, Steve.
The UseHiLoForStop prematurely took out the stops this am. I may be mistaken, but is it possible the stop for OP_BUY and OP_SELL should have been the other way round as shown below ?
peter
Hmmmmm. I wonder what I was on when I coded that little lot. It is all rubbish, so thanks for the spot. 
Fix in 1c in post 1, or copy this over the top of the existing function and recompile:
Code: Select all double CalculateStopLoss(int type, double price)
{
//Returns the stop loss for use in LookForTradingOpps and InsertMissingStopLoss
double stop = 0;
//Calculate StopLoss based on the hilo of the signal candle
if (UseHiLoForStop)
{
int shift = 0;
if (!EveryTickMode)
shift = 1;
if (type == OP_BUY)
{
stop = NormalizeDouble(iLow(Symbol(), TradingTimeFrame, shift) - (HiLoBuffer / factor), Digits);
StopLoss = (price - stop) * factor;//For risk based lot sizing
}//if (type == OP_BUY)
if (type == OP_SELL)
{
stop = NormalizeDouble(iHigh(Symbol(), TradingTimeFrame, shift) + (HiLoBuffer / factor), Digits);
StopLoss = (stop - price) * factor;//For risk based lot sizing
}//if (type == OP_SELL)
//Check that the stop loss is big enough for the broker
double MinStop = MarketInfo(Symbol(), MODE_STOPLEVEL);
if (StopLoss < MinStop)
{
double spread = (Ask - Bid) * factor;
StopLoss = MinStop;
StopLoss+= spread;
}//if (StopLoss < MinStop)
}//if (UseHiLoForStop)
RefreshRates();
if (type == OP_BUY)
{
if (!CloseEnough(StopLoss, 0) )
{
stop = price - (StopLoss / factor);
HiddenStopLoss = stop;
}//if (!CloseEnough(StopLoss, 0) )
if (HiddenPips > 0 && stop > 0) stop = NormalizeDouble(stop - (HiddenPips / factor), Digits);
}//if (type == OP_BUY)
if (type == OP_SELL)
{
if (!CloseEnough(StopLoss, 0) )
{
stop = price + (StopLoss / factor);
HiddenStopLoss = stop;
}//if (!CloseEnough(StopLoss, 0) )
if (HiddenPips > 0 && stop > 0) stop = NormalizeDouble(stop + (HiddenPips / factor), Digits);
}//if (type == OP_SELL)
return(stop);
}//End double CalculateStopLoss(int type)
 |