Holy Graily Bob's Candle Power

[SteveHopwood]

Coenraad has just sent me a bloop spot. Line 1604:
HgiStatus = hgiuparrowtradable;

should be:

HgiStatus = hgidownarrowtradable

I was wondering why my buys were not closing following a down signal.

I will put up a fix in time for next week. Thanks Coenraad

[TraderJoeForex]

... I added a 200pip emergency SL and a 2pip BE and JS.

Here are results for last 24hours on two pairs GJ and EU.

Now 3000pips in 48hours! Steve You have created a monster

[TraderJoeForex]

Also the difference between EU and GJ above as example is far far greater than the difference in their respective volatility.

[SteveHopwood]

Now 3000pips in 48hours! Steve You have created a monster

I do always try to entertain.

I am no longer sure that my anti-bunching code is watertight.

Me being my usual gung-ho me, I put this bot on my live trading account. Usual stuff: minimal lot sizes; market would have to move about a gazillion pips against me before causing a problem.

So, as usual I have 32 buys and 41 sells open.

And HGI appears to have generated enough signals to have closed most of those trades because they were once in profit, yet the damn bot has left them smugly in place.

So as usual, code that I thought was watertight when I released it is actually bollocks.

Anybody with a firing synapse fancy running SHF?

Ho hum.

[TraderJoeForex]

I do always try to entertain.

I am no longer sure that my anti-bunching code is watertight.

Me being my usual gung-ho me, I put this bot on my live trading account. Usual stuff: minimal lot sizes; market would have to move about a gazillion pips against me before causing a problem.

So, as usual I have 32 buys and 41 sells open.

And HGI appears to have generated enough signals to have closed most of those trades because they were once in profit, yet the damn bot has left them smugly in place.

So as usual, code that I thought was watertight when I released it is actually bollocks.

Anybody with a firing synapse fancy running SHF?

Ho hum.

My results with the set file I posted essentially bi passes the intended HGI exit procedure with BE and JS instead. So don't give up. This one is definately worth straightening out. Having the intended basket close working alongside BE and JS could be very strong indeed.

[SteveHopwood]

V 1a is in post 1.

I had a look at the code intended to stop trades bunching up close together; it was rubbish. I reckon I only thought it was working because hedged baskets closed so quickly whilst I was testing the code.

Bloop spotters, line 178 declares a couple of order open prices arrays:
double BuyPrices[], SellPrices[];

These arrays are populated in CountOpenTrades and sorted into an ascending array at the end of the function.

bool EnoughDistance(int type, double price) is called by LookForTradingOpportunities() as a final check that the proposed trade is appropriate. EnoughDistance() uses the BuyPrices[] and SellPrices[] arrays to check that the open orders just above and below are at least MinDistanceBetweenTradesPips away from the proposed new trade.

Not sure the code is dead right yet. It seems to produce trades with an appropriate distance in between them in Crapergy Tester, but we all know how poor is my eye for detail. Have a look and see what you think.

[Yannis]

Steve, I think you carried the previous error with this version, line 1736.
In the ReadIndicatorValues():

Code: Select all

         if (signal==TRENDDN)
         {
            if (CloseOnLargeArrows)
               HgiStatus = hgiuparrowtradable;
         }

should read:
HgiStatus = hgidownarrowtradable

[SteveHopwood]

Steve, I think you carried the previous error with this version, line 1736.
In the ReadIndicatorValues():

Code: Select all

         if (signal==TRENDDN)
         {
            if (CloseOnLargeArrows)
               HgiStatus = hgiuparrowtradable;
         }

should read:
HgiStatus = hgidownarrowtradable

Thanks Yannis. No idea how that crept back in.

Corrected in post 1.

[SteveHopwood]

My results with the set file I posted essentially bi passes the intended HGI exit procedure with BE and JS instead. So don't give up. This one is definately worth straightening out. Having the intended basket close working alongside BE and JS could be very strong indeed.

I applied your set file apart from taking out the stop loss and changing the magic number. It was not long before trades started to close.

The first 20 minutes of trading have netted 865 pips yielding $78 (0.01 lots) and halving the open trades. I will add your set file to post 1 as a recommended set tomorrow.

Nice one, TJF.

[SteveHopwood]

Less than 30 minutes into the trading week: +2069 pips and $184.

I am enjoying this.