opita » Thu Oct 08, 2020 4:32 am wrote:
So far I have been going off your Grab Candle demo (so the information above is based on it). I just started my own version in Bully Bully Pepperstone demo. Removed both pairs mentioned above and changed the Global TP to 20 instead of 30 (using .01 lots), but have left everything else the same.

I don't want to add it to any database yet since there might be a few tweaks on the way before doing a proper demo.

woodlands » Thu Nov 05, 2020 10:50 am wrote:Thanks Steve,
I have been running several versions of Trendy Monster and try to make small adjustments only to the settings. The change in performance of this one is since adding BE and JS, otherwise has been the same setup from beginning October.
(I am also using APTM as per setfile below)

woodlands » Thu Nov 05, 2020 10:50 am wrote:Thanks Steve,
I have been running several versions of Trendy Monster and try to make small adjustments only to the settings. The change in performance of this one is since adding BE and JS, otherwise has been the same setup from beginning October.
(I am also using APTM as per setfile below)

woodlands » Thu Nov 05, 2020 11:50 am wrote:Thanks Steve,
I have been running several versions of Trendy Monster and try to make small adjustments only to the settings. The change in performance of this one is since adding BE and JS, otherwise has been the same setup from beginning October.
(I am also using APTM as per setfile below)

biobier » Thu Nov 12, 2020 9:02 pm wrote:Somehow I do not understnad how the ADX code can ever return anything else than flat:

Code: Select all

string checkAdxForTrendConfirmation(string symbol, int pairIndex)
{

   //Read ADX to ascertain the direction and strength of the movement.

   string strengthConfirmation = flat;//Default <---------------- FLAT
   double strength = 0, plusD1 = 0, minusD1= 0;
   
   strength = getADX(symbol, AdxTimeFrame, AdxPeriod, AdxApplyTo, MODE_MAIN, 0);
   plusD1 = getADX(symbol, AdxTimeFrame, AdxPeriod, AdxApplyTo, MODE_PLUSDI, 0);
   minusD1 = getADX(symbol, AdxTimeFrame, AdxPeriod, AdxApplyTo, MODE_MINUSDI, 0);
   
   
   //Check long trade trigger
   if (trigger == up)
   {
      if (plusD1 < minusD1 || strength < AdxMinimumForTrading || strength > AdxMaximumForTrading)
         strengthConfirmation = flat; <---------------- FLAT should be up IMHO
   }//if (trigger == up)
   
   //Check short trade trigger
   if (trigger == down)
   {
      if (plusD1 > minusD1 || strength < AdxMinimumForTrading || strength > AdxMaximumForTrading)
         strengthConfirmation = flat; <---------------- FLAT should be down IMHO
   }//if (trigger == down)
   
   // TDesk code
   if (SendToTDesk)
   {
      if(strengthConfirmation == up )  PublishTDeskSignal("ADX",AdxTimeFrame,symbol,LONG); else
      if(strengthConfirmation == down )   PublishTDeskSignal("ADX",AdxTimeFrame,symbol,SHORT);else
      PublishTDeskSignal("ADX",AdxTimeFrame,symbol,FLAT);
   }//if (SendToTDesk)
   
 
   return(strengthConfirmation); <---------------- FLAT

}//End string checkAdxForTrendConfirmation(string symbol, int pairIndex)

Function called via:

Code: Select all

//ADX
      if (UseAdxForStrengthConfirmation)
      {
         strengthConfirmation = checkAdxForTrendConfirmation(symbol, pairIndex);
         if (strengthConfirmation != up)
            return(false);//Not a strong enough trigger for trading
      }//if (UseAdxForStrengthConfirmation)

Is it a bug or am I not seeing the full picture?

It confused me that Woodlands set made trades while this can't confirm the strenght. But it shows that the setup does not care about ADX while it is enabled. Because is has also set AllTriggersMustAgree=true

Code: Select all

   //Trend confirmation. 
   if (!AllTriggersMustAgree)//Te getTradeTrigger() function takes
                             //care of this if AllTriggersMustAgree is enabled.
      if (!doStrengthConfirmation(symbol, pairIndex) )
         return;

Or is the "empty" line 3 the reason for checking if (!doStrengthConfirmation(symbol, pairIndex) ) always?

SteveHopwood » Fri Nov 13, 2020 1:57 am wrote: Fantastic spot. Absolutely wonderful. So simple yet it takes genius to spot, so thanks yet again for an invaluable contribution.

All it takes is a change from this:
string strengthConfirmation = flat;//Default

string strengthConfirmation = trigger;//Default

It is way past beddies here in the UK. I will post the fix in the morning.

if(!AllTriggersMustAgree){
      if (UseSuperSlopeForStrengthConfirmation)
         text = text + " Super Slope:";
      ......
      ......
}else{
       text = text + "Ignored due to AllTriggersMustAgree";
}