fxozgirl wrote:Steve, I set this EA a couple of days ago which has taken 3 trades so far, no pending orders, nothing closed yet.

But, I have been running WB only on Slopey Beast with Slowkeys settings on 4H which is going really well. One thing I have noticed is that if a pending order is placed and price then moves in the opposite direction and the trade is not taken, the pending order just waits until price comes back which may or may not occur for an indefinite period of time. Unlike TB where the opposite pending order is placed as well, trades taken, goes to profit (pending order deleted), start again.

Depending on how long it takes price action to return to the pending trade the set up may not still be valid, I have taken to manually deleting all pending orders once a day, if the setup is still valid, the EA just places it again, if setup is not valid, pending order is not replaced.

Is it possible to have the EA automate this process?

mobthehop wrote:slowkey - a bit off subject but could you please do a brief step-by-step description how you do such a backtest - for dummies (myself included). I am reasonably certain that I am not the only one who is clueless on backtesting, so maybe you do a thread post in the newbie section if and when your time permits....

Thanks in advance and have a great weekend all.....

Mop

SteveHopwood wrote:Something still isn't quite right. I am getting a lot of stop loss modification failure messages, and I cannot see any reason to modify the stop.

I will look at this.

slowkey wrote:

crazy take profit behavior..gif

I noticed several hundred 4.42 losses. So in visual mode looked and found an area where there was several 100 modifications of the take profit. The take profit is modified below market but the order is a buy. I do not have a take profit set just close at magenta line. I will see what happens on Demo this PM. Seemed to happen where price broke out of consolidation in a hyperbolic move.

if (OrderType() == OP_BUY)
   {
      take = CalculateTakeProfit(OP_SELL);
   }//if (OrderType() == OP_BUY)

if (OrderType() == OP_BUY)
   {
      take = CalculateTakeProfit(OP_BUY);
   }//if (OrderType() == OP_BUY)

SteveHopwood wrote:

slowkey wrote:

crazy take profit behavior..gif

I noticed several hundred 4.42 losses. So in visual mode looked and found an area where there was several 100 modifications of the take profit. The take profit is modified below market but the order is a buy. I do not have a take profit set just close at magenta line. I will see what happens on Demo this PM. Seemed to happen where price broke out of consolidation in a hyperbolic move.

Nice one, Doug. V 1e with the fix for this is in post 1.

There is a function in all my code that inserts a missing take profit if the 2 stage modification failed at order send time. This function in turn calls the function that calculates the take profit based on whatever parameters the program uses.

I had the buy trade calculation calling for a sell take profit, which was below the market, so WBT obediently closed the trade. Then found correct trading conditions and opened a trade. Then inserted the errant take profit...........

Coders, go to void InsertTakeProfit(int ticket) and the bloop will leap out at you.
Change

Code: Select all

if (OrderType() == OP_BUY)
   {
      take = CalculateTakeProfit(OP_SELL);
   }//if (OrderType() == OP_BUY)

to

Code: Select all

if (OrderType() == OP_BUY)
   {
      take = CalculateTakeProfit(OP_BUY);
   }//if (OrderType() == OP_BUY)

cuzgeorge wrote:

SteveHopwood wrote:

slowkey wrote:

crazy take profit behavior..gif

I noticed several hundred 4.42 losses. So in visual mode looked and found an area where there was several 100 modifications of the take profit. The take profit is modified below market but the order is a buy. I do not have a take profit set just close at magenta line. I will see what happens on Demo this PM. Seemed to happen where price broke out of consolidation in a hyperbolic move.

Nice one, Doug. V 1e with the fix for this is in post 1.

There is a function in all my code that inserts a missing take profit if the 2 stage modification failed at order send time. This function in turn calls the function that calculates the take profit based on whatever parameters the program uses.

I had the buy trade calculation calling for a sell take profit, which was below the market, so WBT obediently closed the trade. Then found correct trading conditions and opened a trade. Then inserted the errant take profit...........

Coders, go to void InsertTakeProfit(int ticket) and the bloop will leap out at you.
Change

Code: Select all

if (OrderType() == OP_BUY)
   {
      take = CalculateTakeProfit(OP_SELL);
   }//if (OrderType() == OP_BUY)

to

Code: Select all

if (OrderType() == OP_BUY)
   {
      take = CalculateTakeProfit(OP_BUY);
   }//if (OrderType() == OP_BUY)

Woooooow, Great spot Slowkey, I cant tell you how long and hard i've tried to spot what caused the eas to make these errors, and the ea threads are riddled with occurances.

Steve, could this be whats been plaguing Nanninbob EA and just about all the slope EA's ???
i'm going to check the code for your change as noted above and see if this changes the results.
regards and great, great spot Slowkey.
cuzgeorge

cuzgeorge wrote:Thank you STeve, I will never understand how you keep up with everything and the understanding you have of us all.
I jumped when i read Slowkeys' observation and cannot begin to describe how long i've tried to find that piece of code that would solve this for you, but looking back at the comparissons i'm staring at right now, !! , i'm totally embarrassed as i'm still in the dark.

new version up and waiting for ticks.

thank you again, and sorry for the offense, never intended and i'm sure you know that.
i'll keep trying my best with-out jumping like that in future.
regards
cuzgeorge