fx8000 wrote:Hi MickyMouse

Your OBV_MA indi draws only part of 21 LWMA (top)

The bottom indi is produced by dragging moving average onto the obv window.

Cheers,
Peter

MickyMouse wrote:

fx8000 wrote:Hi MickyMouse

Your OBV_MA indi draws only part of 21 LWMA (top)

The bottom indi is produced by dragging moving average onto the obv window.

Cheers,
Peter

you are right, sorry about that , i made it and compiled while on chart , and it was showing for me .
Anyways, use the attached one, will update the ma as well.

fx8000 wrote:Your OBV_MA indi draws only part of 21 LWMA (top)

The bottom indi is produced by dragging moving average onto the obv window.

NeoTrader wrote:hi fx8000,

fx8000 wrote:Your OBV_MA indi draws only part of 21 LWMA (top)

The bottom indi is produced by dragging moving average onto the obv window.

I experience the same Problem.

I Think this is a Empty4 Problem...it seems it does not like to use the iMAOnArray on any Indicator Buffer.
I experienced the same Problem when I developed the TMA & MA cross Rule for my Indicator.
Thats why I use a separate array in my code snippet above...

See attachment for a working version...
have also added maxBar Feature and MAMode to select the Mode you want (Default is LWMA)


happy trading,

NeoTrader

---

NeoTrader wrote:hi Steve,

SteveHopwood wrote:I have replaced the OBV trendline with the moving average. There is a problem with this, in that I have not found a way to code calls to the Moving Average indi in such a way that it will return the MA of the OBV indi. Instead, I have replaced the lwma on my OBV with a simple ma, and hand-coded the mo calculation. The result of this calculation appears to be out by a few points, so anybody with more accurate code, please sing out.

The following is not a tested code...i just put it together...to show you the concept...this should work...to combine your obv with an MA.

If you have any question feel free to ask here or via PM.

Code: Select all

double obvArray[];
double maCurrent;

ArrayResize(obvArray, MAPeriod + 1);
ArraySetAsSeries(obvArray, true );

for ( j = 0; j <= MAPeriod + 1; j++ ) {
obvArray[j] = iCustom (your call to get the obv, use j for the shift )

// will give you the current MA value for the obv
maCurrent = iMAOnArray( obvArray, 0, MAPeriod, 0, MAMode, 0 ); 
}

hope this helps.

happy trading,

NeoTrader

SteveHopwood wrote:

NeoTrader wrote:hi Steve,

SteveHopwood wrote:I have replaced the OBV trendline with the moving average. There is a problem with this, in that I have not found a way to code calls to the Moving Average indi in such a way that it will return the MA of the OBV indi. Instead, I have replaced the lwma on my OBV with a simple ma, and hand-coded the mo calculation. The result of this calculation appears to be out by a few points, so anybody with more accurate code, please sing out.

The following is not a tested code...i just put it together...to show you the concept...this should work...to combine your obv with an MA.

If you have any question feel free to ask here or via PM.

Code: Select all

double obvArray[];
double maCurrent;

ArrayResize(obvArray, MAPeriod + 1);
ArraySetAsSeries(obvArray, true );

for ( j = 0; j <= MAPeriod + 1; j++ ) {
obvArray[j] = iCustom (your call to get the obv, use j for the shift )

// will give you the current MA value for the obv
maCurrent = iMAOnArray( obvArray, 0, MAPeriod, 0, MAMode, 0 ); 
}

hope this helps.

happy trading,

NeoTrader

Thanks NT. It works beautifully. I have linked your indi in post 1.

V 1e is in post 1, with NT's code for calculating the lwma of obv.

I have added code to make the ea change the trend line colour to TradedLineColour once it has sent a trade. This is to allow us to leave the ea in charge without worrying that it might close/find a trade has closed, then trade again if conditions are right. If you want this, then change it to the same colour as that of the trading trendline.

I am not sure that the tp/sl calculations are correct yet.

fx8000 wrote:Hi Steve

Shouldn't the AvObv in the following code be replaced by ObvMa ?

//Long trade
//Trendline colour
if (!TradeLong) SendLong = false;
//OBV
if (ObvVal <= AvObv) SendLong = false;

Cheers,
Peter

SteveHopwood wrote:

fx8000 wrote:Hi Steve

Shouldn't the AvObv in the following code be replaced by ObvMa ?

//Long trade
//Trendline colour
if (!TradeLong) SendLong = false;
//OBV
if (ObvVal <= AvObv) SendLong = false;

Cheers,
Peter

Nope.