stevehopwoodforex.com
https://www.stevehopwoodforex.com/phpBB3/
Print view

Fratelli EA by Dragos and magft
https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=77		 Page 3 of 23
Author:  Xfinity [ Thu Nov 24, 2011 2:54 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
Let me know as soon as you updated the first post with a new version, hate that alert ;).

Thanks guys!
Author:  DragosDanescu [ Thu Nov 24, 2011 2:59 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
magft wrote:
DragosDanescu wrote:
Xfinity wrote:Anyway to remove the alerts when the EA modifies an order?

"Fratelli EA v2 EURUSD,M10: EURUSD order modify failed with error(1): no error"

I suggest adding something like the following:

if (stop == 0 && take == 0) return; //nothing to do

Thanks for an excellent job so far! Keep it up!
There are no more alerts on this one, you still keep getting them? The only error can result from this last bloop that Mike is correcting atm.
:? Cant believe i missed that typo!!! I am just updating at the mo, work can wait :lol:

Do you think we need the == or >= in the EarlySLAdjust, i thought that the TS issue was related to this? Also i have changed the send order code to Steve's latest rev which is more reliable at sending orders. I have added risk based lot sizing and a news filter, they were next to each other in the Invictus EA :lol:

Mike
Well, don't know, mine is working really nice, no errors with this:

Code: Select all

         if (EarlySLAdjust)
         {
           if (Ask == NormalizeDouble(OrderOpenPrice() - (Point*EarlySLValue), Digits) &&
              (OrderStopLoss()>OrderOpenPrice()|| OrderStopLoss()==0) && (OrderStopLoss() - OrderOpenPrice() > NormalizeDouble(Point*1.1*EarlySLValue, Digits))) 
            {
               while(IsTradeContextBusy()) Sleep(100);
               result = OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(OrderOpenPrice()+(Point*EarlySLValue), Digits),OrderTakeProfit(),0,CLR_NONE);
And no TS errors at all.
Author:  magft [ Thu Nov 24, 2011 3:15 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
Here is a new version to test, once we are happy it is working ok, i'll update the first post for newcomers.

This version
  • fixes some of the errors that have been experienced - Errors(0) and Error(1) hopefully!
  • added Risk Based Lot sizing
  • added News Filter
As usual let me know the errors you find and i will fix as we go.

You can always set ShowManagementAlerts=false to turn off alerts, you still get comments in Expert Tab.

EDIT: Forgot to add if there are any differences between the EA and the manual trading methodology please flag up and i'll "try" and update accordingly.

Mike
Author:  Xfinity [ Thu Nov 24, 2011 3:23 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
Thanks for the swift reply and new version Mike, will test it asap. If all goes well for a week, I am putting this bot to play a little on the live account ;).
Author:  magft [ Thu Nov 24, 2011 3:30 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
Xfinity wrote:Thanks for the swift reply and new version Mike, will test it asap. If all goes well for a week, I am putting this bot to play a little on the live account ;).
I am planning to go live in new year and i am still not sure which system to invest in. This one has the most promise at the moment, i have only demoed up to now and have seen many systems fail. That is kind of why i started coding so i could adapt systems to my liking or based on others recommendations. I dont really have time to trade due to the day job.

I have just check over on Fratelli thread and post #1493 states no need for both MACDs. I will implement MACD_MM_Buffer into the next major version along with the supertrendmod, i have a version already that does this but triggers were wrong and Dragos version worked so i swapped over to that one. The plan has always been to merge best bits from both but it takes time.

Mike
Author:  DragosDanescu [ Thu Nov 24, 2011 4:15 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
Don't need that MACD_buffer_..... stuff, Mike, I've talked already with the coder, (Mickey Mouse), and we can use the default MACD, as is implemented in my version, it replicates the same output. The reason he put that indi is just for visual and manual trades(up green, down red).

So, if (iMACD(NULL, 0, 12,26,10, PRICE_CLOSE, MODE_MAIN, 1) > 0+buffer*point) MACD = up, reverse for short. I use 2 as buffer, they use 0.5, results are the same.
Author:  dynel14 [ Thu Nov 24, 2011 4:19 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
Thank you so much for your hard work.

Maybe the EA need also market order when price is too fast!?

Also I saw that OOTB the TP is 25 and SL 20. In the pdf it is the opposite or have I misunderstood something? Sure you can edit it, I wanted to mention only...

regards
Author:  DragosDanescu [ Thu Nov 24, 2011 4:22 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
dynel14 wrote:Thank you so much for your hard work.

Maybe the EA need also market order when price is too fast!?

Also I saw that OOTB the TP is 25 and SL 20. In the pdf it is the opposite or have I misunderstood something? Sure you can edit it, I wanted to mention only...

regards
The values are different for sure for each of the 3 pairs. I think those are for EU, as I have tested only this pair in backtester.
Author:  magft [ Thu Nov 24, 2011 4:34 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
DragosDanescu wrote:Don't need that MACD_buffer_..... stuff, Mike, I've talked already with the coder, (Mickey Mouse), and we can use the default MACD, as is implemented in my version, it replicates the same output. The reason he put that indi is just for visual and manual trades(up green, down red).

So, if (iMACD(NULL, 0, 12,26,10, PRICE_CLOSE, MODE_MAIN, 1) > 0+buffer*point) MACD = up, reverse for short. I use 2 as buffer, they use 0.5, results are the same.
I just noticed in the code that it is using MACD_colored and you have already swapped over to iMACD to remove reliance on iCustom calls!!

New Version

Doesnt need MACD_colored.
I have allowed the EMA Cross periods to be changed as latest i read they use 4,15 instead of 2,15.

The SLs and TPs are different for each currency and should be changed as per Fratelli rules, someone care to post a summary to save me looking.

Mike
Author:  magft [ Thu Nov 24, 2011 4:36 pm ]
Post subject:  Re: Fratelli EA by Dragos and magft
dynel14 wrote:Thank you so much for your hard work.

Maybe the EA need also market order when price is too fast!?

Also I saw that OOTB the TP is 25 and SL 20. In the pdf it is the opposite or have I misunderstood something? Sure you can edit it, I wanted to mention only...

regards
I'll look into market orders for next rev, so check min stop level and if price is closer to pending price then switch to market order maybe have a user specifiable buffer?
All times are UTC Page 3 of 23

Powered by phpBB® Forum Software © phpBB Limited