stevehopwoodforex.com
https://www.stevehopwoodforex.com/phpBB3/
Print view

My shell EA code
https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=79		 Page 21 of 23
Author:  DigitalCrypto [ Wed Mar 20, 2019 1:29 pm ]
Post subject:  My shell EA code
Hey Steve,

I am working on an idea that incorporates your latest shell non-grid code. I'm using the "don't trade during rollover" settings. In the AreWeAtRollover() function I found a small problem for me and anyone not running this on Queen's time. I changed this as everything else (trading hours etc) seems to point to local time and this was the only change needed.


Original (Broker Time)

Code: Select all

ltime=TimeHour(TimeCurrent())*60+TimeMinute(TimeCurrent());
Modified (Local Time)

Code: Select all

ltime=TimeHour(TimeLocal())*60+TimeMinute(TimeLocal());
- David
Author:  tomele [ Wed Mar 20, 2019 6:02 pm ]
Post subject:  My shell EA code
High DC.

Basically it is better to use server time here. Rollover happens at server time 00:00 (GMT +2 or +3 depending on whether daylight savings time is in effect or not) for all 5-day-candle brokers (which are nearly all), independent from local time. This way 99% of all users can leave that at default. Using local time would mean every user had to figure out and change this.

Just saying.

Cheers
Thomas
Author:  DigitalCrypto [ Thu Mar 21, 2019 2:07 am ]
Post subject:  My shell EA code
Hey Thomas,

No problem. I had not taken into consideration the "American" offset nonsense.

-David
Author:  DigitalCrypto [ Tue Apr 09, 2019 6:23 am ]
Post subject:  My shell EA code
In CalculateLotAsAmountPerCashDollops()


This doesn't. But is it more or less correct?

Code: Select all

Lot = NormalizeDouble(MathFloor(((DoshDollop / SizeOfDollop) * LotsPerDollopOfCash) * 100) / 100), decimal);
Thanks
- David

How would I know? Gerbils have a greater mathematical understanding than me.

I just played with this:

Code: Select all

   double DoshDollop = 2999;
   double  LotsPerDollopOfCash=0.01;
   double  SizeOfDollop=1000;
   int decimal = 5;
   
   double Lot = NormalizeDouble((MathFloor(((DoshDollop / SizeOfDollop) * LotsPerDollopOfCash) * 100) / 100), decimal);
   Alert(Lot);
It gave the correct value of 0.02. I did have to add an extra left bracket to make it compile.

I will add it to the shells later. Thanks David.

:xm: :rocket:
Author:  SteveHopwood [ Wed Apr 10, 2019 12:12 pm ]
Post subject:  My shell EA code
David, it looks as though I accidentally edited your post instead of quoting then replying. Sorry about that.

You will see that I have adopted your solution in my Desky and SPB posts.

:xm: :rocket:
Author:  DigitalCrypto [ Wed Apr 10, 2019 12:28 pm ]
Post subject:  My shell EA code
That's ok. I'm happy that I could contribute something back.
Author:  DigitalCrypto [ Wed Apr 10, 2019 8:42 pm ]
Post subject:  My shell EA code
I noticed yesterday that the trade management module wasn't firing during the rollover window. I added a call to CountOpenTrades() in the Rollover check of the main loop. This seems to have cured my problem.

Code: Select all

   //Rollover
   if (DisableEaDuringRollover)
   {
      RolloverInProgress = false;
      if (AreWeAtRollover())
      {
         RolloverInProgress = true;
         CountOpenTrades(); //Make sure we manage any open trades during this time.
         DisplayUserFeedback();
         return;
      }//if (AreWeAtRollover)
   }//if (DisableEaDuringRollover)
-David
Author:  SteveHopwood [ Wed Apr 10, 2019 11:16 pm ]
Post subject:  My shell EA code
DigitalCrypto ยป Wed Apr 10, 2019 8:42 pm wrote:I noticed yesterday that the trade management module wasn't firing during the rollover window. I added a call to CountOpenTrades() in the Rollover check of the main loop. This seems to have cured my problem.

Code: Select all

   //Rollover
   if (DisableEaDuringRollover)
   {
      RolloverInProgress = false;
      if (AreWeAtRollover())
      {
         RolloverInProgress = true;
         CountOpenTrades(); //Make sure we manage any open trades during this time.
         DisplayUserFeedback();
         return;
      }//if (AreWeAtRollover)
   }//if (DisableEaDuringRollover)
-David
It isn't a problem David. It is a deliberate strategy. Invoking management at a time when spreads widen dramatically is a bad idea and I strongly advise against doing so.

:xm: :rocket:
Author:  tomele [ Wed Apr 10, 2019 11:33 pm ]
Post subject:  My shell EA code
Hi David.

I put it a bit on the blunt side.

Only a complete idiot does anything during rollover. Even the cheapest bucket shop warns to do so. The market is non-existent then and you will get the weirdest quotes. You may ignore this on a demo account, but you will definitely get slaughtered on a live account.

For years now, every SHF EA does its best to keep you from stepping into this beginners trap. Lots of experience, thinking and coding went into that tiny aspect. You think you are better off ignoring all that?

Well, it is your money.

Thomas
Author:  DigitalCrypto [ Thu Apr 11, 2019 2:46 am ]
Post subject:  My shell EA code
I understand why you guys have it like that. It makes sense. I had expanded that window to several hours to avoid rates and Fed after hours nonsense. Most of the time I am in profit long before rates. It just wasn't firing. I will make a note on my side.

Thanks
David
All times are UTC Page 21 of 23

Powered by phpBB® Forum Software © phpBB Limited