Nice spot. Thanks.House Brick wrote:I think the check for UseZeljko isn't quite what is intended.fmuir wrote:@SteveHopwood,
Would you please take a look at the following code snippet. There are four similar blocks in LookForTradingOpportunities.
The snippet follows:
[/size]Code: Select all
///////////////////////////////////////////////////////////////////////////// //Start of long scalp trade block if (ScalpTrading) if (!IsScalpTradeOpen(symbol))//1 if (symbolValues[cc][iDO] > symbolValues[cc][iDP])//2 // if (iOpen(symbol, PERIOD_M15, 1) < symbolValues[cc][iDO] )//3 // if (bid > symbolValues[cc][iDO] )//3 if (ScalpSlopeTF == 0 || ScalpSlopeVal[cc] >= ScalpBuyLevel)//4 if (IsTradingAllowed(symbol, scalptrade) )//5 if (UseZeljko && BalancedPair(symbol, OP_BUY) )//5 // if (!UseFilter_ADX || CheckADX(symbol, buy))//6 if (TradeLong)//5 // if (!UseFilter_Doji || symbolValues[cc][iDoji] != down)//7 ///////////////// { TradeScalpLong(symbol); return; } ///////////////// //End of long scalp trade block /////////////////////////////////////////////////////////////////////////////
While this snippet looks neat, as you had said, there are inherent problems with it. Each if statment must evaluate to true to get to the next lower if statement. If they evaluate to false, then the potenial trade will fall out of the side and never be placed.
I have experienced a problem with the variable UseZeljko. Trades will be placed if it is set to true (had 3 scalp trades opened). No trades were placed when it is set to false. You would think that if you don't want to use the filter, then it wouldn't have any effect on a trade, but the trade would be placed, if the other conditions were favorable.
I had set UseFilter_ADX and UseFilter_Doji to false. I haven't gotten to the point of validating those if statements, that is why they're disabled. Intuitively you would think that if UseFilter_ADX or UseFilter_Doji were set to false, then the two filters are not used. But, the way that the if statements are constructed, the two filters are used irregardless of the setting of the two variables. Is this is what is wanted? If it is then the two variables should be removed from the if statements.
What do you think? And, please, don't let it affect your mood?! Life is too short, to allow yourself to be negatively affected by something that you love doing!
Regards,
-Frank
[/size]Code: Select all
if (UseZeljko && BalancedPair(symbol, OP_BUY) )//5 #1 // Change to if (!UseZeljko || BalancedPair(symbol, OP_BUY) )//5 #2 // Or written out in full if (!UseZeljko || (UseZeljko && BalancedPair(symbol, OP_BUY)) )//5
In #1 if UseZeljko is meant to be a switch i.e turn off to ignore check, then whenever it is off you won't flow down to the next check or trade because it HAS to be true to pass the test.
In #2 (like in the other checks) if UseZeljko is off - continue, or if it is on then BalancedPair also has to be true to continue.
V 1k with this fixed is in post 1. This is an essential fix.
