Shelley's multi-pair basket trader

Share your 10.x automated traders here.
Post Reply
paulbt38
Trader
Posts: 16
Joined: Wed Nov 16, 2011 1:03 pm

Re: Shelley's multi-pair basket trader

Post by paulbt38 »

I only had two trades this morning and yes the minutes part was ignored by ea. I am assuming their were only two valid trades but haven't looked closely enough as had to leave for work

P
spotdespot
Trader
Posts: 768
Joined: Sun Jan 22, 2012 11:38 pm

Re: Shelley's multi-pair basket trader

Post by spotdespot »

Steve - I think:

Code: Select all

 int h = TimeHour(TimeLocal() );
      int m = TimeMinute(TimeLocal() );
      if (h != BasketSendHour) BasketSent = false;
      if (h == BasketSendHour)
      {
         if (m != BasketSendMinute)
         {
            ReadTable();
            LookForTradingOpportunities();
         }
      }//if (m != BasketSendMinute)
Should read:

Code: Select all

 int h = TimeHour(TimeLocal() );
      int m = TimeMinute(TimeLocal() );
      if (h != BasketSendHour) BasketSent = false;
      if (h == BasketSendHour)
      {
         if (m == BasketSendMinute)
         {
            ReadTable();
            LookForTradingOpportunities();
         }
      }//if (m == BasketSendMinute)
harry45
Trader
Posts: 158
Joined: Fri Nov 18, 2011 11:36 am
Location: Russia,St.Petersburg

Re: Shelley's multi-pair basket trader

Post by harry45 »

I had a basket of 4 sells-CADJPY,CHFJPY,EURJPY,GPPJPY.Adaptive TP 20.Adaptive JS-9.
Enter- London open.Basket was closed at profit in 50 minutes.
It seems to me that adaptive JS works no properly.
Regards
feucht
Trader
Posts: 101
Joined: Thu May 03, 2012 3:16 pm

Re: Shelley's multi-pair basket trader

Post by feucht »

I had an adaptive JS set as well, and I got closed out in profit after about the same 50 minutes. I was so confused as to what was going on by then I was glad to get out ahead.
SWG123
Trader
Posts: 565
Joined: Wed Nov 16, 2011 3:02 pm
Location: Cape Town

Re: Shelley's multi-pair basket trader

Post by SWG123 »

feucht wrote:I had 3 sells as well, though was so confused as to why I had trades at all (and by chance I had 3 I had forgotten to close from Friday that stopped out overnight), I didn't notice how many should have been opened. The joys of trading with one eye open "fresh" from my slumbers...
Why confused? The criteria were met on CHFJPY, EURJPY and GBPJPY.
vivaldi
Trader
Posts: 58
Joined: Thu Feb 02, 2012 12:08 am
Location: Netherlands

Re: Shelley's multi-pair basket trader

Post by vivaldi »

According to the slope display indicator, there should be 10 shorts and 2 longs today. That people had only 3 or 4 trades or 1, as in my case, indicates that something is wrong.
I don't know yet what exactly that may be.
I found out that there are also a lot of problems with the correct historical data in my demo account.
This could also be a cause why some currencies were not triggered today.

Vivaldi
Last edited by vivaldi on Mon May 28, 2012 10:06 am, edited 2 times in total.
User avatar
Zypip
Trader
Posts: 148
Joined: Thu Apr 26, 2012 9:44 am

Re: Shelley's multi-pair basket trader

Post by Zypip »

SWG123 wrote:
feucht wrote:I had 3 sells as well, though was so confused as to why I had trades at all (and by chance I had 3 I had forgotten to close from Friday that stopped out overnight), I didn't notice how many should have been opened. The joys of trading with one eye open "fresh" from my slumbers...
Why confused? The criteria were met on CHFJPY, EURJPY and GBPJPY.

.....not quite. It seems to me that e.g. USDCHF also meet all the criteria for a buy and did not trigger!
feucht
Trader
Posts: 101
Joined: Thu May 03, 2012 3:16 pm

Re: Shelley's multi-pair basket trader

Post by feucht »

SWG123 wrote:
feucht wrote:I had 3 sells as well, though was so confused as to why I had trades at all (and by chance I had 3 I had forgotten to close from Friday that stopped out overnight), I didn't notice how many should have been opened. The joys of trading with one eye open "fresh" from my slumbers...
Why confused? The criteria were met on CHFJPY, EURJPY and GBPJPY.
Because I had just woken up, the 3 trades I thought were still running overnight had actually been stopped out, and I hadn't expected there to be new trades as the Shelley start time hadn't yet been reached.
spotdespot
Trader
Posts: 768
Joined: Sun Jan 22, 2012 11:38 pm

Re: Shelley's multi-pair basket trader

Post by spotdespot »

vivaldi wrote:According to the slope display indicator, there should be 10 shorts and 2 longs today. That people had only 3 or 4 trades or 1, as in my case, indicates that something is wrong.
I don't know ye twhat exactly. I find there are a lot of problems also with the correct histrorical data in the demo accounts.

Vivaldi
The slope also has to be in agreement with the WOH 2x1. I had 3 tests running at different times - one opened 3 trades, one 4 and one 5 - all were correct.
SWG123
Trader
Posts: 565
Joined: Wed Nov 16, 2011 3:02 pm
Location: Cape Town

Re: Shelley's multi-pair basket trader

Post by SWG123 »

feucht wrote:
SWG123 wrote:
feucht wrote:I had 3 sells as well, though was so confused as to why I had trades at all (and by chance I had 3 I had forgotten to close from Friday that stopped out overnight), I didn't notice how many should have been opened. The joys of trading with one eye open "fresh" from my slumbers...
Why confused? The criteria were met on CHFJPY, EURJPY and GBPJPY.
Because I had just woken up, the 3 trades I thought were still running overnight had actually been stopped out, and I hadn't expected there to be new trades as the Shelley start time hadn't yet been reached.
Ah, I understand. :D
Post Reply

Return to “10.x EA forum”