The biggest problem with Crap Custom Abortions (known by the uninitiated as 'custom indicators') is one that lies at the heart of CrapTx. When an EA consults an indicator, the platform loads it into memory, then unloads it again once it has responded to the EA call. This takes time.

An indi has to do a lot of work up front when loaded onto a chart. Most of them are based on some sort of moving average, and the calculation has to be done over every bar on the chart. On subsequent ticks, the indi only has to update its calculation by updating the last x bars actually involved – the reason that, say, a moving average indi does not make your cpu emit blue smoke.

Custom indis typically consist of a number of calls to the regular indicators that ship with Empty4, and manipulate the information thus gleaned according to what the coder requires. An indicator such as AllAverages will make a number of calls to standard indicators. At each tick; each standard indi called by the custom indi is loaded, does all the up-front stuff, used, then unloaded. This takes a long time. Ridiculous, but that is how it works, and is the reason that custom indis such as AA and VQ slow your machine.

And then, we put the EA/Crap Custom Abortion on multiple charts.................................

mobthehop » Wed Nov 12, 2014 10:54 am wrote:Steve, if you allow me one question that I am puzzling over for days now and cant resolve by myself...

Why is "factor" not also in an array or called every time it is needed via PFactor(symbol)?

It is pair defendant and, though it is a fixed value per pair, functionally I do not see a difference to the ATR value of any individual pair (which is kept in an array)

Referring to the latest version:

line 1275 for slippage calculation you indeed call PFactor(symbol), which I believe is the correct way

but everywhere else it is the "simple" factor variable (eg line 748, 784, etc etc)

As so often I probably don't get it - feel free to simply delete this post if I am wrong... but am still curious....

Cheers / Mop

void GetBasics(string symbol)
{
   //Sets up bid, ask, digits, factor for the passed pair
   bid = MarketInfo(symbol, MODE_BID);
   ask = MarketInfo(symbol, MODE_ASK);
   digits = MarketInfo(symbol, MODE_DIGITS);
   factor = PFactor(symbol);
   spread = (ask - bid) * factor;
   LongSwap = MarketInfo(symbol, MODE_SWAPLONG);
   ShortSwap = MarketInfo(symbol, MODE_SWAPSHORT);

     
}//End void GetBasics(string symbol)

[b]mobthehop[/b] wrote:Why is "factor" not also in an array or called every time it is needed via PFactor(symbol)?

   ArrayResize(TradePair, NoOfPairs);
   ArrayResize(AtrVal, NoOfPairs);
   ArrayResize(MaTrend, NoOfPairs);
   ArrayResize(MaVal, NoOfPairs);
   ArrayResize(SecretTradeStatus, NoOfPairs);
   ArrayResize(HistoricStatus, NoOfPairs);
   ArrayResize(PairTrades, NoOfPairs);
   ArrayResize(PairCashUPL, NoOfPairs);
   ArrayResize(PairPipsUPL, NoOfPairs);
   ArrayResize(PairTicketNo, NoOfPairs);
   ArrayResize(PairAverageSpread, NoOfPairs);
   ArrayResize(PairSpreadTotal, NoOfPairs);
   ArrayResize(PairCountedTicks, NoOfPairs);
   ArrayResize(PairOldBid, NoOfPairs);
   ArrayResize(PairRecoveryStatus, NoOfPairs);
   ArrayResize(PairMostRecentTime, NoOfPairs);

struct         structSymbol
{
   string       Name;
   double      PointValue;
   double      BidValue;
   double      AskValue;
   double      ATR;
   ENUM_TREND      MATrend;
   double      MAValue;
   double      SecretStatus;
   int            TradeCount;
   double       CashUPL;
   etc..
   etc...
}; 

structSymbol   Symbols[];

Symbols[0].Name = "EURUSD";
Symbols[0].PointValue = PFactor( "EURUSD" );
Symbols[0].BidValue = MarketInfo( "EURUSD", MODE_BID );
etc..

forextraderaz » 12 Nov 2014, 18:01 wrote:What is everyone's favorite time frame so far to run this on? So far it seems for me the m30 but hour chart seems good also.