SteveHopwood » Thu Aug 10, 2017 8:30 pm wrote:V 1d is in post 1.

I had coded for there to be both buy and sell trades open on the same chart and for Recovery to apply independently to both groups, but not allowed PoS to open a new sell position when there are already buy(s) open and vice versa. This is fixed in 1d.

These are simple DIY fixes.

Do a search for:
if (MarginCheck() )

The line of code straight after that is:
if (OpenTrades == 0)

Comment it out so that it is greyed out, or delete it altogether:
//if (OpenTrades == 0)

Then do a search for:
//Look for a sell.

You will find it high up in void LookForTradingOpportunities(string symbol, int cc). You will also see a block of code starting with this comment:
//Look for a buy.

Copy this over the top of the existing code:

Code: Select all

   //Look for a sell.
   if (MarketSellsCount == 0)//LookForTradingOpportunities() is for the starting trade only
      if (MarketDirection[cc] == shortdirection) //Market must be falling from a PH.
         if (SixthsTradingStatus[cc] == tradableshort)//And must be in the trading area.
            if (TradeShort)//User can control the trading direction
               if (!PositiveSwapOnly[cc] || shortSwap > 0)
                  if (BrokerAllowsHedging || MarketBuysCount == 0)//Either 'hedging' is allowed or there are no market buys open. See note below.
                  {
                     SendShort = true;
                  }//if (BrokerAllowsHedging || MarketBuysCount == 0)//Either 'hedging' ios allowed or there are no market buys open. See note below.
               
   //Look for a buy.
   if (MarketBuysCount == 0)//LookForTradingOpportunities() is for the starting trade only
      if (!PositiveSwapOnly[cc] || longSwap >= 0)   
         if (MarketDirection[cc] == longdirection) //Market must be rising from a PL.
            if (SixthsTradingStatus[cc] == tradablelong)//And must be in the trading area.
               if (TradeLong)//User can control the trading direction
                  if (!PositiveSwapOnly[cc] || longSwap > 0)
                     if (BrokerAllowsHedging || MarketSellsCount == 0)//Either 'hedging' is allowed or there are no market buys open. See note below.
                     {
                        SendLong = true;
                     }//if (BrokerAllowsHedging || MarketBuysCount == 0)//Either 'hedging' ios allowed or there are no market buys open. See note below.

The lines of code added to these blocks are:
if (MarketSellsCount == 0)//LookForTradingOpportunities() is for the starting trade only
and
if (MarketBuysCount == 0)//LookForTradingOpportunities() is for the starting trade only

Now, when a group of, say, buy trades has not been closed out, PoS can take sell trades as well. We profit on the way up and we profit on the way down.

xphoton » Fri Aug 11, 2017 3:13 am wrote:I am using the M1 set with 4pips TP, but sell trades closed before hitting TP.
The reason maybe as bellow:
In LookForTradeClosure,

Code: Select all

   if (OrderType() == OP_SELL || OrderType() == OP_SELLSTOP)
   {
      //TP
      if (bid <= OrderTakeProfit() )
         if (!CloseEnough(OrderTakeProfit(), 0) ) 
            CloseThisTrade = true;
      //SL
      if (bid >= OrderStopLoss() ) 
         if (!CloseEnough(OrderStopLoss(), 0) ) 
            CloseThisTrade = true;

When closing sell trades, the price should be Ask?
I change bid to ask and it works on the way now.

SteveHopwood » Sun Aug 13, 2017 11:14 am wrote:V 1e with the fix we discussed a few posts ago is in post 1. Most of you should have fixed your version yourselves, so consider yourself a wimp if you need the download and are not a new visitor here.

Kopan » Sun Aug 13, 2017 10:29 pm wrote:

SteveHopwood » Sun Aug 13, 2017 11:14 am wrote:V 1e with the fix we discussed a few posts ago is in post 1. Most of you should have fixed your version yourselves, so consider yourself a wimp if you need the download and are not a new visitor here.

FYI: If anyone is still playing with or testing Peaky/Peaky FIFO ---> same DIY fix required for both of those EAs as well.