stevehopwoodforex.com
https://www.stevehopwoodforex.com/phpBB3/
Print view

Holy Graily Bob's Candle Power
https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=5272		 Page 24 of 36
Author:  WorldsEnd [ Fri Oct 13, 2017 11:17 am ]
Post subject:  Holy Graily Bob's Candle Power
tomele » 12 Oct 2017, 23:18 wrote: One question though: How do you send a manual trade if you dont have the chart open? You are confusing me.
Empty4 - Market Watch - Rightclick a Symbol - New Order

Nevermind. I got that point within the manual obviously wrong. Thanks for the update though!
Author:  nanningbob [ Fri Oct 13, 2017 7:44 pm ]
Post subject:  Holy Graily Bob's Candle Power
:yahoo:
Author:  SteveHopwood [ Sat Oct 14, 2017 10:19 am ]
Post subject:  Holy Graily Bob's Candle Power
Some bloops in my code emerged as Thomas coded his dashboard. I shall post updates to the CP trader and both dashboards in time for the markets opening after the weekend, but am hanging on for now in case anything else emerges.

For you Classy people: HolyGrailyBob's Candle power has the wrong mode in void GetPeakyTradeDirection(string symbol, int tf, int bars). We need the highest and lowest close prices to cut out spikes that create irrelevant hilo's. The amended code looks like this - I have left the original as a comment so you can see the difference.

Code: Select all

void GetPeakyTradeDirection(string symbol, int tf, int bars)
{
   //Set PeakyStatus to the direction implied by the chart peak hilo
   
   int Highest = iHighest(symbol, tf, MODE_CLOSE, bars);
   int Lowest = iLowest(symbol, tf, MODE_CLOSE, bars);
   //int Highest = iHighest(symbol, tf, MODE_HIGH, bars);
   //int Lowest = iLowest(symbol, tf, MODE_LOW, bars);
   
   PeakyStatus = longdirection;//Default
   if (Highest < Lowest)
      PeakyStatus = shortdirection;

}//End void GetPeakyTradeDirection(string symbol, int tf, int bars)
Both dashboards have a humungous bloop in the moving average code. This line:
val = GetMa(Symbol(), MaTimeFrame, MaPeriod, MaShift, MaMethod, MaAppliedPrice, 0);

needs replacing with this:
val = GetMa(symbol, MaTimeFrame, MaPeriod, MaShift, MaMethod, MaAppliedPrice, 0);

You will find the offending code easily with a search for this: "val = GetMa(Symbol()"

Thomas has made some cosmetic changes to the display but I do not know where or how. You can always download the update tomorrow and copy the new void DisplayMatrix() function over the top of the existing one.

:xm:
Author:  Gertje [ Sat Oct 14, 2017 1:24 pm ]
Post subject:  Holy Graily Bob's Candle Power
Steve,

Are these changes also necessary in PoS?

Tnx,
Gertjan
Author:  SteveHopwood [ Sat Oct 14, 2017 2:23 pm ]
Post subject:  Holy Graily Bob's Candle Power
Gertje » Sat Oct 14, 2017 1:24 pm wrote:Steve,

Are these changes also necessary in PoS?

Tnx,
Gertjan
No.

:xm:
Author:  SteveHopwood [ Sat Oct 14, 2017 2:27 pm ]
Post subject:  Holy Graily Bob's Candle Power
Here is a block of code that I have added to both dashboards. It is the first block of code in OnTimer():

Code: Select all

   if (!IsTradeAllowed() )
   {
      Comment("                          THIS EXPERT HAS LIVE TRADING DISABLED");
      return;
   }//if (!IsTradeAllowed() )
This forces an EA using a timer to stop its actions when users disable Expert Advisors on the platform.

PoS already has this.

:xm:
Author:  SteveHopwood [ Sat Oct 14, 2017 6:17 pm ]
Post subject:  Holy Graily Bob's Candle Power
An addition to my previous post courtesy of Thomas. :clap: :clap: :clap: Here is his pm explaining it:
In my dashboard I have commented out all Comment() statements (no pun intended). That was to avoid flickering, one of my "cosmetic changes".

So after your new block, there must be code inserted to delete the actual comment if its not empty:

if(ChartGetString(ChartID(),CHART_COMMENT)!="")
Comment("");

Other cosmetic changes: Removed and reordered some inputs in the display section. Minir graphical adjustments in the matrix. Resetting the "chart delete counter" on opening new charts, so every new chart stays open at least for 15 minutes or whatever.
The code block now is:

Code: Select all

   if (!IsTradeAllowed() )
   {
      Comment("                          THIS EXPERT HAS LIVE TRADING DISABLED");
      return;
   }//if (!IsTradeAllowed() )
   
   //Remove the comment now it is no longer needed
   if(ChartGetString(ChartID(),CHART_COMMENT) != "")
      Comment("");
You can see from Thomas' comment though that other changes may be hard to track down. It might be easier just to download the update I shall post tomorrow.

:xm:
Author:  marx64 [ Sun Oct 15, 2017 8:43 am ]
Post subject:  Holy Graily Bob's Candle Power
Using the original version of dashboard I had a situation where bunch of same pair charts (and trades) opened at the same moment. Just for information.
Author:  SteveHopwood [ Sun Oct 15, 2017 7:03 pm ]
Post subject:  Holy Graily Bob's Candle Power
Update versions of CP and the two dashboards are in post 1. They have the improvements/fixes I described in recent posts.

:xm:
Author:  DigitalCrypto [ Sun Oct 15, 2017 11:24 pm ]
Post subject:  Holy Graily Bob's Candle Power
Steve. Thank you for including Bobs 240 code. I use the 7EMA on the Daily to avoid getting destroyed on stacking accounts so it's a simple adjustment for my test.
All times are UTC Page 24 of 36

Powered by phpBB® Forum Software © phpBB Limited