stevehopwoodforex.com • Balls to the Wall, a 1 minute 1 trade EA

Author:

patman [ Mon Oct 01, 2012 6:47 am ]

Post subject:

Re: Version 1h possible code typo

SteveHopwood wrote:
fxjoe2 wrote:Hi All

While visually backtesting earlier today I saw a the yellow line appear on the opposite side of the market than what I would have expected.
I then re-read the thread as well as Paulus's initial explanation at FF.
I then scanned through version 1h and found what I believe might be a typo causing this:

Line # 2514-2516:
if (Fopen > Fclose) CreateHLine(LowLineName, iLow(NULL, PERIOD_H1, 1), STYLE_SOLID, 0,
LineColour);//Market fell
if (Fopen < Fclose) CreateHLine(LowLineName, iHigh(NULL, PERIOD_H1, 1), STYLE_SOLID, 0,
LineColour);//Market rose
I think iLow and iHigh should be swopped.

I made a copy of the code with this change and it seemed to have resolved the position of the yellow line.
I might be wrong, but thought I highlight the posibility.

FXJoe
Hmmmm. Slightly scary that I got this arse end over tip. Nothing new there. Utterly terrifying that it took a newbie here to both spot it and have the courage to point it out. Nice one, Joe; your name is now showing up in a much more fetching colour that it did originally.

Ok guys; either Joe is an idiot or I have confirmed yet again my idiocy status. I have read the code and compared it with the info in the post 1 pdf many times. Doesn't matter how many times I look; Joe appears to be correct.

Fix in post 1; this might give the original Balls a second chance. I shall try it again on demo on Monday.

Thanks Joe. Nice one.

Hi Steve,

I had wondered about this and was setting up to test today

I also figured the if statement

Code: Select all

  if (TimeHour(TimeLocal() ) == MarketOpenHour && ObjectGet(LowLineName, OBJPROP_PRICE1) != iLow(NULL, PERIOD_H1, 1) && !TradingDone && !DisableLineUse)

needed to be changed too.

if OBJPROP_PRICE1 = iHigh then for the first hour the EA keeps re-drawing the line - I think.

Would this work?

Code: Select all

  if (TimeHour(TimeLocal() ) == MarketOpenHour && (ObjectGet(LowLineName, OBJPROP_PRICE1) != iLow(NULL, PERIOD_H1, 1) || ObjectGet(LowLineName, OBJPROP_PRICE1) != iHigh(NULL, PERIOD_H1, 1)) && !TradingDone && !DisableLineUse)

patman

Author:	fxjoe2 [ Sun Sep 30, 2012 1:48 pm ]
Post subject:	Re: Balls to the Wall, a 1 minute 1 trade EA
Glad to contribute some.

Author:	jth [ Mon Oct 01, 2012 6:32 am ]
Post subject:	Re: Balls to the Wall, a 1 minute 1 trade EA
Hi Guys, Firstly Everyone have a good trading week. OK last friday was a very bad looking day for the basket system by mid afternoon. At this point i had lost 2 piar with quite big losses at that, then the market started to turn. In the last 5 minutes before the market close on friday the system was $-400.00 dollars short from BE for the day. I decided to leave the basket going for sunday open. I opened the Empty4 on sunday before market open and see what would happen, the basket hit TP 5 seconds after open which gave me a small total profit from friday of $383.80 But it's still a profit (see attached report.) Anyway i am still waiting for London open Regards JTH will report what happens win or lose.

Author:	cuzgeorge [ Mon Oct 01, 2012 8:30 am ]
Post subject:	Re: Balls to the Wall, a 1 minute 1 trade EA
Hi Steve, all, i'm getting this error on the new Wolfie and Balls v1h. i believe it has something to do with Balud's time software, but cant see whats wrong. Steve, enlighten us please; the part refers to two different trading time names, please refer to pic with highlighted code. I cant get rid of the blank alert box that keeps coming up. ive had no trades on Wolfie yet, but v1g is working fine and v1i has had a win from this morning, albeit a small BE win. regards Cuzgeorge EDIT; ive tried removing the code and recompiling , but it still comes up., ive also tried changing times and also removing times altogether. same issue.

Author:	jboy [ Mon Oct 01, 2012 8:54 am ]
Post subject:	Re: Balls to the Wall, a 1 minute 1 trade EA
jth, what leverage are you using on your demo? I suspect it is quite high because in the US brokers, it is only 1:50 leverage. I don't see how one can open all 8 pairs at the same time with 1:50 leverage, I don't think the broker will allow the cumulative lots of 8 pairs. jboy

Author:	cuzgeorge [ Mon Oct 01, 2012 9:06 am ]
Post subject:	Re: Balls to the Wall, a 1 minute 1 trade EA
Hey Jboy, if i may, a leverage of 1:50 is far too low for this kind of EA. If you can try to get a higher leverage crim. also, you can turn down the risk dramatically or adjust to fixed lots to avoid that problem. It is as you suspect a crim thing, so hope this helps. regards cuz

stevehopwoodforex.com https://www.stevehopwoodforex.com/phpBB3/ Print view

Balls to the Wall, a 1 minute 1 trade EA https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=792	Page 24 of 36

Author:	SteveHopwood [ Sat Sep 29, 2012 9:55 pm ]
Post subject:	Re: Version 1h possible code typo
fxjoe2 wrote:Hi All While visually backtesting earlier today I saw a the yellow line appear on the opposite side of the market than what I would have expected. I then re-read the thread as well as Paulus's initial explanation at FF. I then scanned through version 1h and found what I believe might be a typo causing this: Line # 2514-2516: if (Fopen > Fclose) CreateHLine(LowLineName, iLow(NULL, PERIOD_H1, 1), STYLE_SOLID, 0, LineColour);//Market fell if (Fopen < Fclose) CreateHLine(LowLineName, iHigh(NULL, PERIOD_H1, 1), STYLE_SOLID, 0, LineColour);//Market rose I think iLow and iHigh should be swopped. I made a copy of the code with this change and it seemed to have resolved the position of the yellow line. I might be wrong, but thought I highlight the posibility. FXJoe Hmmmm. Slightly scary that I got this arse end over tip. Nothing new there. Utterly terrifying that it took a newbie here to both spot it and have the courage to point it out. Nice one, Joe; your name is now showing up in a much more fetching colour that it did originally. Ok guys; either Joe is an idiot or I have confirmed yet again my idiocy status. I have read the code and compared it with the info in the post 1 pdf many times. Doesn't matter how many times I look; Joe appears to be correct. Fix in post 1; this might give the original Balls a second chance. I shall try it again on demo on Monday. Thanks Joe. Nice one.

Author:	wolfeman [ Mon Oct 01, 2012 5:05 am ]
Post subject:	Re: Version 1h possible code typo
I could be wrong, but this might explain why the trades using slope were all closing immediately. I must give it a try... SteveHopwood wrote: fxjoe2 wrote:Hi All While visually backtesting earlier today I saw a the yellow line appear on the opposite side of the market than what I would have expected. I then re-read the thread as well as Paulus's initial explanation at FF. I then scanned through version 1h and found what I believe might be a typo causing this: Line # 2514-2516: if (Fopen > Fclose) CreateHLine(LowLineName, iLow(NULL, PERIOD_H1, 1), STYLE_SOLID, 0, LineColour);//Market fell if (Fopen < Fclose) CreateHLine(LowLineName, iHigh(NULL, PERIOD_H1, 1), STYLE_SOLID, 0, LineColour);//Market rose I think iLow and iHigh should be swopped. I made a copy of the code with this change and it seemed to have resolved the position of the yellow line. I might be wrong, but thought I highlight the posibility. FXJoe Hmmmm. Slightly scary that I got this arse end over tip. Nothing new there. Utterly terrifying that it took a newbie here to both spot it and have the courage to point it out. Nice one, Joe; your name is now showing up in a much more fetching colour that it did originally. Ok guys; either Joe is an idiot or I have confirmed yet again my idiocy status. I have read the code and compared it with the info in the post 1 pdf many times. Doesn't matter how many times I look; Joe appears to be correct. Fix in post 1; this might give the original Balls a second chance. I shall try it again on demo on Monday. Thanks Joe. Nice one.

Author:	jboy [ Mon Oct 01, 2012 9:09 am ]
Post subject:	Re: Balls to the Wall, a 1 minute 1 trade EA
Yes, I think you are right. I will need to dial down the risk dramatically to run this EA in the US broker. I will probably need to cut down the risk to 0.5% instead of 5%. Shame. It won't really feel like Balls to the Wall. LOL. The CTFC has neutered the balls of US traders.

Author:	jth [ Mon Oct 01, 2012 9:19 am ]
Post subject:	Re: Balls to the Wall, a 1 minute 1 trade EA
Hi Guys, Boooooooom Yeah Basket TP was just hit: for $2479.74 = 10% of capital (Detailed report Attached) 5 pairs were triggered. Time basket TP reached is: 09;59 local time (11;59 criminal time) Will be waiting for NY open to setup trades again. Regards JTH jboy wrote:jth, what leverage are you using on your demo? The EA is generating some huge lots on my criminal (mbtrading) since it says I don't have enough money to open the trades. I'm in the US, so the leverage is at 1:50, perhaps that is the reason...but I don't think that is. I will dig into the code to see if I can fix this. I think I saw someone else who had this problem earlier in the thread. but many others do not have this problem at all, so it may be criminal specific. jboy Hi jboy, i Think to reduce the lot size you need to change the Riskpercent from 5 to say about 2. then your lot size should change. Give that a try. JTH

All times are UTC	Page 24 of 36
Powered by phpBB® Forum Software © phpBB Limited