Balls to the Wall, a 1 minute 1 trade EA

[patman]

Nice one Pat. Thanks. I reckon it needs to be
if (TimeHour(TimeLocal() ) == MarketOpenHour && (ObjectGet(LowLineName, OBJPROP_PRICE1) != iLow(NULL, PERIOD_H1, 1) && ObjectGet(LowLineName, OBJPROP_PRICE1) != iHigh(NULL, PERIOD_H1, 1)) && !TradingDone && !DisableLineUse)

otherwise the condition will always fail because it is always != to one of the conditions.

I have made this change and am catching up with the tread before posting the update.

Hi Steve,

OK - I have a problem with AND and OR. I agree with what you said in the post.
But that's not what is in 1j

currently in 1j

Code: Select all

if (TimeHour(TimeLocal() ) == MarketOpenHour && (ObjectGet(LowLineName, OBJPROP_PRICE1) != iLow(NULL, PERIOD_H1, 1) && ObjectGet(LowLineName, OBJPROP_PRICE1) && !TradingDone && !DisableLineUse)

should be?

if (TimeHour(TimeLocal() ) == MarketOpenHour && (ObjectGet(LowLineName, OBJPROP_PRICE1) != iLow(NULL, PERIOD_H1, 1) && (ObjectGet(LowLineName, OBJPROP_PRICE1) != iHigh(NULL, PERIOD_H1, 1)) && !TradingDone && !DisableLineUse)

maybe?

pat

[SteveHopwood]

Yep. Thanks Pat. You might get your AND OR confused, but I create endless confusion with my copy/past/forget-to-edit bloops.

Ik in post 1, with Pat's fix to my balls up of his fix. Those of you who know how, it is obvious from the previous post what needs adding. Can someone check that I have copy-pasted it correctly this time, please.

[patman]

Steve

Yea - looks fine now

BTW
I was scrolling through 1j and

bool IsThisPairTradable()

scrolled by. I remembered something i'd seen elsewhere

(Multibob http://www.stevehopwoodforex.com/phpBB3 ... 411#p24411)

the line

Code: Select all

   
if (c1open == 1 && c2open == 1) 

It was suggested to change this to

Code: Select all

   
if (c1open > 1 && c2open > 1) 

Maybe this does not apply here


Apologies if not!


pat

[cuzgeorge]

Hi all,
just a quick mention of what might be related to the time issue above. i havent updated to k yet, but this position was taken at the wrong time. Settings show my time is set to 11. criminal time is at 14 odd and my local computer time is at 16.
i like the position though, its just not supposed to be at this time.

highlighted are the times mentioned, only my computer time is not showing.
hope this helps, will browse myself a bit later and see if anything shows.
regards
cuz

[patman]

Hi all,
just a quick mention of what might be related to the time issue above. i havent updated to k yet, but this position was taken at the wrong time. Settings show my time is set to 11. criminal time is at 14 odd and my local computer time is at 16.
i like the position though, its just not supposed to be at this time.

highlighted are the times mentioned, only my computer time is not showing.
hope this helps, will browse myself a bit later and see if anything shows.
regards
cuz

Hi cuzgeorge,

My understanding and experience of balls is that (in your case) at 11 on your computer the EA made a horizontal line.
Then at 16 on your computer price went above the line and the indicator went from dark red to light red and Stocastic <50 so BUY
Order is placed
Then line is deleted and EA is doing "bugger all" until 11 tomorrow

At least that's what I think

pat

[wolfeman]

hi george, it could be I missed something, but your chart comments say "24 Hr trading". Steve is gonna bitch-slap you for that.

Hi all,
just a quick mention of what might be related to the time issue above. i havent updated to k yet, but this position was taken at the wrong time. Settings show my time is set to 11. criminal time is at 14 odd and my local computer time is at 16.
i like the position though, its just not supposed to be at this time.

highlighted are the times mentioned, only my computer time is not showing.
hope this helps, will browse myself a bit later and see if anything shows.
regards
cuz

[cuzgeorge]

Hi all,
just a quick mention of what might be related to the time issue above. i havent updated to k yet, but this position was taken at the wrong time. Settings show my time is set to 11. criminal time is at 14 odd and my local computer time is at 16.
i like the position though, its just not supposed to be at this time.

highlighted are the times mentioned, only my computer time is not showing.
hope this helps, will browse myself a bit later and see if anything shows.
regards
cuz

Hi cuzgeorge,

My understanding and experience of balls is that (in your case) at 11 on your computer the EA made a horizontal line.
Then at 16 on your computer price went above the line and the indicator went from dark red to light red and Stocastic <50 so BUY
Order is placed
Then line is deleted and EA is doing "bugger all" until 11 tomorrow

At least that's what I think

pat

Yep, i gotta be more carefull with these pics i post

You're right, theres nothing in the code to mention the line gets removed after 'x' amount of time, i think unless i change the 24hr trading option and stop Balls from looking for that position.
food for thought. Thanks Wolfie.
it turns out the buy was good, now looking to see if i'll manually close it out.

I must say, JTH's method is far easier to trade than watching all the charts to see when to take the jump out. I would prefer to run JTH's system or look to leave Balls completely on it's own rather than manually trade. Very difficult to keep coming back to check all the charts because there are many factors to consider before jumping for that move.
cheers,
cuz

[johnlucas]

Hi everyone,

glad to have joined this forum!
I am backtesting this EA on 2 demo platforms.
On both it happens a strange occurrence: the EA, in ST, starts "well" (takes 3 trades), then it stops working (no more trades taken).
In the journal tab I see a "zero divide" error.

Has anyone experienced this, too?
Is there a way to fix it?

thank you in advance,

John.

[alex_forex]

Did you use the HistoricalData script ?

[johnlucas]

Yes I did, but still receiving the same error...