lvdfx888 wrote:

phil_trade wrote:

lvdfx888 wrote:Thanks Paul for the new version.

Loaded v1.1.8 with 10.2a enabled, 3 trades were opened even there's no DP cross. Although it's in the right direction with profits , but too far from DP.

ac pivotshort.gif

Thanks,
Ron

It was taken at 0.97211 2012.10.02 04:01 so +65 pips now. When did you run 10.2a ?

Hi Phil,

I run the new version after 2 (M15) candles move. AUDCHF was opened around 63 PIPS from DP with TP set at 10 PIPS from open price, and TP reached and trade is now closed.

Capture.JPG

Thanks
Ron

spyderman wrote:

lucklogic wrote:Could someone explain what the, if activated, correlation modules within the EA are trying do ???

Helping you to avoid trading too many pairs with similar price movement. For example Eur/Usd and Gbp/Usd are typically highly correlated. Trading one position in each would effectively be trading two positions in either one. Correlation is referenced by a range of numeric value from -99 (high reverse correlation) to 99 (high positive correlation) The EA allows you to set at what point you want it to filter your trade pairs for correlation purposes.

garyfritz wrote:Running 10.2a, MB suddenly started spitting out error 134's ("Not enough money") on every tick. It had just finally worked its basket into positive territory. Plenty of money in the account.

lucklogic wrote:

Code: Select all

bool sendSingleTrade( int symbolIndex, int type, string comment, double lotSize, double price, int magicNumber )
{
   if ( useCorrFilter )
   {
      if ( isCorrelated( symbolNames[symbolIndex] ) ) return (true);
   }

..............................................
   

Is this not incorrect

If using the useCorrFilter, the EA is assessing if a prospective order is highly correlated to an existing order BUT if the result is true (that it is highly correlated, so is likely to move in exactly the same direction) THE TRADE is being allowed rather than refused

The result of the argument - if ( isCorrelated( symbolNames[symbolIndex] ) ) return (true);
should return (false) because we do not in affect want to repeat the trade twice

dietcoke wrote:

lucklogic wrote:

Code: Select all

bool sendSingleTrade( int symbolIndex, int type, string comment, double lotSize, double price, int magicNumber )
{
   if ( useCorrFilter )
   {
      if ( isCorrelated( symbolNames[symbolIndex] ) ) return (true);
   }

..............................................
   

Is this not incorrect

If using the useCorrFilter, the EA is assessing if a prospective order is highly correlated to an existing order BUT if the result is true (that it is highly correlated, so is likely to move in exactly the same direction) THE TRADE is being allowed rather than refused

The result of the argument - if ( isCorrelated( symbolNames[symbolIndex] ) ) return (true);
should return (false) because we do not in affect want to repeat the trade twice

The return is for the whole function. It is just saying the sendtrade function completed successfully. No trade is opened here.

bool sendSingleTrade( int symbolIndex, int type, string comment, double lotSize, double price, int magicNumber )
{
   if ( useCorrFilter )
   {
      if ( isCorrelated( symbolNames[symbolIndex] ) ) return (true);    // looks wrong and is in the wronr place 
	  
   }
   
   int digits = doubleToInt( MarketInfo( symbolNames[symbolIndex], MODE_DIGITS ) );

   int slippage = 10;
   if ( digits == 3 || digits == 5 ) slippage = 100;

   color col = Red;
   if ( type == OP_BUY || type == OP_BUYSTOP ) col = Green;

   int expiry = 0;

   for ( int i = 0; i < 10; i++ )
   {
      for ( int j = 0; j < 10 && IsTradeContextBusy(); j++ ) Sleep( 100 );

      RefreshRates();
      if ( type == OP_BUY ) price = NormalizeDouble( MarketInfo( symbolNames[symbolIndex], MODE_ASK ), digits );
      if ( type == OP_SELL ) price = NormalizeDouble( MarketInfo( symbolNames[symbolIndex], MODE_BID ), digits );

      if ( DEBUG ) Print( symbolNames[symbolIndex], " SEND ORDER: ", type, ", ", lotSize, ", ", price );
      int ticket = OrderSend( symbolNames[symbolIndex], type, lotSize, price, slippage, 0, 0, comment, magicNumber, expiry, col);
      if ( ticket > -1 )
      {
         if ( OrderSelect( ticket, SELECT_BY_TICKET ) )
         {
            double take = calculateTakeProfit( symbolNames[symbolIndex], OrderType() );
            double stop = calculateStopLoss( symbolNames[symbolIndex], OrderType() );
            if ( DEBUG ) Print( symbolNames[symbolIndex], " MODIFY ORDER: ", ticket, ", ", stop, ", ", take );
            modifyOrder( ticket, stop, take );
         }
         else
         {
            Alert( symbolNames[symbolIndex], " ", WindowExpertName(), " select order, ticket ", ticket, " failed." );
            Print( symbolNames[symbolIndex], " ", WindowExpertName(), " select order, ticket ", ticket, " failed." );
            return ( false );
         }
      }

      if ( ticket > -1 ) break;
      
      if ( i == 9 ) return ( false );

      // Error trapping
      if ( ticket < 0 )
      {
         string stype;
         if ( type == OP_BUY ) stype = "OP_BUY";
         if ( type == OP_SELL ) stype = "OP_SELL";
         if ( type == OP_BUYLIMIT ) stype = "OP_BUYLIMIT";
         if ( type == OP_SELLLIMIT ) stype = "OP_SELLLIMIT";
         if ( type == OP_BUYSTOP ) stype = "OP_BUYSTOP";
         if ( type == OP_SELLSTOP ) stype = "OP_SELLSTOP";
         int err = GetLastError();
         Alert( symbolNames[symbolIndex], " ", WindowExpertName(), " ", stype," order send failed with error(",err,"): ", ErrorDescription( err ) );
         Print( symbolNames[symbolIndex], " ", WindowExpertName(), " ", stype," order send failed with error(",err,"): ", ErrorDescription( err ) );
         return ( false );
      }
   }

   return ( true );
}

dietcoke wrote:

Code: Select all

if ( isCorrelated( symbolNames[symbolIndex] ) ) return (true);

To me that says, If the pair to be traded is correlated then return without sending an order