garyfritz wrote:

spotdespot wrote:I actually think that the issue is with the indicators themselves - or more accurately Empty4 and how it deals with indis. I think (Baluda/Steve/coders please advise) that indicators do whatever it is they do every tick (and presumably cannot do their thing every bar close like an EA can).

That's right. Empty4 calls the start() function on every tick. Most indicators (including the 10.5 CSS indicators) do all their calculations and displays on every tick.

But it's easy to fix. Just add this at the beginning of start():

Code: Select all

datetime LastUpdate = 0;
if (TimeCurrent() - LastUpdate < 10) return(0);
LastUpdate = TimeCurrent();

(Not tested since the markets are closed, but it's pretty trivial.)

That will update every 10 seconds. Change the 10 to 60 if you want it to update every minute.

I have 16 GB and I never get close to using it all and each Empty4 terminal maxes out at around 8% cpu when it is bogged down.

More likely it's 12%. You have a quad-core CPU, with each core having two "threads." So your CPU power gets divided into 8 chunks. 1/8 of 100% is 12.5%. When one CPU is spinning as fast as it can, due to a loop or a hang in Empty4, it only consumes 12.5% of your total CPU.

garyfritz wrote:Yes Shelley, you've got it in the right place -- as does Dave in the zip file above. Dave, you might want to include the 10.5 CSS H4 variant too...

garyfritz wrote:Yes Shelley, you've got it in the right place -- as does Dave in the zip file above. Dave, you might want to include the 10.5 CSS H4 variant too...

fxozgirl wrote:

garyfritz wrote: But it's easy to fix. Just add this at the beginning of start():

Code: Select all

datetime LastUpdate = 0;
if (TimeCurrent() - LastUpdate < 10) return(0);
LastUpdate = TimeCurrent();

(Not tested since the markets are closed, but it's pretty trivial.)

That will update every 10 seconds. Change the 10 to 60 if you want it to update every minute.

Gary, can you please confirm I have placed your piece of code in the correct location?

thanks

Shelley

Code: Select all

//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
{
  datetime LastUpdate = 0;
   if (TimeCurrent() - LastUpdate < 10) return(0);
   LastUpdate = TimeCurrent();
   int limit;
   int counted_bars = IndicatorCounted();

   if (counted_bars < 0)  return(-1);
   if (counted_bars > 0)  counted_bars -= 10;

   limit = Bars - counted_bars;

   if ( maxBars > 0 )
   {
      limit = MathMin (maxBars, limit);   
   }   

   int i;
   
   for ( i = 0; i < CURRENCYCOUNT; i++ )
   {
      SetIndexStyle( i, DRAW_LINE, STYLE_SOLID, 2, currencyColors[i] );
   }   

   RefreshRates();
   
   for ( i = limit; i >= 0; i-- )
   {
      int index;
      double diff = 0.0;
      
      ArrayInitialize(currencyValues, 0.0);

mpetersrx7 wrote:Shelley.
I don't think this will work because you need to move
datetime LastUpdate = 0;
above the function so it gets defined globally. Otherwise, everytime start is called it gets reset to 0.

datetime LastUpdate;
int start()
{
   if (TimeCurrent() - LastUpdate < 10) return(0);
   LastUpdate = TimeCurrent();