garyfritz wrote:

mpetersrx7 wrote:Shelley.
I don't think this will work because you need to move
datetime LastUpdate = 0;
above the function so it gets defined globally. Otherwise, everytime start is called it gets reset to 0.

GACK!! You are absolutely right, Mark. Either move that line outside the function, or declare it as "static datetime". Moving it outside the function is probably simpler/better.

Sorry about that folks!

I'm trying to test out the code to make sure I didn't screw up again, but for some reason my Empty4 is not behaving. I'll test it when I get things working...

EDIT: Seems to work fine. Just put the datetime declaration before the start() function:

Code: Select all

datetime LastUpdate;
int start()
{
   if (TimeCurrent() - LastUpdate < 10) return(0);
   LastUpdate = TimeCurrent();

//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+

datetime LastUpdate;

int start()
{
   if (TimeCurrent() - LastUpdate < 60) return(0);
   LastUpdate = TimeCurrent();
   
   int limit;
   int counted_bars = IndicatorCounted();

static datetime oldH1BarTime;
if ( oldH1BarTime != iTime( NULL, PERIOD_H1, 0 ) )
{
   // Do something
}
oldH1BarTime =  iTime( NULL, PERIOD_H1, 0 ); 

• All code is together in the same place
• Test variable is declared static, it does not get lost
• Period to test for is quickly spotted (and changed)

Baluda wrote:FWIW, this is what I do:

Code: Select all

static datetime oldH1BarTime;
if ( oldH1BarTime != iTime( NULL, PERIOD_H1, 0 ) )
{
   // Do something
}
oldH1BarTime =  iTime( NULL, PERIOD_H1, 0 ); 

Benefits:

• All code is together in the same place
• Test variable is declared static, it does not get lost
• Period to test for is quickly spotted (and changed)

Happy coding!

Paul

SWG123 wrote:Paul, for those of us who think a function is a wedding reception...where must we place this code?

static datetime oldM5BarTime;
if ( oldM5BarTime != iTime( NULL, PERIOD_M5, 0 ) )
{
   SomeVariable = CallSomeOffHandFunction(With, Some, Variables);
}
oldM5BarTime =  iTime( NULL, PERIOD_M5, 0 ); 

garyfritz wrote:

mpetersrx7 wrote:Shelley.
I don't think this will work because you need to move
datetime LastUpdate = 0;
above the function so it gets defined globally. Otherwise, everytime start is called it gets reset to 0.

GACK!! You are absolutely right, Mark. Either move that line outside the function, or declare it as "static datetime". Moving it outside the function is probably simpler/better.

Sorry about that folks!

I'm trying to test out the code to make sure I didn't screw up again, but for some reason my Empty4 is not behaving. I'll test it when I get things working...

EDIT: Seems to work fine. Just put the datetime declaration before the start() function:

Code: Select all

datetime LastUpdate;
int start()
{
   if (TimeCurrent() - LastUpdate < 10) return(0);
   LastUpdate = TimeCurrent();

Baluda wrote:

SWG123 wrote:Paul, for those of us who think a function is a wedding reception...where must we place this code?

Anywhere, that is the beauty!

Just put it somewhere in your start() (or any other) function, set the period you want to use, type your once-in-a-period code and off you go.

Example, read some variable once per 5 minutes:

Code: Select all

static datetime oldM5BarTime;
if ( oldM5BarTime != iTime( NULL, PERIOD_M5, 0 ) )
{
   SomeVariable = CallSomeOffHandFunction(With, Some, Variables);
}
oldM5BarTime =  iTime( NULL, PERIOD_M5, 0 ); 

Paul

spotdespot wrote:Here are some options for people. I have made the change in all the indis that 10.4/10.5 uses that use TMA - I think! If you want to to directly replace what you have then you will need to rename them and overwrite & restart Empty4. I suggest you check that they work first - as Gary mentioned they can't be tested, in terms of effect, with the market closed.

Cheers,
Dave.

EDIT: Updated to add the 10.5 CSS H4 indi
EDIT: - Updated to move the LastUpdate as per the posts below. 24/06/2013 08:35 GMT