Nanningbob 10.2 Autotrader's new home

[Riddermark]

I'm getting an error here. It just keeps repeating for hours. Thoughts?

2012.09.16 12:01:53 Nanningbob 10.2 autotrader CHFJPY,H4: open #46894841 buy 1.00 CHFJPY at 84.536 ok
2012.09.16 12:01:54 Nanningbob 10.2 autotrader CHFJPY,H4: modify #46894841 buy 1.00 CHFJPY at 84.536 sl: 82.536 tp: 85.536 ok
2012.09.16 12:02:15 Nanningbob 10.2 autotrader EURCHF,H4: EURCHF AdjustStopLoss() stop = 1.19606 OrderStopLoss()= 1.21231
2012.09.16 12:02:39 Nanningbob 10.2 autotrader EURCHF,H4: EURCHF AdjustStopLoss() stop = 1.19606 OrderStopLoss()= 1.21231
2012.09.16 12:02:36 Nanningbob 10.2 autotrader EURCHF,H4: EURCHF AdjustStopLoss() stop = 1.19606 OrderStopLoss()= 1.21231
2012.09.16 12:02:31 Nanningbob 10.2 autotrader EURCHF,H4: EURCHF AdjustStopLoss() stop = 1.19606 OrderStopLoss()= 1.21231
2012.09.16 12:02:29 Nanningbob 10.2 autotrader EURCHF,H4: EURCHF AdjustStopLoss() stop = 1.19606 OrderStopLoss()= 1.21231
2012.09.16 12:02:21 Nanningbob 10.2 autotrader EURCHF,H4: EURCHF AdjustStopLoss() stop = 1.19606 OrderStopLoss()= 1.21231
2012.09.16 12:02:18 Nanningbob 10.2 autotrader EURCHF,H4: EURCHF AdjustStopLoss() stop = 1.19606 OrderStopLoss()= 1.21231
2012.09.16 12:02:18 Nanningbob 10.2 autotrader EURCHF,H4: EURCHF AdjustStopLoss() stop = 1.19606 OrderStopLoss()= 1.21231

[pcorneli]

I was looking into the source of 10.3 (in message 1 still called 10.2).

My humble question is , if you want to use a previous bar , should not be it shift + 1 ?

int weekYesterday = TimeDayOfWeek( iTime( NULL, tf, shift - 1 ) );

Btw great site , great system , great program.

pc

[fluegel]

I'm getting an error here. It just keeps repeating for hours. Thoughts?

2012.09.16 12:01:53 Nanningbob 10.2 autotrader CHFJPY,H4: open #46894841 buy 1.00 CHFJPY at 84.536 ok
2012.09.16 12:01:54 Nanningbob 10.2 autotrader CHFJPY,H4: modify #46894841 buy 1.00 CHFJPY at 84.536 sl: 82.536 tp: 85.536 ok
2012.09.16 12:02:15 Nanningbob 10.2 autotrader EURCHF,H4: EURCHF AdjustStopLoss() stop = 1.19606 OrderStopLoss()= 1.21231
2012.09.16 12:02:39 Nanningbob 10.2 autotrader EURCHF,H4: EURCHF AdjustStopLoss() stop = 1.19606 OrderStopLoss()= 1.21231
2012.09.16 12:02:36 Nanningbob 10.2 autotrader EURCHF,H4: EURCHF AdjustStopLoss() stop = 1.19606 OrderStopLoss()= 1.21231
2012.09.16 12:02:31 Nanningbob 10.2 autotrader EURCHF,H4: EURCHF AdjustStopLoss() stop = 1.19606 OrderStopLoss()= 1.21231
2012.09.16 12:02:29 Nanningbob 10.2 autotrader EURCHF,H4: EURCHF AdjustStopLoss() stop = 1.19606 OrderStopLoss()= 1.21231
2012.09.16 12:02:21 Nanningbob 10.2 autotrader EURCHF,H4: EURCHF AdjustStopLoss() stop = 1.19606 OrderStopLoss()= 1.21231
2012.09.16 12:02:18 Nanningbob 10.2 autotrader EURCHF,H4: EURCHF AdjustStopLoss() stop = 1.19606 OrderStopLoss()= 1.21231
2012.09.16 12:02:18 Nanningbob 10.2 autotrader EURCHF,H4: EURCHF AdjustStopLoss() stop = 1.19606 OrderStopLoss()= 1.21231

Hi,
Last week, I had a similar problem, too (with version 1.2). In my case, EA first took a D1 trend
trade on EURCAD, and after a short while a D1/H4 trend trade on the same currency pair.
Then I noticed that EA was trying to modify SL of the D1/H4 trend trade from the original one
to the SL of the D1 trend trade and vice versa again and again.

I couldn't take a SS of the error message as my VPS had trouble and needed rebooting.
But I think there is some erroneous loop in the code...

[Baluda]

My humble question is , if you want to use a previous bar , should not be it shift + 1 ?

int weekYesterday = TimeDayOfWeek( iTime( NULL, tf, shift - 1 ) );

PC,

How right you are. And that is my code and my bad. Change it yourself until Al3xx can provide an update.

Al3xx, did you get this?

Paul

[forex.rapheal]

Hi Riddermark,
excellent result. do you use the EA for all fx pairs? (i.e. you open 32 tab in a single Empty4) it seems it takes a lot of memeory. Also, did you turn on the "partial close" function?
regards,

[MurphyMan]

My word, this demo is going well. After two weeks, V1.2 has taken about 15 trades and closed out 11 of them. I started with a $10,000 account. One trade closed with a $412 loss, but everything else has been in the green.

Total equity gain as of this moment, 7%.

I'll load V1.3 today.

Pretty much OOTB, but I changed the standard deviation for the bollinger bands to 1.0, but I haven't looked closely to see if it had any effect.

Sam

[matt_32]

Does anyone use thiw EA together with Steve's MPTM for global control (ie TP - SL control etc)?

Matt

[Lifesys]

Hi Alex
I have not really trialled this EA yet as it seems too unstable, however looking through the code, one contribution I might make it to render the PartClose section actually operable.
I use fractional PartClose in MPTM for all my trading & have discussed same with Steve H.
It can work in this EA but as is, rather pointless to have PartCloseEnabled = false, with CloseLots =0.5 & PreserveLots =0.5 when Lots default is 0.06 (or anything) bearing no relation to the CloseLots values.
Using fractional PartClose one can set the Lots higher and watch partial close, break even & almost all trades close in profit. [Close_LotsFraction can be any value 0 - 1.]

In declaration section change -

Code: Select all

extern string  pcbe  ="PartClose settings can be used in";
extern string  pcbe1 ="conjunction with Breakeven settings";
extern bool    PartCloseEnabled    = true;
//extern double  Close_Lots           = 0.5;
//extern double  Preserve_Lots       = 0.5;
extern double  Close_LotsFraction = 0.4; // 40% closes, 60% continues after B/E
       double  Close_Lots, Preserve_Lots;

then in init() procedure replace

Code: Select all

	   
/* 
   //check Partial close parameters
   if (PartCloseEnabled == true)
   {
      if (Lot < Close_Lots + Preserve_Lots || Lot < MarketInfo(Symbol(), MODE_MINLOT) + Close_Lots )
      {
         Alert(Symbol()+" PartCloseEnabled is disabled because Lot < Close_Lots + Preserve_Lots or Lot < MarketInfo(Symbol(), MODE_MINLOT) + Close_Lots !");
         PartCloseEnabled = false;
      }//if (Lot < Close_Lots + Preserve_Lots || Lot < MarketInfo(Symbol(), MODE_MINLOT) + Close_Lots 
   }//if (PartCloseEnabled == true)
*/    
// replace with
   //check Partial close parameters
   if (PartCloseEnabled == true)
   {
      if (Close_LotsFraction < 0 || Close_LotsFraction > 1)
      {
         Alert(OrderSymbol()+" PartCloseEnabled is disabled because 'Close_LotsFraction' is outside range 0-1 ");
         PartCloseEnabled = false;
      }
      else {
         Close_Lots = MathFloor(Close_LotsFraction * OrderLots() * 100) / 100;
         Preserve_Lots = OrderLots() - Close_Lots;
      }  // if (Close_LotsFract) < 0
   }//if (PartCloseEnabled == true)

[al3xx]

My humble question is , if you want to use a previous bar , should not be it shift + 1 ?

int weekYesterday = TimeDayOfWeek( iTime( NULL, tf, shift - 1 ) );

PC,

How right you are. And that is my code and my bad. Change it yourself until Al3xx can provide an update.

Al3xx, did you get this?

Paul

Thanks to pcorneli and Baluda, we have Version 1.3a on page 1 fixing the issue they describe. Thanks guys for spotting that.

Kind Regards,

Alex

[Riddermark]

Please note errors. CHFJPY opened 3 pairs. My settings were OnlyTradeCurrencyTwice = True. Also set UseCorrelationFilter = True, HighCorrelation = 80. See attached pic and .set file. Manually closed all 3 to attempt to temporarily fix problem.

Best regards.