markft wrote:

fx8000 wrote:
Hi Mahmut,

Attached below is a setup application I mentioned earlier.

Cheers,
Peter

Hi Peter,

Thanks for sending the installer. I could see the US30 with this one; so then found and fixed the issue. Please see updated version attached.

This should probably go to the Shell EA.

The issue occurs as the symbol US30 has 0 digits! In addition to failing the spread check, SL and TP would always be set to 0 with this one so it is quite dangerous.

Simplest solution is; in init:

Code: Select all

int init()
{
//----

   //Adapt to x digit criminals
   int multiplier;
   if(Digits == 2 || Digits == 4) multiplier = 1;
   if(Digits == 3 || Digits == 5) multiplier = 10;
   if(Digits == 6) multiplier = 100;   
   if(Digits == 7) multiplier = 1000;   

initialise multiplier to non-zero value to cater for all possibilities. That is:

Code: Select all

   int multiplier = 1;

fx8000 wrote:Hi Mahmut,

Thanks for helping out.

SwingONE 1.9.8 installed to US30 M15 chart. At 18.02 hr gmt, it executed a buy trade, but immediately closed it.

I have attached the EXPERTS log file below and also the SwingONE set file. I forgot to disable the Mptm EA that was use to manage the other currency pairs. MPTM set to breakeven at 30+0, part close enabled with JS at 30. MPTM set file also attached below.

I will disabled the MPTM EA to see what happens.

Cheers,
Peter

P.S. Before I could disable the MPTM EA, I noticed that at 18.46 hr gmt, a long was taken on US30, and this time, the trade is still running. HOORAY !!!

fx8000 wrote:Hi Khalid and Mahmut,

Apart from the Hanover trend filter, it would be extremely nice to have the All Averages trend filter found in Steve's other EA.

I could certainly use this with trading the US30 index, which I couldn't with Hanover.

Just a thought, not important.

MANY MANY THANKS AGAIN FOR THE FIX, MAHMUT !

Cheers,
Peter

markft wrote:

fx8000 wrote:Hi Khalid and Mahmut,

Apart from the Hanover trend filter, it would be extremely nice to have the All Averages trend filter found in Steve's other EA.

I could certainly use this with trading the US30 index, which I couldn't with Hanover.

Just a thought, not important.

MANY MANY THANKS AGAIN FOR THE FIX, MAHMUT !

Cheers,
Peter

Sounds like a good idea. I'll put this in to the next revision.

Khalaad wrote:The dictates of the system take precedence. But just out of interest, the chart is interesting.

Khalid

markft wrote:

fx8000 wrote:Hi Mahmut,

Thanks for helping out.

SwingONE 1.9.8 installed to US30 M15 chart. At 18.02 hr gmt, it executed a buy trade, but immediately closed it.

I have attached the EXPERTS log file below and also the SwingONE set file. I forgot to disable the Mptm EA that was use to manage the other currency pairs. MPTM set to breakeven at 30+0, part close enabled with JS at 30. MPTM set file also attached below.

Khalaad wrote:

AltosT wrote:Yeah, I hear ya. Diffent four hour charts on different criminals is indeed a nuisance. I have not done comparison with this but I exclusively use FXPro charts because they start the week at the right moment without a Sunday bar if you trade dailys. This keeps the charts clean. I actually prefer to trade 5 min charts but they are zoomed away out and the time of bar opening is irrelevant. The time of day is different as, for me, my trades tend to set up in Asian am and close in US session.

I just had a look but that is definitely not suited to swingOne. Maybe have a look at "Ducks in a row" here at Steve's. I have not examined it for four hour but a three MA system is usually quite effective. Maybe that could be brought in here to smooth out the pullbacks - only a thought and without examining maybe quite erroneous.

I will try and have a look over the weekend but it is Chinese New Year and my wife will be having many visitors.
Best regards,
Altos.

Thank you, Altos.

We (and this EA) are extremely lucky in the fact that Steve and Mahmut, completely dedicated with brook no compromise coding, are in this with us.

I am confident in time we shall have a winner.

Khalid