stevehopwoodforex.com
https://www.stevehopwoodforex.com/phpBB3/
Print view

Best Bob
https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=3566
Page 4 of 8
Author:  SteveHopwood [ Thu May 01, 2014 2:46 pm ]
Post subject:  Best Bob

bazze » Thu May 01, 2014 2:13 pm wrote:Steve,the EA have closed two trades in profit today(AUDUSD and AUDCAD):good: ...But,I got these alerts?
Now't to do with BB - doesn't call this indi.

I shall be uploading a new version later, with a fix for the rapid open/close thingy. I will explain later.

:xm:
Author:  bazze [ Thu May 01, 2014 2:58 pm ]
Post subject:  Best Bob

Good to hear,Steve...Thank you
Author:  SteveHopwood [ Thu May 01, 2014 10:58 pm ]
Post subject:  Best Bob

rapple, I feel I owe you an apology for being a tad harsh last night. So, sorry.

The chart you posted turned out to be most useful, because it shows that the offending trades are ct trades and the logic in the trade closure function is incorrect when dealing with ct trades. This had not surfaced on my demo because ct trading is disabled.

I thought I had this fixed earlier today but it turns out not to be so. Tommaso also has some fixes of his own, but somewhere along the line we have mis-communicated versions. We will sort out all of this in time for Monday.

In the meantime guys, turn off ct trading 'cos it will fail.

:xm:
Author:  rapple [ Fri May 02, 2014 1:52 am ]
Post subject:  Re: Best Bob

Thank you for the apology Steve. I really appreciate being back in the forum.

I have made another observation on the EA but will post it on Monday when I am back at my computer and can add the screen shots.

Kind regards Rapple
Author:  molliere [ Sun May 04, 2014 8:23 pm ]
Post subject:  Best Bob

Is there a possibility to include a filter referring to the DTMTL-ALERT that Nanningbot bring into 10.7 . If price breaks the trading line upwards then the trade is actually activated and the same for the downwards move.

Regards

Molliere
Author:  SteveHopwood [ Sun May 04, 2014 11:39 pm ]
Post subject:  Best Bob

molliere » Sun May 04, 2014 8:23 pm wrote:Is there a possibility to include a filter referring to the DTMTL-ALERT that Nanningbot bring into 10.7 . If price breaks the trading line upwards then the trade is actually activated and the same for the downwards move.

Regards

Molliere
No. Tomaso and I have not even got the damn yellow flip closure function working yet. What the blue blazes makes you think I am about to add another entry filter? Even if I knew what it was, which I don't. Or it was part of this bot's trading system, which it isn't.

Or cared, which I do not.

Guys, there is nothing wrong with the CT trade entry code.

There is nothing wrong with the CT trade closure code.

Yet BB takes a CT trade on one tick, then closes it on the next.

So there clearly is something something wrong with one of these procedures.

Buggered if I know what. Or can find it.

So, if you value your forum life, don't ask for some bloody silly filter that was never involved in the bot in the first place.

Doing so shows that you are not reading my posts here. Anybody here really need me to explain how much I hate it when people do that?

I will do so with pleasure, and people who know me of old will draw up ringside seats to watch.
Author:  SpiderX [ Mon May 05, 2014 12:12 am ]
Post subject:  Best Bob

Hi Steve

Could it be a bug due to having multiple magic numbers ?
Somehow somewhere the magic number for CT have not been considered ?

Cheers
Author:  phil_trade [ Mon May 05, 2014 5:47 am ]
Post subject:  Best Bob

SpiderX » Today, 02:12 wrote:Hi Steve

Could it be a bug due to having multiple magic numbers ?
Somehow somewhere the magic number for CT have not been considered ?

Cheers
In the same way, to assume an automatic distinction between pairs, we could use different MagicNumber

we can manage this with this code in INIT section (added lines 3 and 4 and 9) :

Code: Select all

   // Test to set automatic MagicNumber to each pair
   
   TrendMagicNumber=WindowHandle(Symbol(),0);
   CtMagicNumber=WindowHandle(Symbol(),0)+1;

   if (TrendMagicNumber == 0)  TrendMagicNumber=837746;
   if (CtMagicNumber == 0)  TrendMagicNumber=837747;

   Alert(Symbol()+" MN Trend = "+TrendMagicNumber+" MN CT Trend = "+CtMagicNumber);
it set the system handle of the chart window to MagicNumber to assure unique Integer.

EDIT :
Be careful with code, if you close and restart Empty4, New MN will be attribute to each graph as windows attribute new handle to each window.
I need to complete this code with Trade Detection and affectation of old MN
Author:  phil_trade [ Mon May 05, 2014 9:23 am ]
Post subject:  Best Bob

Steve

with this above modification, I have now the alert "Possible Rogue trade activity" that run well. BOB EA took and close 2 trades ok for me and then fired this alert.
So I suspect MagicNumber bug was the initial problem.

Philippe
Author:  SteveHopwood [ Mon May 05, 2014 10:23 am ]
Post subject:  Best Bob

phil_trade » Mon May 05, 2014 9:23 am wrote:Steve

with this above modification, I have now the alert "Possible Rogue trade activity" that run well. BOB EA took and close 2 trades ok for me and then fired this alert.
So I suspect MagicNumber bug was the initial problem.

Philippe
Nope. Definitely not this Phil. Most people go ootb and the magics are different by default. I will add code to enforce different magics, but this is definitely not the problem.

It does not matter whether a buy trade, for example, is a trend or ct trade - it is a buy and needs to close if the yellow line stays at 0 for the default of 15 minutes. Magic numbers are irrelevant here. I am not even sure that we need two different magic numbers - I will look into that.

Thanks for looking, but were it that simple I would already have found it.

Hehe.We all know what will happen now. A newcommer will find the fault and it will be that simple. :oops:

:xm:
All times are UTC Page 4 of 8