jjgengis wrote:

jjgengis wrote:Hi fx8000,

I would suggest a little modify at the code. I noticed that often the EA doesn't fail a trade with error 130 invalid stop. This because sometimes the stoplevel of some pairs , e.g. audndz, is high and the EA set a price not far enought .

With these two rows I solved the problem:

Code: Select all

   //Long 
   if (direction == up)
   {
      if (!TradeLong) return;
      price = NormalizeDouble(BarHigh + spread + (PlusOne * Point), Digits);
      if (TakeProfit > 0) take = NormalizeDouble(Ask + (TakeProfit * Point), Digits);
      stop = NormalizeDouble(BarLow, Digits);
// ************** modify to avoid stoplevel error ***********************
      double stoplevelprice = Bid -  NormalizeDouble(MarketInfo(Symbol(),MODE_STOPLEVEL)-20, Digits);
      if ( stoplevelprice < stop) stop = stoplevelprice;
// ************** end modify to avoid  stoplevel error ***********************
      type = OP_BUYSTOP;
      SendTrade = true;
   }//if (direction == up)
   

   //Short
   if (direction == down)
   {
      if (!TradeShort) return;
      price = NormalizeDouble(BarLow - spread - (PlusOne * Point), Digits);
      if (TakeProfit > 0) take = NormalizeDouble(Bid - (TakeProfit * Point), Digits);
      stop = NormalizeDouble(BarHigh, Digits);
// ************** modify to avoid  stoplevel error ***********************
      stoplevelprice = Ask +  NormalizeDouble(MarketInfo(Symbol(),MODE_STOPLEVEL)+20, Digits);
      if ( stoplevelprice > stop) stop = stoplevelprice;
// ************** end modify to avoid  stoplevel error ***********************

JJ

I apologize for the mistake, but the "20" must be "0.0002", or "20" must be multplied for point (20*point).

Code: Select all

 stoplevelprice = Ask +  NormalizeDouble(MarketInfo(Symbol(),MODE_STOPLEVEL)+( 20 * point) , Digits);

Sorry!

JJ

fx8000 wrote:

jjgengis wrote:

jjgengis wrote:Hi fx8000,

I would suggest a little modify at the code. I noticed that often the EA doesn't fail a trade with error 130 invalid stop. This because sometimes the stoplevel of some pairs , e.g. audndz, is high and the EA set a price not far enought .

With these two rows I solved the problem:

Code: Select all

   //Long 
   if (direction == up)
   {
      if (!TradeLong) return;
      price = NormalizeDouble(BarHigh + spread + (PlusOne * Point), Digits);
      if (TakeProfit > 0) take = NormalizeDouble(Ask + (TakeProfit * Point), Digits);
      stop = NormalizeDouble(BarLow, Digits);
// ************** modify to avoid stoplevel error ***********************
      double stoplevelprice = Bid -  NormalizeDouble(MarketInfo(Symbol(),MODE_STOPLEVEL)-20, Digits);
      if ( stoplevelprice < stop) stop = stoplevelprice;
// ************** end modify to avoid  stoplevel error ***********************
      type = OP_BUYSTOP;
      SendTrade = true;
   }//if (direction == up)
   

   //Short
   if (direction == down)
   {
      if (!TradeShort) return;
      price = NormalizeDouble(BarLow - spread - (PlusOne * Point), Digits);
      if (TakeProfit > 0) take = NormalizeDouble(Bid - (TakeProfit * Point), Digits);
      stop = NormalizeDouble(BarHigh, Digits);
// ************** modify to avoid  stoplevel error ***********************
      stoplevelprice = Ask +  NormalizeDouble(MarketInfo(Symbol(),MODE_STOPLEVEL)+20, Digits);
      if ( stoplevelprice > stop) stop = stoplevelprice;
// ************** end modify to avoid  stoplevel error ***********************

JJ

I apologize for the mistake, but the "20" must be "0.0002", or "20" must be multplied for point (20*point).

Code: Select all

 stoplevelprice = Ask +  NormalizeDouble(MarketInfo(Symbol(),MODE_STOPLEVEL)+( 20 * point) , Digits);

Sorry!

JJ

Hi JJ

No problem. I will make the correction and update the ea in post 1. The update this morning has not been downloaded by anyone yet.

Thanks again for your help.

Peter

Dennis4x wrote:Hi fx8000 and everyone who is interested in this bot,
If anyone is getting "Market is (0)" in the on-screen display, then I humbly suggest moving the line "GetRsiTrend();" from Steve's Addidtion to just before "//Reread the hi-lo of the ib lines".
Like this:
}//if (OldBars != iBars(NULL, PERIOD_H1)

GetRsiTrend(); <-----new location

//Reread the hi-lo of the ib lines
BarHigh = 0;
BarLow = 0;

Dennis4x wrote:Hi fx8000,
I got "Market is (0)" displayed on my screen instead of Market is (45.9572) or whatever the current RSI value is. Relocating that line as suggested will help fix that.
Unless, of course, I am the only one getting that, as I am really using my previous DIBS setting from July last year.
I was at chapter one last year too, so don't worry, you will be improve.
Don't know why there is not much interest in this bot. This is supposed to be based on a successful manual method after all. Anyway, I'd dropped this bot some time last year and just recently (-2 days ago) took another stab at it after you started this thread. So, keep up the good work!

Dennis4x wrote:fx8000,
Not sure about the closing errors as this EA has yet to open a trade for me.

As an aside, and I am not sure if you are aware of this or not - looking back at my old notes from last year - this EA, in its first incarnation - Jolly Roger's Inside Bar Trading EA (June 2011), opens lots of trades. Later, in July 2011, it was reborn as DIBs, and did so much less trades.

IMHO, I think we need to figure out whether there was some bug introduced in DIBs (July 2011) before we try anything else. Otherwise, we'll be trying to build new features into a faulty robot.

To confuse things further, the new version introduced in Sept 2011 is called Jolly Roger's Inside Bar Trading EA. I haven't tried that one as by then I had moved on and was playing with some of Steve's newer toys.

I am not a brilliant coder - just know a bit of coding - and will be happy to help out with some coding provided it's do-able for me and doesn't take up too much time.

If anybody wants to get hold of the June 2011 ver, I have the .MQ4 source somewhere with me. I'll like to do it but at the moment, I don't have enough processing power to start another Empty4 demo to visually compare the 2.